From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <jessyx.wu@intel.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v3] remove GCC build warning
Date: Sat, 8 Oct 2022 10:14:04 +0800 [thread overview]
Message-ID: <000e01d8dabb$a3839a00$ea8ace00$@byosoft.com.cn> (raw)
In-Reply-To: <c6f379b9e7cc186d393128d9bc4fe0cacec814ce.1664848913.git.jessyx.wu@intel.com>
Have you verified GCC5 and GCC49 tool chain?
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 JessyX Wu
> 发送时间: 2022年10月4日 10:04
> 收件人: devel@edk2.groups.io
> 抄送: JessyX Wu <jessyx.wu@intel.com>; Bob Feng <bob.c.feng@intel.com>;
> Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen
> <yuwei.chen@intel.com>
> 主题: [edk2-devel] [PATCH v3] remove GCC build warning
>
> Fix gcc: warning:
> -x c after last input file has no effect
>
> These kind of flag can only affect the source code after them.
> For the build command in build_rule.template, we have no other source code
> or object after these two flag.
> It seems we don't need them here.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: JessyX Wu <jessyx.wu@intel.com>
> ---
> BaseTools/Conf/build_rule.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/build_rule.template
> b/BaseTools/Conf/build_rule.template
> index 5895b48fd8..af4819de92 100755
> --- a/BaseTools/Conf/build_rule.template
> +++ b/BaseTools/Conf/build_rule.template
> @@ -463,7 +463,7 @@
>
> <Command.GCC>
> "$(ASLCC)" $(DEPS_FLAGS) -c -o
> $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS)
> $(DEPS_FLAGS) $(INC) ${src}
> - "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
> $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS)
> $(ASLCC_FLAGS)
> + "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
> $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
> "$(GENFW)" -o ${dst} -c
> $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS)
>
> <Command.CLANGPDB>
> --
> 2.37.3.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2022-10-08 2:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 2:03 [PATCH v3] remove GCC build warning JessyX Wu
2022-10-08 2:14 ` gaoliming [this message]
2022-10-18 1:35 ` [edk2-devel] 回复: [edk2-devel] " JessyX Wu
2022-10-19 1:10 ` 回复: " gaoliming
2022-10-24 5:22 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000e01d8dabb$a3839a00$ea8ace00$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox