[PATCH v3] remove GCC build warning

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH v3] remove GCC build warning
@ 2022-10-04  2:03 JessyX Wu
  2022-10-08  2:14 ` 回复: [edk2-devel] " gaoliming
  2022-10-24  5:22 ` Bob Feng
  0 siblings, 2 replies; 5+ messages in thread
From: JessyX Wu @ 2022-10-04  2:03 UTC (permalink / raw)
  To: devel; +Cc: JessyX Wu, Bob Feng, Liming Gao, Yuwei Chen

Fix gcc: warning:
 -x c after last input file has no effect

These kind of flag can only affect the source code after them.
For the build command in build_rule.template, we have no other source code or object after these two flag.
It seems we don't need them here.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: JessyX Wu <jessyx.wu@intel.com>
---
 BaseTools/Conf/build_rule.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index 5895b48fd8..af4819de92 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -463,7 +463,7 @@
 
     <Command.GCC>
         "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src}
-        "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS)
+        "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
         "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS)
 
     <Command.CLANGPDB>
-- 
2.37.3.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* 回复: [edk2-devel] [PATCH v3] remove GCC build warning
  2022-10-04  2:03 [PATCH v3] remove GCC build warning JessyX Wu
@ 2022-10-08  2:14 ` gaoliming
  2022-10-18  1:35   ` [edk2-devel] " JessyX Wu
  2022-10-24  5:22 ` Bob Feng
  1 sibling, 1 reply; 5+ messages in thread
From: gaoliming @ 2022-10-08  2:14 UTC (permalink / raw)
  To: devel, jessyx.wu; +Cc: 'Bob Feng', 'Yuwei Chen'

Have you verified GCC5 and GCC49 tool chain?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 JessyX Wu
> 发送时间: 2022年10月4日 10:04
> 收件人: devel@edk2.groups.io
> 抄送: JessyX Wu <jessyx.wu@intel.com>; Bob Feng <bob.c.feng@intel.com>;
> Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen
> <yuwei.chen@intel.com>
> 主题: [edk2-devel] [PATCH v3] remove GCC build warning
> 
> Fix gcc: warning:
>  -x c after last input file has no effect
> 
> These kind of flag can only affect the source code after them.
> For the build command in build_rule.template, we have no other source code
> or object after these two flag.
> It seems we don't need them here.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: JessyX Wu <jessyx.wu@intel.com>
> ---
>  BaseTools/Conf/build_rule.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/build_rule.template
> b/BaseTools/Conf/build_rule.template
> index 5895b48fd8..af4819de92 100755
> --- a/BaseTools/Conf/build_rule.template
> +++ b/BaseTools/Conf/build_rule.template
> @@ -463,7 +463,7 @@
> 
>      <Command.GCC>
>          "$(ASLCC)" $(DEPS_FLAGS) -c -o
> $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS)
> $(DEPS_FLAGS) $(INC) ${src}
> -        "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
> $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS)
> $(ASLCC_FLAGS)
> +        "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
> $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
>          "$(GENFW)" -o ${dst} -c
> $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS)
> 
>      <Command.CLANGPDB>
> --
> 2.37.3.windows.1
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3] remove GCC build warning
  2022-10-08  2:14 ` 回复: [edk2-devel] " gaoliming
@ 2022-10-18  1:35   ` JessyX Wu
  2022-10-19  1:10     ` 回复: " gaoliming
  0 siblings, 1 reply; 5+ messages in thread
From: JessyX Wu @ 2022-10-18  1:35 UTC (permalink / raw)
  To: gaoliming, devel

[-- Attachment #1: Type: text/plain, Size: 71 bytes --]

I had verified both GCC5 and GCC49, and the build processes are good.

[-- Attachment #2: Type: text/html, Size: 71 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* 回复: [edk2-devel] 回复: [edk2-devel] [PATCH v3] remove GCC build warning
  2022-10-18  1:35   ` [edk2-devel] " JessyX Wu
@ 2022-10-19  1:10     ` gaoliming
  0 siblings, 0 replies; 5+ messages in thread
From: gaoliming @ 2022-10-19  1:10 UTC (permalink / raw)
  To: devel, jessyx.wu

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Jessy:

 Thanks for your confirmation. The change should be fine. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 JessyX Wu
发送时间: 2022年10月18日 9:36
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3] remove GCC build warning

 

I had verified both GCC5 and GCC49, and the build processes are good. 




[-- Attachment #2: Type: text/html, Size: 3921 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] remove GCC build warning
  2022-10-04  2:03 [PATCH v3] remove GCC build warning JessyX Wu
  2022-10-08  2:14 ` 回复: [edk2-devel] " gaoliming
@ 2022-10-24  5:22 ` Bob Feng
  1 sibling, 0 replies; 5+ messages in thread
From: Bob Feng @ 2022-10-24  5:22 UTC (permalink / raw)
  To: Wu, JessyX, devel@edk2.groups.io; +Cc: Gao, Liming, Chen, Christine

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

Thanks,
Bob

-----Original Message-----
From: Wu, JessyX <jessyx.wu@intel.com> 
Sent: Tuesday, October 4, 2022 10:04 AM
To: devel@edk2.groups.io
Cc: Wu, JessyX <jessyx.wu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v3] remove GCC build warning

Fix gcc: warning:
 -x c after last input file has no effect

These kind of flag can only affect the source code after them.
For the build command in build_rule.template, we have no other source code or object after these two flag.
It seems we don't need them here.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: JessyX Wu <jessyx.wu@intel.com>
---
 BaseTools/Conf/build_rule.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index 5895b48fd8..af4819de92 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -463,7 +463,7 @@
 
     <Command.GCC>
         "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src}
-        "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS)
+        "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
         "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS)
 
     <Command.CLANGPDB>
-- 
2.37.3.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-10-24  5:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-04  2:03 [PATCH v3] remove GCC build warning JessyX Wu
2022-10-08  2:14 ` 回复: [edk2-devel] " gaoliming
2022-10-18  1:35   ` [edk2-devel] " JessyX Wu
2022-10-19  1:10     ` 回复: " gaoliming
2022-10-24  5:22 ` Bob Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox