From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.937.1608165790190921908
 for <devel@edk2.groups.io>;
 Wed, 16 Dec 2020 16:43:13 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Thu, 17 Dec 2020 08:43:04 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<bob.c.feng@intel.com>,
	<zhuenze@byosoft.com.cn>
Cc: "'Chen, Christine'" <yuwei.chen@intel.com>
References: <20201216062929.527-1-zhuenze@byosoft.com.cn> <DM6PR11MB40735388867E351E7EF45CFFC9C50@DM6PR11MB4073.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB40735388867E351E7EF45CFFC9C50@DM6PR11MB4073.namprd11.prod.outlook.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBCYXNlVG9vbHMvQ29tbW9uTGliLmg6IEJ1aWxkIGZhaWxlZCBkdWUgdG8gTUFYX0xPTkdfRklMRV9QQVRI?=
Date: Thu, 17 Dec 2020 08:43:08 +0800
Message-ID: <001001d6d40d$96cb5660$c4620320$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQI8Wos0vjmqP2n0hNQ7EWxSxmXgpgJVe3SwqRy6C9A=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Enze:
  Please include BZ link in the commit message. For this change,
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+68939+4905953+8761045@groups.io
> <bounce+27952+68939+4905953+8761045@groups.io> =B4=FA=B1=ED Bob Feng
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA12=D4=C216=C8=D5 15:17
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; zhuenze@byosoft.com.cn
> =B3=AD=CB=CD: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine
> <yuwei.chen@intel.com>
> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build fail=
ed due to
> MAX_LONG_FILE_PATH
>=20
> Hi Enze,
>=20
> Please remove the "Reviewed-by:" from the code review mail.
> Reviewer need to reply the code review mail with Reviewed-by.
>=20
> Thanks,
> Bob
>=20
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Enze Zhu
> Sent: Wednesday, December 16, 2020 2:29 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
> Subject: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to
> MAX_LONG_FILE_PATH
>=20
> We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
> We should use PATH_MAX if it is available.
>=20
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/BaseTools/Source/C/Common/CommonLib.h
> b/BaseTools/Source/C/Common/CommonLib.h
> index e1cce985f7..0f05d88db2 100644
> --- a/BaseTools/Source/C/Common/CommonLib.h
> +++ b/BaseTools/Source/C/Common/CommonLib.h
> @@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Common/UefiBaseTypes.h>  #include <Common/BuildVersion.h>
> #include <assert.h>
> +#ifndef _WIN32
> +#include <limits.h>
> +#endif
> +
>  #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
>=20
> +#ifdef PATH_MAX
> +#define MAX_LONG_FILE_PATH PATH_MAX
> +#else
>  #define MAX_LONG_FILE_PATH 500
> +#endif
>=20
>  #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)  #define
> MAX_UINT32 ((UINT32)0xFFFFFFFF)
> --
> 2.27.0.windows.1
>=20
>=20
>=20
>=20
>=20
>=20
>=20
>=20
>=20
>=20
>=20