[PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

[PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

[Enze Zhu]

We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
 BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Common/UefiBaseTypes.h>
 #include <Common/BuildVersion.h>
 #include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
 #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
 
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
 #define MAX_LONG_FILE_PATH 500
+#endif
 
 #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)
 #define MAX_UINT32 ((UINT32)0xFFFFFFFF)
-- 
2.27.0.windows.1

Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

[Bob Feng]

Hi Enze,

Please remove the "Reviewed-by:" from the code review mail. 
Reviewer need to reply the code review mail with Reviewed-by.

Thanks,
Bob

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Enze Zhu
Sent: Wednesday, December 16, 2020 2:29 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
 BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include <Common/UefiBaseTypes.h>  #include <Common/BuildVersion.h>  #include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
 #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
 
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
 #define MAX_LONG_FILE_PATH 500
+#endif
 
 #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)  #define MAX_UINT32 ((UINT32)0xFFFFFFFF)
--
2.27.0.windows.1

回复: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

[gaoliming]

Enze:
  Please include BZ link in the commit message. For this change,
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+68939+4905953+8761045@groups.io
> <bounce+27952+68939+4905953+8761045@groups.io> 代表 Bob Feng
> 发送时间: 2020年12月16日 15:17
> 收件人: devel@edk2.groups.io; zhuenze@byosoft.com.cn
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine
> <yuwei.chen@intel.com>
> 主题: Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to
> MAX_LONG_FILE_PATH
> 
> Hi Enze,
> 
> Please remove the "Reviewed-by:" from the code review mail.
> Reviewer need to reply the code review mail with Reviewed-by.
> 
> Thanks,
> Bob
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Enze Zhu
> Sent: Wednesday, December 16, 2020 2:29 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
> Subject: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to
> MAX_LONG_FILE_PATH
> 
> We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
> We should use PATH_MAX if it is available.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/BaseTools/Source/C/Common/CommonLib.h
> b/BaseTools/Source/C/Common/CommonLib.h
> index e1cce985f7..0f05d88db2 100644
> --- a/BaseTools/Source/C/Common/CommonLib.h
> +++ b/BaseTools/Source/C/Common/CommonLib.h
> @@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Common/UefiBaseTypes.h>  #include <Common/BuildVersion.h>
> #include <assert.h>
> +#ifndef _WIN32
> +#include <limits.h>
> +#endif
> +
>  #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
> 
> +#ifdef PATH_MAX
> +#define MAX_LONG_FILE_PATH PATH_MAX
> +#else
>  #define MAX_LONG_FILE_PATH 500
> +#endif
> 
>  #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)  #define
> MAX_UINT32 ((UINT32)0xFFFFFFFF)
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>