public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <jbrasen@nvidia.com>
Cc: <jian.j.wang@intel.com>, <zhichao.gao@intel.com>, <ray.ni@intel.com>
Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Date: Tue, 19 Jul 2022 09:43:46 +0800	[thread overview]
Message-ID: <001001d89b10$fc9254a0$f5b6fde0$@byosoft.com.cn> (raw)
In-Reply-To: <9c52d44c283b1c42de20ee373be1d4994c4daf35.1655229046.git.jbrasen@nvidia.com>

Jeff:
  I want to confirm why UFS apply the same rule to SCSI. Does UFS follows
SCSI spec?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff Brasen
> via groups.io
> 发送时间: 2022年6月15日 1:54
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk
> Info support for Ufs
> 
> Add support for getting disk info from UFS devices.
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> ++-
>  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index fac33b9ee9..87b82f299f 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> 
> 
>        BmEliminateExtraSpaces (Description);
> 
>      }
> 
> -  } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid)) {
> 
> +  } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid) ||
> 
> +             CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoUfsInterfaceGuid)) {
> 
>      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> 
>      Status     = DiskInfo->Inquiry (
> 
>                               DiskInfo,
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..2fc0a80a4e 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -85,6 +85,7 @@
>    gEfiDiskInfoIdeInterfaceGuid                  ##
> SOMETIMES_CONSUMES ## GUID
> 
>    gEfiDiskInfoScsiInterfaceGuid                 ##
> SOMETIMES_CONSUMES ## GUID
> 
>    gEfiDiskInfoSdMmcInterfaceGuid                ##
> SOMETIMES_CONSUMES ## GUID
> 
> +  gEfiDiskInfoUfsInterfaceGuid                  ##
> SOMETIMES_CONSUMES ## GUID
> 
> 
> 
>  [Protocols]
> 
>    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> 
> --
> 2.25.1
> 
> 
> 
> 
> 
> 




  parent reply	other threads:[~2022-07-19  1:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 17:53 [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Jeff Brasen
2022-07-07 18:14 ` Jeff Brasen
2022-07-18  8:13   ` [edk2-devel] " Gao, Zhichao
2022-07-19  1:43 ` gaoliming [this message]
2022-07-19 15:14   ` Jeff Brasen
2022-10-06 14:23     ` Jeff Brasen
2022-10-06 14:38       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001001d89b10$fc9254a0$f5b6fde0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox