From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8F052245119C for ; Thu, 1 Mar 2018 03:57:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 04:03:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,408,1515484800"; d="scan'208";a="204710071" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.13]) ([10.239.9.13]) by orsmga005.jf.intel.com with ESMTP; 01 Mar 2018 04:03:34 -0800 To: Laszlo Ersek , Heyi Guo , edk2-devel@lists.01.org Cc: Jordan Justen , Anthony Perard , Julien Grall , Ard Biesheuvel References: <1519887444-75510-1-git-send-email-heyi.guo@linaro.org> <1519887444-75510-3-git-send-email-heyi.guo@linaro.org> From: "Ni, Ruiyu" Message-ID: <001017d1-42ae-8376-6410-3f6f34f6c3f5@Intel.com> Date: Thu, 1 Mar 2018 20:03:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 11:57:28 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/1/2018 6:20 PM, Laszlo Ersek wrote: > On 03/01/18 07:57, Heyi Guo wrote: >> Use ZeroMem to initialize all fields in temporary >> PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but >> is helpful for future extension: when we add new fields to >> PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can >> safely be zero, this code will not suffer from an additional >> change. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Heyi Guo >> >> Cc: Jordan Justen >> Cc: Anthony Perard >> Cc: Julien Grall >> Cc: Ruiyu Ni >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> --- >> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++++ >> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 5 +++++ >> 2 files changed, 9 insertions(+) > > I also suggest a different subject line: > > OvmfPkg/PciHostBridgeLib: clear PCI_ROOT_BRIDGE_APERTURE vars for (re)init > > (74 chars) I sometimes tries very hard to make the subject line be <= 70 chars. 74 is acceptable? > > Thanks > Laszlo > -- Thanks, Ray