From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.4679.1668427016823456296 for ; Mon, 14 Nov 2022 03:56:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=r/dW3WcV; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 58877CD1F786 for ; Mon, 14 Nov 2022 19:56:53 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1668427013; bh=nQwAjyWeg3OeSVW4FZU2m66CrI2m2AM3yD4W0QwV+Ro=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=r/dW3WcVzAAKl6aJO6hu5G1It3Vw73qaolloNVboo4/fH86CLFASZo5heGT9wy+E7 OLbXbZlaZCVIwKPTOubD7RWxnSWZS6mXRw4bf5OQO+/2xz+Ae4uplHBJ1CCRTvSbuP PdHY/N9UvGA3sE8rQNsEbeYe7Pi13WOulonXaaqM= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 54624CD1F780 for ; Mon, 14 Nov 2022 19:56:53 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 258BCCD1F760 for ; Mon, 14 Nov 2022 19:56:53 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id B0EF1CD1F74C for ; Mon, 14 Nov 2022 19:56:49 +0800 (CST) Received: from DESKTOPS6D0PVI ([101.86.144.134]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 14 Nov 2022 19:56:44 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.86.144.134 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Xu, Min M'" Cc: "'Dong, Eric'" , "'Ni, Ray'" , "'Brijesh Singh'" , "'Aktas, Erdem'" , "'Gerd Hoffmann'" , "'James Bottomley'" , "'Tom Lendacky'" , "'Dong, Guo'" , "'Rhodes, Sean'" , "'Lu, James'" , "'Guo, Gua'" , "'Kinney, Michael D'" References: <20221111071710.1596-1-min.m.xu@intel.com> <1727585BE67BAA7B.24122@groups.io> In-Reply-To: <1727585BE67BAA7B.24122@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItc3RhYmxlMjAyMjExXSBbUEFUQ0ggVjYgMC8zXSBSZW5hbWUgVm1nRXhpdExpYiB0byBDY0V4aXRMaWI=?= Date: Mon, 14 Nov 2022 19:56:44 +0800 Message-ID: <001501d8f820$2b115df0$813419d0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGC1LGsbVfgP7k6M2IOU8hpJcVReAHkjf9fApId4QWuxuFgMA== Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn This patch set has been merged by https://github.com/tianocore/edk2/pull/3627 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED gaoliming via > groups.io > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA11=D4=C214=C8=D5 12:15 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; jiewen.yao@intel.com; 'Xu, Min = M' > > =B3=AD=CB=CD: 'Dong, Eric' ; 'Ni, Ray' ; > 'Brijesh Singh' ; 'Aktas, Erdem' > ; 'Gerd Hoffmann' ; 'James > Bottomley' ; 'Tom Lendacky' > ; 'Dong, Guo' ; 'Rhodes, > Sean' ; 'Lu, James' ; 'Guo, > Gua' ; 'Kinney, Michael D' > =D6=F7=CC=E2: =BB=D8=B8=B4: [edk2-devel] [edk2-stable202211] [PATCH V6 0/= 3] Rename > VmgExitLib to CcExitLib >=20 > Jiewen: > This patch set has passed code review before soft feature freeze phase. > And, there is no code change recently. So, I agree to merge this patch se= t > for the stable tag. >=20 > I will help merge it. >=20 > Thanks > Liming > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Yao, > Jiewen > > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA11=D4=C212=C8=D5 10:50 > > =CA=D5=BC=FE=C8=CB: Xu, Min M ; devel@edk2.groups.i= o > > =B3=AD=CB=CD: Dong, Eric ; Ni, Ray ; > Brijesh > > Singh ; Aktas, Erdem ; > > Gerd Hoffmann ; James Bottomley > > ; Tom Lendacky ; > Dong, > > Guo ; Rhodes, Sean ; Lu, > > James ; Guo, Gua ; Kinney, > > Michael D ; Gao, Liming > > > > =D6=F7=CC=E2: [edk2-devel] [edk2-stable202211] [PATCH V6 0/3] Rename > VmgExitLib > > to CcExitLib > > > > Reviewed by: Jiewen Yao > > > > Hi Mike/Liming > > I suggest this be in edk2-stable202211. > > > > Thank you > > Yao, Jiewen > > > > > -----Original Message----- > > > From: Xu, Min M > > > Sent: Friday, November 11, 2022 3:17 PM > > > To: devel@edk2.groups.io > > > Cc: Xu, Min M ; Dong, Eric ; > > > Ni, Ray ; Brijesh Singh ; > Aktas, > > > Erdem ; Gerd Hoffmann > ; > > > James Bottomley ; Yao, Jiewen > > > ; Tom Lendacky ; > > > Dong, Guo ; Rhodes, Sean > ; > > > Lu, James ; Guo, Gua ; Kinney, > > > Michael D ; Gao, Liming > > > > > > Subject: [PATCH V6 0/3] Rename VmgExitLib to CcExitLib > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4123 > > > > > > VmgExitLib once was designed to provide interfaces to support #VC > handler > > > and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF= ) > is > > > introduced, this library is updated to support #VE as well. Now the name > > > of VmgExitLib cannot reflect what the lib does. > > > > > > This patch-set renames VmgExitLib to CcExitLib (Cc means Confidential > > > Computing). This is simple renaming and there is no logic changes. Then > > > APIs defined in CcExitLib.h are added with a CcExit prefix. This is t= o > > > make the name more meaningful. > > > > > > Please to be noted, changing the name of VmgExitLib to CcExitLib is a > > > non-backwards compatible change from a platform DSC file perspective > for > > > downstream consumers. So for downstream platform below changes > > > should > > > be applied: > > > 1. For DSC files: > > > - VmgExitLib|OvmfPkg/Library/VmgExitLib/SecVmgExitLib.inf =3D> > > > CcExitLib|OvmfPkg/Library/CcExitLib/SecCcExitLib.inf > > > > > > - VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf =3D= > > > > CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf > > > > > > - VmgExitLib|OvmfPkg/Library/VmgExitLib/VmgExitLib.inf =3D> > > > CcExitLib|OvmfPkg/Library/CcExitLib/CcExitLib.inf > > > > > > 2. For INF files: > > > - VmgExitLib =3D> CcExitLib > > > > > > 3. For Header files > > > - #include =3D> #include > > > > > > 4. For C files > > > - Replace the APIs defined in the VmgExitLib.h with the ones defined in > > > CcExitLib.h. The old name is renamed by adding a prefix (CcExit). > > > For example VmgInit is renamed as CcExitVmgInit. > > > > > > Code: https://github.com/mxu9/edk2/tree/CcExitLib.v5 > > > > > > v6 changes: > > > - Fix a typo in patch0@v5. > > > - No other changes from v5. So the code is same as v5. > > > > > > v5 changes: > > > - Rebased the code base to c17c3c24d8. > > > - Add instructions in patch#0 on what updates to a downstream > > > platform DSC. > > > > > > v4 changes: > > > - The previous versions of the patch-set are to first duplicate a ne= w > > > CcExitLib then delete the old VmgExitLib. According to this comments > > > https://edk2.groups.io/g/devel/message/96019 it suggests renaming > in > > > a single patch is better. > > > - Lib APIs are added with CcExit prefix, not CcExitLib prefix. > > > > > > v3 changes: > > > - Rename CcExitHandleVc / CcExitHandleVe to > > > CcExitLibHandleVc / CcExitLibHandleVe to make the nameing > > consistent. > > > - Update the CcExitLib to merge the patch eff44c008d99 > > > (OvmfPkg/VmgExitLig: HALT on #VE when access to private memory). > > > > > > v2 changes: > > > - Patch #3 is added to import CcExitLib in OvmfPkg's *.dsc. This is to > > > prevent the building from being broken in the following patches. > > > > > > Cc: Eric Dong > > > Cc: Ray Ni > > > Cc: Brijesh Singh > > > Cc: Erdem Aktas > > > Cc: Gerd Hoffmann > > > Cc: James Bottomley > > > Cc: Jiewen Yao > > > Cc: Tom Lendacky > > > Cc: Guo Dong > > > Cc: Sean Rhodes > > > Cc: James Lu > > > Cc: Gua Guo > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Signed-off-by: Min Xu > > > > > > Min M Xu (3): > > > OvmfPkg/UefiCpuPkg/UefiPayloadPkg: Rename VmgExitLib to > CcExitLib > > > OvmfPkg/UefiCpuPkg: Add CcExit prefix to the APIs of CcExitLib > > > Maintainers: Update the VmgExitLib to CcExitLib > > > > > > Maintainers.txt | 2 +- > > > OvmfPkg/AmdSev/AmdSevX64.dsc | 4 +- > > > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > > > OvmfPkg/CloudHv/CloudHvX64.dsc | 6 +- > > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 +- > > > .../DxeMemEncryptSevLib.inf | 2 +- > > > .../PeiMemEncryptSevLib.inf | 2 +- > > > .../SecMemEncryptSevLib.inf | 2 +- > > > .../X64/SnpPageStateChangeInternal.c | 10 +- > > > .../VmgExitLib.c =3D> CcExitLib/CcExitLib.c} | 23 ++-- > > > .../CcExitLib.inf} | 17 +-- > > > .../CcExitTd.h} | 4 +- > > > .../CcExitVcHandler.c} | 129 > > +++++++++--------- > > > .../CcExitVcHandler.h} | 6 +- > > > .../CcExitVeHandler.c} | 6 +- > > > .../PeiDxeCcExitVcHandler.c} | 6 +- > > > .../SecCcExitLib.inf} | 14 +- > > > .../SecCcExitVcHandler.c} | 6 +- > > > .../X64/TdVmcallCpuid.nasm | 0 > > > OvmfPkg/Microvm/MicrovmX64.dsc | 4 +- > > > OvmfPkg/OvmfPkgIa32.dsc | 4 +- > > > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +- > > > OvmfPkg/OvmfPkgX64.dsc | 6 +- > > > OvmfPkg/OvmfXen.dsc | 2 +- > > > OvmfPkg/PlatformPei/AmdSev.c | 10 +- > > > OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- > > > .../FvbServicesRuntimeDxe.inf | 2 +- > > > .../QemuFlashDxe.c | 10 +- > > > .../Library/{VmgExitLib.h =3D> CcExitLib.h} | 29 ++-- > > > .../CcExitLibNull.c} | 47 +++++-- > > > .../CcExitLibNull.inf} | 12 +- > > > .../Library/CcExitLibNull/CcExitLibNull.uni | 14 ++ > > > .../DxeCpuExceptionHandlerLib.inf | 2 +- > > > .../PeiCpuExceptionHandlerLib.inf | 2 +- > > > .../PeiDxeSmmCpuException.c | 6 +- > > > .../SecPeiCpuException.c | 6 +- > > > .../SecPeiCpuExceptionHandlerLib.inf | 2 +- > > > .../SmmCpuExceptionHandlerLib.inf | 2 +- > > > .../Xcode5SecPeiCpuExceptionHandlerLib.inf | 2 +- > > > UefiCpuPkg/Library/MpInitLib/AmdSev.c | 10 +- > > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 2 +- > > > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 8 +- > > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > > > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 2 +- > > > UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 10 +- > > > .../Library/VmgExitLibNull/VmTdExitNull.c | 38 ------ > > > .../Library/VmgExitLibNull/VmgExitLibNull.uni | 15 -- > > > UefiCpuPkg/UefiCpuPkg.dec | 4 +- > > > UefiCpuPkg/UefiCpuPkg.dsc | 4 +- > > > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- > > > 50 files changed, 252 insertions(+), 258 deletions(-) > > > rename OvmfPkg/Library/{VmgExitLib/VmgExitLib.c =3D> > > CcExitLib/CcExitLib.c} > > > (89%) > > > rename OvmfPkg/Library/{VmgExitLib/VmgExitLib.inf =3D> > > > CcExitLib/CcExitLib.inf} (66%) > > > rename OvmfPkg/Library/{VmgExitLib/VmTdExitHandler.h =3D> > > > CcExitLib/CcExitTd.h} (86%) > > > rename OvmfPkg/Library/{VmgExitLib/VmgExitVcHandler.c =3D> > > > CcExitLib/CcExitVcHandler.c} (90%) > > > rename OvmfPkg/Library/{VmgExitLib/VmgExitVcHandler.h =3D> > > > CcExitLib/CcExitVcHandler.h} (89%) > > > rename OvmfPkg/Library/{VmgExitLib/VmTdExitVeHandler.c =3D> > > > CcExitLib/CcExitVeHandler.c} (95%) > > > rename OvmfPkg/Library/{VmgExitLib/PeiDxeVmgExitVcHandler.c =3D> > > > CcExitLib/PeiDxeCcExitVcHandler.c} (93%) > > > rename OvmfPkg/Library/{VmgExitLib/SecVmgExitLib.inf =3D> > > > CcExitLib/SecCcExitLib.inf} (79%) > > > rename OvmfPkg/Library/{VmgExitLib/SecVmgExitVcHandler.c =3D> > > > CcExitLib/SecCcExitVcHandler.c} (93%) > > > rename OvmfPkg/Library/{VmgExitLib =3D> > > > CcExitLib}/X64/TdVmcallCpuid.nasm (100%) > > > rename UefiCpuPkg/Include/Library/{VmgExitLib.h =3D> CcExitLib.h} > (87%) > > > rename UefiCpuPkg/Library/{VmgExitLibNull/VmgExitLibNull.c =3D> > > > CcExitLibNull/CcExitLibNull.c} (76%) > > > rename UefiCpuPkg/Library/{VmgExitLibNull/VmgExitLibNull.inf =3D> > > > CcExitLibNull/CcExitLibNull.inf} (60%) > > > create mode 100644 > UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.uni > > > delete mode 100644 > UefiCpuPkg/Library/VmgExitLibNull/VmTdExitNull.c > > > delete mode 100644 > > > UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.uni > > > > > > -- > > > 2.29.2.windows.2 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20