From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=210.71.195.45; helo=out01.hibox.biz; envelope-from=tim.lewis@insyde.com; receiver=edk2-devel@lists.01.org Received: from out01.hibox.biz (out05.hibox.biz [210.71.195.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC61621E48F29 for ; Thu, 25 Jan 2018 09:47:39 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2C/AgCNF2pa/ws0GKxcGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYNCZnQnjnWPdzIBgxiUDYICChgLhRIEAgKCF1gVAQEBAQEBAQE?= =?us-ascii?q?CayhCDAGEVAEBAQQBAQYCHhIcCBACCQwBAwIGAw0EBAEBKAcZDgERDQkIAgQBE?= =?us-ascii?q?gsFiCoEgV8DFRC2WTghAoowAQEBAQEFAQEBAQEeBYRRgTWCN2yEKoFdgVIBAwG?= =?us-ascii?q?BOwESAYV7IAWTTo9oVAKCSoM6gg+GWldBhVuCGyOFfIQIh2ONXIl+gTw1Iw1Tc?= =?us-ascii?q?HBSgipAgkmBbyA3AYdwhA2CPAEBAQ?= X-IronPort-AV: E=Sophos;i="5.46,412,1511798400"; d="scan'208";a="18445972" Received: from unknown (HELO hb3-BKT201.hibox.biz) ([172.24.52.11]) by out01.hibox.biz with ESMTP; 26 Jan 2018 01:53:05 +0800 Received: from unknown (HELO hb3-BKT103.hibox.biz) ([172.24.51.13]) by hb3-BKT201.hibox.biz with ESMTP; 26 Jan 2018 01:53:05 +0800 Received: from unknown (HELO hb3-IN05.hibox.biz) ([172.24.12.15]) by hb3-BKT103.hibox.biz with ESMTP; 26 Jan 2018 01:53:05 +0800 X-Remote-IP: 73.116.1.175 X-Remote-Host: c-73-116-1-175.hsd1.ca.comcast.net X-SBRS: -10.0 X-MID: 10815489 X-Auth-ID: tim.lewis@insyde.com X-EnvelopeFrom: tim.lewis@insyde.com hiBox-Sender: 1 Received: from c-73-116-1-175.hsd1.ca.comcast.net (HELO DESKTOPAVHFBJF) ([73.116.1.175]) by hb3-IN05.hibox.biz with ESMTP/TLS/AES256-SHA; 26 Jan 2018 01:53:03 +0800 From: "Tim Lewis" To: "'Supreeth Venkatesh'" , "'Marvin H?user'" , Cc: , References: <20180123200303.5547-1-supreeth.venkatesh@arm.com> In-Reply-To: Date: Thu, 25 Jan 2018 09:52:57 -0800 Message-ID: <001601d39605$580f31b0$082d9510$@insyde.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHRsawnNJRW8ShVVD/YY8+hCckOpwGplRoGAeooBbGjbAjN8A== Subject: Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 17:47:41 -0000 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-language: en-us Supreeth -- Doesn't Appendix A of the PI 1.6 define this as: #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE Thanks, Tim -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Supreeth Venkatesh Sent: Thursday, January 25, 2018 9:45 AM To: Marvin H?user ; edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com; liming.gao@intel.com Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Marvin, Thanks for your comments. As per PI v1.6 specification, EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support MM Traditional Mode.) This is traditional MM mode, which ARM is not supporting at this point. We are more interested in MM_CORE_STANDALONE mode. However, I have no issues in adding this in the patch, but would prefer if this is added when MM traditional mode is supported in ARM. Further, w.r.t defining *_SMM_* definitions via the *_MM_* definitions. I don't want to break backwards compatibility with existing SMM traditional mode implementations. I will be happy to let folks who have migrated to _MM_ definitions from _SMM_ definitions to send the patch across. Thanks, Supreeth -----Original Message----- From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] Sent: Tuesday, January 23, 2018 6:34 PM To: edk2-devel@lists.01.org Cc: Supreeth Venkatesh ; michael.d.kinney@intel.com; liming.gao@intel.com Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Good day, I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" (0x0C). Furthermore, may I suggest changing the *_SMM_* definitions to be defined via the *_MM_* definitions? Best regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Tuesday, January 23, 2018 9:03 PM > To: edk2-devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV > file type and depex. > > As per PI specification v1.6, > The following new file types are added: > EFI_FV_FILETYPE_MM_STANDALONE > EFI_FV_FILETYPE_MM_CORE_STANDALONE > > The following new section type is added: > EFI_SECTION_MM_DEPEX > > This patch adds the management mode FV file type and depex. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Reviewed-by: Jiewen Yao > --- > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > b/MdePkg/Include/Pi/PiFirmwareFile.h > index b982c9eda3..6086d1bb2f 100644 > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > #define EFI_FV_FILETYPE_APPLICATION 0x09 > #define EFI_FV_FILETYPE_SMM 0x0A > +#define EFI_FV_FILETYPE_MM 0x0A > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > #define EFI_SECTION_RAW 0x19 > #define EFI_SECTION_PEI_DEPEX 0x1B > #define EFI_SECTION_SMM_DEPEX 0x1C > +#define EFI_SECTION_MM_DEPEX 0x1C > > /// > /// Common section header. > -- > 2.14.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel