回复: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol

["gaoliming" <gaoliming@byosoft.com.cn>]

Abner:
 I have some comments in MdePkg/Include/Protocol/RedfishDiscover.h

1. Please update file header to describe this protocol defined in which UEFI
spec version. 
2. Remove unnecessary include header files. I don't see this protocol
depends the definitions from them. Uefi.h is not required. It is always
included by module. 
#include <IndustryStandard/Http11.h>
#include <Protocol/Http.h>
#include <Protocol/RestEx.h>
#include <Uefi.h>
3. EFI_REDFISH_DISCOVER_NETWORK_INSTANCE. UEFI spec defines it as
EFI_REDFISH_DISCOVER_NETWORK_INTERFACE. Please correct it. 
4. I don't find EFI_REDFISH_DISCOVER_DURATION_BIT_POS in UEFI spec. Please
clarify it. 
5. typedef needs new type name. If no new type name, typedef should be
removed. 
typedef struct _EFI_REDFISH_DISCOVERED_INFORMATION {  ==> struct
_EFI_REDFISH_DISCOVERED_INFORMATION
  EFI_HANDLE RedfishRestExHandle;           ///< REST EX EFI handle
associated with this Redfish service.
  BOOLEAN         IsUdp6;                   ///< Indicates it's IP versino
6.
  EFI_IP_ADDRESS  RedfishHostIpAddress;     ///< IP address of Redfish
service.
  UINTN RedfishVersion;                     ///< Redfish service version.
  CHAR16 *Location;                         ///< Redfish service location.
  CHAR16 *Uuid;                             ///< Redfish service UUID.
  CHAR16 *Os;                               ///< Redfish service OS.
  CHAR16 *OSVersion;                        ///< Redfish service OS version.
  CHAR16 *Product;                          ///< Redfish service product
name.
  CHAR16 *ProductVer;                       ///< Redfish service product
version.
  BOOLEAN UseHttps;                         ///< Using HTTPS.
}; // there is no type name here. 
6. EFI_REDFISH_DISCOVER_PROTOCOL has been defined previously. Don't need
typedef again.
typedef struct _EFI_REDFISH_DISCOVER_PROTOCOL {
  EFI_REDFISH_DISCOVER_NETWORK_LIST    GetNetworkInterfaceList;
  EFI_REDFISH_DISCOVER_ACQUIRE_SERVICE AcquireRedfishService;
  EFI_REDFISH_DISCOVER_ABORT_ACQUIRE   AbortAcquireRedfishService;
  EFI_REDFISH_DISCOVER_RELEASE_SERVICE ReleaseRedfishService;
} EFI_REDFISH_DISCOVER_PROTOCOL;
7. Remove below two extern ProtocolGuid. They are not defined in this header
file. 

extern EFI_GUID gEfiRestExProtocolGuid;
extern EFI_GUID gEfiRestExServiceBindingProtocolGuid;

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66912+4905953+8761045@groups.io
> <bounce+27952+66912+4905953+8761045@groups.io> 代表 Abner Chang
> 发送时间: 2020年11月3日 12:49
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Nickle
> Wang <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> 主题: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish
> Discover protocol
> 
> Move GUID definition of EFI Redfish Discover protocol
> to under MdePkg. With this we don't have dependency of
> RedfishPkg in ShellPkg.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> ---
>  {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h | 0
>  MdePkg/MdePkg.dec                                         | 3
> +++
>  RedfishPkg/RedfishPkg.dec                                 | 4 ----
>  3 files changed, 3 insertions(+), 4 deletions(-)
>  rename {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h (100%)
> 
> diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h
> b/MdePkg/Include/Protocol/RedfishDiscover.h
> similarity index 100%
> rename from RedfishPkg/Include/Protocol/RedfishDiscover.h
> rename to MdePkg/Include/Protocol/RedfishDiscover.h
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index 645f61b80e..839bcfe063 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -1858,6 +1858,9 @@
>    ## Include/Protocol/RestJsonStructure.h
>    gEfiRestJsonStructureProtocolGuid  = { 0xa9a048f6, 0x48a0, 0x4714,
> {0xb7, 0xda, 0xa9, 0xad,0x87, 0xd4, 0xda, 0xc9 }}
> 
> +  ## Include/Protocol/RedfishDiscover.h
> +  gEfiRedfishDiscoverProtocolGuid      = { 0x5db12509, 0x4550, 0x4347,
> { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }}
> +
>    #
>    # Protocols defined in Shell2.0
>    #
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> index f12f83526c..65e21f6bd6 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -21,10 +21,6 @@
>    #   Platform implementation-specific Redfish Host Interface.
> 
> RedfishPlatformHostInterfaceLib|Include/Library/RedfishHostInterfaceLib.h
> 
> -[Protocols]
> -  ## Include/Protocol/RedfishDiscover.h
> -  gEfiRedfishDiscoverProtocolGuid      = { 0x5db12509, 0x4550, 0x4347,
> { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }}
> -
>  [Guids]
>    gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c,
> { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> 
> --
> 2.17.1
> 
> 
> 
> 
>