* [EFI Shell PATCH 0/2] Support EFI Redfish protocols
@ 2020-11-03 4:49 Abner Chang
2020-11-03 4:49 ` [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol Abner Chang
2020-11-03 4:49 ` [EFI Shell PATCH 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Abner Chang
0 siblings, 2 replies; 6+ messages in thread
From: Abner Chang @ 2020-11-03 4:49 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Zhichao Gao,
Nickle Wang, Peter O'Hanley
Add handle parsing for EFI Redfish Discover protocol and
EFI RestEx protocol.
This change also moves the GUID definition of EFI Redfish Discover
protocol to under MdePkg. With this we don't have dependency of
RedfishPkg in ShellPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Peter O'Hanley <peter.ohanley@hpe.com>
Abner Chang (2):
MdePkg/Include: EFI Redfish Discover protocol
ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
{RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h | 0
MdePkg/MdePkg.dec | 3 +++
RedfishPkg/RedfishPkg.dec | 4 ----
.../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 ++++++--
.../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-
.../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++-
6 files changed, 15 insertions(+), 8 deletions(-)
rename {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h (100%)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol 2020-11-03 4:49 [EFI Shell PATCH 0/2] Support EFI Redfish protocols Abner Chang @ 2020-11-03 4:49 ` Abner Chang 2020-11-05 1:23 ` 回复: [edk2-devel] " gaoliming 2020-11-03 4:49 ` [EFI Shell PATCH 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Abner Chang 1 sibling, 1 reply; 6+ messages in thread From: Abner Chang @ 2020-11-03 4:49 UTC (permalink / raw) To: devel Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Nickle Wang, Peter O'Hanley Move GUID definition of EFI Redfish Discover protocol to under MdePkg. With this we don't have dependency of RedfishPkg in ShellPkg. Signed-off-by: Abner Chang <abner.chang@hpe.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Nickle Wang <nickle.wang@hpe.com> Cc: Peter O'Hanley <peter.ohanley@hpe.com> --- {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h | 0 MdePkg/MdePkg.dec | 3 +++ RedfishPkg/RedfishPkg.dec | 4 ---- 3 files changed, 3 insertions(+), 4 deletions(-) rename {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h (100%) diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h b/MdePkg/Include/Protocol/RedfishDiscover.h similarity index 100% rename from RedfishPkg/Include/Protocol/RedfishDiscover.h rename to MdePkg/Include/Protocol/RedfishDiscover.h diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 645f61b80e..839bcfe063 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -1858,6 +1858,9 @@ ## Include/Protocol/RestJsonStructure.h gEfiRestJsonStructureProtocolGuid = { 0xa9a048f6, 0x48a0, 0x4714, {0xb7, 0xda, 0xa9, 0xad,0x87, 0xd4, 0xda, 0xc9 }} + ## Include/Protocol/RedfishDiscover.h + gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} + # # Protocols defined in Shell2.0 # diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index f12f83526c..65e21f6bd6 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -21,10 +21,6 @@ # Platform implementation-specific Redfish Host Interface. RedfishPlatformHostInterfaceLib|Include/Library/RedfishHostInterfaceLib.h -[Protocols] - ## Include/Protocol/RedfishDiscover.h - gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} - [Guids] gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol 2020-11-03 4:49 ` [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol Abner Chang @ 2020-11-05 1:23 ` gaoliming 2020-11-06 8:33 ` Abner Chang 2020-11-06 8:36 ` Abner Chang 0 siblings, 2 replies; 6+ messages in thread From: gaoliming @ 2020-11-05 1:23 UTC (permalink / raw) To: devel, abner.chang Cc: 'Michael D Kinney', 'Zhiguang Liu', 'Nickle Wang', 'Peter O'Hanley' Abner: I have some comments in MdePkg/Include/Protocol/RedfishDiscover.h 1. Please update file header to describe this protocol defined in which UEFI spec version. 2. Remove unnecessary include header files. I don't see this protocol depends the definitions from them. Uefi.h is not required. It is always included by module. #include <IndustryStandard/Http11.h> #include <Protocol/Http.h> #include <Protocol/RestEx.h> #include <Uefi.h> 3. EFI_REDFISH_DISCOVER_NETWORK_INSTANCE. UEFI spec defines it as EFI_REDFISH_DISCOVER_NETWORK_INTERFACE. Please correct it. 4. I don't find EFI_REDFISH_DISCOVER_DURATION_BIT_POS in UEFI spec. Please clarify it. 5. typedef needs new type name. If no new type name, typedef should be removed. typedef struct _EFI_REDFISH_DISCOVERED_INFORMATION { ==> struct _EFI_REDFISH_DISCOVERED_INFORMATION EFI_HANDLE RedfishRestExHandle; ///< REST EX EFI handle associated with this Redfish service. BOOLEAN IsUdp6; ///< Indicates it's IP versino 6. EFI_IP_ADDRESS RedfishHostIpAddress; ///< IP address of Redfish service. UINTN RedfishVersion; ///< Redfish service version. CHAR16 *Location; ///< Redfish service location. CHAR16 *Uuid; ///< Redfish service UUID. CHAR16 *Os; ///< Redfish service OS. CHAR16 *OSVersion; ///< Redfish service OS version. CHAR16 *Product; ///< Redfish service product name. CHAR16 *ProductVer; ///< Redfish service product version. BOOLEAN UseHttps; ///< Using HTTPS. }; // there is no type name here. 6. EFI_REDFISH_DISCOVER_PROTOCOL has been defined previously. Don't need typedef again. typedef struct _EFI_REDFISH_DISCOVER_PROTOCOL { EFI_REDFISH_DISCOVER_NETWORK_LIST GetNetworkInterfaceList; EFI_REDFISH_DISCOVER_ACQUIRE_SERVICE AcquireRedfishService; EFI_REDFISH_DISCOVER_ABORT_ACQUIRE AbortAcquireRedfishService; EFI_REDFISH_DISCOVER_RELEASE_SERVICE ReleaseRedfishService; } EFI_REDFISH_DISCOVER_PROTOCOL; 7. Remove below two extern ProtocolGuid. They are not defined in this header file. extern EFI_GUID gEfiRestExProtocolGuid; extern EFI_GUID gEfiRestExServiceBindingProtocolGuid; Thanks Liming > -----邮件原件----- > 发件人: bounce+27952+66912+4905953+8761045@groups.io > <bounce+27952+66912+4905953+8761045@groups.io> 代表 Abner Chang > 发送时间: 2020年11月3日 12:49 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Nickle > Wang <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com> > 主题: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish > Discover protocol > > Move GUID definition of EFI Redfish Discover protocol > to under MdePkg. With this we don't have dependency of > RedfishPkg in ShellPkg. > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Nickle Wang <nickle.wang@hpe.com> > Cc: Peter O'Hanley <peter.ohanley@hpe.com> > --- > {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h | 0 > MdePkg/MdePkg.dec | 3 > +++ > RedfishPkg/RedfishPkg.dec | 4 ---- > 3 files changed, 3 insertions(+), 4 deletions(-) > rename {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h (100%) > > diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h > b/MdePkg/Include/Protocol/RedfishDiscover.h > similarity index 100% > rename from RedfishPkg/Include/Protocol/RedfishDiscover.h > rename to MdePkg/Include/Protocol/RedfishDiscover.h > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 645f61b80e..839bcfe063 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -1858,6 +1858,9 @@ > ## Include/Protocol/RestJsonStructure.h > gEfiRestJsonStructureProtocolGuid = { 0xa9a048f6, 0x48a0, 0x4714, > {0xb7, 0xda, 0xa9, 0xad,0x87, 0xd4, 0xda, 0xc9 }} > > + ## Include/Protocol/RedfishDiscover.h > + gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, > { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} > + > # > # Protocols defined in Shell2.0 > # > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index f12f83526c..65e21f6bd6 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -21,10 +21,6 @@ > # Platform implementation-specific Redfish Host Interface. > > RedfishPlatformHostInterfaceLib|Include/Library/RedfishHostInterfaceLib.h > > -[Protocols] > - ## Include/Protocol/RedfishDiscover.h > - gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, > { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} > - > [Guids] > gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, > { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} > > -- > 2.17.1 > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol 2020-11-05 1:23 ` 回复: [edk2-devel] " gaoliming @ 2020-11-06 8:33 ` Abner Chang 2020-11-06 8:36 ` Abner Chang 1 sibling, 0 replies; 6+ messages in thread From: Abner Chang @ 2020-11-06 8:33 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io Cc: 'Michael D Kinney', 'Zhiguang Liu', Wang, Nickle (HPS SW), O'Hanley, Peter (EXL) > -----Original Message----- > From: gaoliming [mailto:gaoliming@byosoft.com.cn] > Sent: Thursday, November 5, 2020 9:24 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > <abner.chang@hpe.com> > Cc: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' > <zhiguang.liu@intel.com>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; > O'Hanley, Peter (EXL) <peter.ohanley@hpe.com> > Subject: 回复: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI > Redfish Discover protocol > > Abner: > I have some comments in MdePkg/Include/Protocol/RedfishDiscover.h > > 1. Please update file header to describe this protocol defined in which UEFI > spec version. Done > 2. Remove unnecessary include header files. I don't see this protocol > depends the definitions from them. Uefi.h is not required. It is always > included by module. > #include <IndustryStandard/Http11.h> > #include <Protocol/Http.h> > #include <Protocol/RestEx.h> > #include <Uefi.h> Done > 3. EFI_REDFISH_DISCOVER_NETWORK_INSTANCE. UEFI spec defines it as > EFI_REDFISH_DISCOVER_NETWORK_INTERFACE. Please correct it. Done, I also found there are some typos in UEFI spec. I will send ECR to correct it. For example, EFI_REDFISH_DISCOVER_TARGET_NIC_INTERFACE should be EFI_REDFISH_DISCOVER_NETWORK_INTERFACE. > 4. I don't find EFI_REDFISH_DISCOVER_DURATION_BIT_POS in UEFI spec. > Please clarify it. Yes, this is not used anymore. Removed. > 5. typedef needs new type name. If no new type name, typedef should be > removed. Done > typedef struct _EFI_REDFISH_DISCOVERED_INFORMATION { ==> struct I removed previous typedef struct _EFI_REDFISH_DISCOVERED_INFORMATION EFI_REDFISH_DISCOVERED_INFORMATION > _EFI_REDFISH_DISCOVERED_INFORMATION > EFI_HANDLE RedfishRestExHandle; ///< REST EX EFI handle > associated with this Redfish service. > BOOLEAN IsUdp6; ///< Indicates it's IP versino > 6. > EFI_IP_ADDRESS RedfishHostIpAddress; ///< IP address of Redfish > service. > UINTN RedfishVersion; ///< Redfish service version. > CHAR16 *Location; ///< Redfish service location. > CHAR16 *Uuid; ///< Redfish service UUID. > CHAR16 *Os; ///< Redfish service OS. > CHAR16 *OSVersion; ///< Redfish service OS version. > CHAR16 *Product; ///< Redfish service product > name. > CHAR16 *ProductVer; ///< Redfish service product > version. > BOOLEAN UseHttps; ///< Using HTTPS. > }; // there is no type name here. > 6. EFI_REDFISH_DISCOVER_PROTOCOL has been defined previously. Don't > need typedef again. Done > typedef struct _EFI_REDFISH_DISCOVER_PROTOCOL { > EFI_REDFISH_DISCOVER_NETWORK_LIST GetNetworkInterfaceList; > EFI_REDFISH_DISCOVER_ACQUIRE_SERVICE AcquireRedfishService; > EFI_REDFISH_DISCOVER_ABORT_ACQUIRE AbortAcquireRedfishService; > EFI_REDFISH_DISCOVER_RELEASE_SERVICE ReleaseRedfishService; } > EFI_REDFISH_DISCOVER_PROTOCOL; 7. Remove below two extern > ProtocolGuid. They are not defined in this header file. > > extern EFI_GUID gEfiRestExProtocolGuid; > extern EFI_GUID gEfiRestExServiceBindingProtocolGuid; These two are used to listen for the required protocol for Redfish discovery in EfiRedfishDiscoverDxe Driver. > > Thanks > Liming > > -----邮件原件----- > > 发件人: bounce+27952+66912+4905953+8761045@groups.io > > <bounce+27952+66912+4905953+8761045@groups.io> 代表 Abner Chang > > 发送时间: 2020年11月3日 12:49 > > 收件人: devel@edk2.groups.io > > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; > > Nickle Wang <nickle.wang@hpe.com>; Peter O'Hanley > > <peter.ohanley@hpe.com> > > 主题: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish > > Discover protocol > > > > Move GUID definition of EFI Redfish Discover protocol to under MdePkg. > > With this we don't have dependency of RedfishPkg in ShellPkg. > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > > Cc: Nickle Wang <nickle.wang@hpe.com> > > Cc: Peter O'Hanley <peter.ohanley@hpe.com> > > --- > > {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h | 0 > > MdePkg/MdePkg.dec | 3 > > +++ > > RedfishPkg/RedfishPkg.dec | 4 ---- > > 3 files changed, 3 insertions(+), 4 deletions(-) rename {RedfishPkg > > => MdePkg}/Include/Protocol/RedfishDiscover.h (100%) > > > > diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h > > b/MdePkg/Include/Protocol/RedfishDiscover.h > > similarity index 100% > > rename from RedfishPkg/Include/Protocol/RedfishDiscover.h > > rename to MdePkg/Include/Protocol/RedfishDiscover.h > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 645f61b80e..839bcfe063 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -1858,6 +1858,9 @@ > > ## Include/Protocol/RestJsonStructure.h > > gEfiRestJsonStructureProtocolGuid = { 0xa9a048f6, 0x48a0, 0x4714, > > {0xb7, 0xda, 0xa9, 0xad,0x87, 0xd4, 0xda, 0xc9 }} > > > > + ## Include/Protocol/RedfishDiscover.h > > + gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, > > { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} > > + > > # > > # Protocols defined in Shell2.0 > > # > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > > index f12f83526c..65e21f6bd6 100644 > > --- a/RedfishPkg/RedfishPkg.dec > > +++ b/RedfishPkg/RedfishPkg.dec > > @@ -21,10 +21,6 @@ > > # Platform implementation-specific Redfish Host Interface. > > > > RedfishPlatformHostInterfaceLib|Include/Library/RedfishHostInterfaceLi > > RedfishPlatformHostInterfaceLib|b.h > > > > -[Protocols] > > - ## Include/Protocol/RedfishDiscover.h > > - gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, > > { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} > > - > > [Guids] > > gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, > > { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} > > > > -- > > 2.17.1 > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol 2020-11-05 1:23 ` 回复: [edk2-devel] " gaoliming 2020-11-06 8:33 ` Abner Chang @ 2020-11-06 8:36 ` Abner Chang 1 sibling, 0 replies; 6+ messages in thread From: Abner Chang @ 2020-11-06 8:36 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io Cc: 'Michael D Kinney', 'Zhiguang Liu', Wang, Nickle (HPS SW), O'Hanley, Peter (EXL) Liming, v2 patch sent. Thanks > -----Original Message----- > From: gaoliming [mailto:gaoliming@byosoft.com.cn] > Sent: Thursday, November 5, 2020 9:24 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > <abner.chang@hpe.com> > Cc: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' > <zhiguang.liu@intel.com>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; > O'Hanley, Peter (EXL) <peter.ohanley@hpe.com> > Subject: 回复: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI > Redfish Discover protocol > > Abner: > I have some comments in MdePkg/Include/Protocol/RedfishDiscover.h > > 1. Please update file header to describe this protocol defined in which UEFI > spec version. > 2. Remove unnecessary include header files. I don't see this protocol > depends the definitions from them. Uefi.h is not required. It is always > included by module. > #include <IndustryStandard/Http11.h> > #include <Protocol/Http.h> > #include <Protocol/RestEx.h> > #include <Uefi.h> > 3. EFI_REDFISH_DISCOVER_NETWORK_INSTANCE. UEFI spec defines it as > EFI_REDFISH_DISCOVER_NETWORK_INTERFACE. Please correct it. > 4. I don't find EFI_REDFISH_DISCOVER_DURATION_BIT_POS in UEFI spec. > Please clarify it. > 5. typedef needs new type name. If no new type name, typedef should be > removed. > typedef struct _EFI_REDFISH_DISCOVERED_INFORMATION { ==> struct > _EFI_REDFISH_DISCOVERED_INFORMATION > EFI_HANDLE RedfishRestExHandle; ///< REST EX EFI handle > associated with this Redfish service. > BOOLEAN IsUdp6; ///< Indicates it's IP versino > 6. > EFI_IP_ADDRESS RedfishHostIpAddress; ///< IP address of Redfish > service. > UINTN RedfishVersion; ///< Redfish service version. > CHAR16 *Location; ///< Redfish service location. > CHAR16 *Uuid; ///< Redfish service UUID. > CHAR16 *Os; ///< Redfish service OS. > CHAR16 *OSVersion; ///< Redfish service OS version. > CHAR16 *Product; ///< Redfish service product > name. > CHAR16 *ProductVer; ///< Redfish service product > version. > BOOLEAN UseHttps; ///< Using HTTPS. > }; // there is no type name here. > 6. EFI_REDFISH_DISCOVER_PROTOCOL has been defined previously. Don't > need typedef again. > typedef struct _EFI_REDFISH_DISCOVER_PROTOCOL { > EFI_REDFISH_DISCOVER_NETWORK_LIST GetNetworkInterfaceList; > EFI_REDFISH_DISCOVER_ACQUIRE_SERVICE AcquireRedfishService; > EFI_REDFISH_DISCOVER_ABORT_ACQUIRE AbortAcquireRedfishService; > EFI_REDFISH_DISCOVER_RELEASE_SERVICE ReleaseRedfishService; } > EFI_REDFISH_DISCOVER_PROTOCOL; 7. Remove below two extern > ProtocolGuid. They are not defined in this header file. > > extern EFI_GUID gEfiRestExProtocolGuid; > extern EFI_GUID gEfiRestExServiceBindingProtocolGuid; > > Thanks > Liming > > -----邮件原件----- > > 发件人: bounce+27952+66912+4905953+8761045@groups.io > > <bounce+27952+66912+4905953+8761045@groups.io> 代表 Abner Chang > > 发送时间: 2020年11月3日 12:49 > > 收件人: devel@edk2.groups.io > > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; > > Nickle Wang <nickle.wang@hpe.com>; Peter O'Hanley > > <peter.ohanley@hpe.com> > > 主题: [edk2-devel] [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish > > Discover protocol > > > > Move GUID definition of EFI Redfish Discover protocol to under MdePkg. > > With this we don't have dependency of RedfishPkg in ShellPkg. > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > > Cc: Nickle Wang <nickle.wang@hpe.com> > > Cc: Peter O'Hanley <peter.ohanley@hpe.com> > > --- > > {RedfishPkg => MdePkg}/Include/Protocol/RedfishDiscover.h | 0 > > MdePkg/MdePkg.dec | 3 > > +++ > > RedfishPkg/RedfishPkg.dec | 4 ---- > > 3 files changed, 3 insertions(+), 4 deletions(-) rename {RedfishPkg > > => MdePkg}/Include/Protocol/RedfishDiscover.h (100%) > > > > diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h > > b/MdePkg/Include/Protocol/RedfishDiscover.h > > similarity index 100% > > rename from RedfishPkg/Include/Protocol/RedfishDiscover.h > > rename to MdePkg/Include/Protocol/RedfishDiscover.h > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 645f61b80e..839bcfe063 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -1858,6 +1858,9 @@ > > ## Include/Protocol/RestJsonStructure.h > > gEfiRestJsonStructureProtocolGuid = { 0xa9a048f6, 0x48a0, 0x4714, > > {0xb7, 0xda, 0xa9, 0xad,0x87, 0xd4, 0xda, 0xc9 }} > > > > + ## Include/Protocol/RedfishDiscover.h > > + gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, > > { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} > > + > > # > > # Protocols defined in Shell2.0 > > # > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > > index f12f83526c..65e21f6bd6 100644 > > --- a/RedfishPkg/RedfishPkg.dec > > +++ b/RedfishPkg/RedfishPkg.dec > > @@ -21,10 +21,6 @@ > > # Platform implementation-specific Redfish Host Interface. > > > > RedfishPlatformHostInterfaceLib|Include/Library/RedfishHostInterfaceLi > > RedfishPlatformHostInterfaceLib|b.h > > > > -[Protocols] > > - ## Include/Protocol/RedfishDiscover.h > > - gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, > > { 0x96, 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }} > > - > > [Guids] > > gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, > > { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} > > > > -- > > 2.17.1 > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [EFI Shell PATCH 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols 2020-11-03 4:49 [EFI Shell PATCH 0/2] Support EFI Redfish protocols Abner Chang 2020-11-03 4:49 ` [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol Abner Chang @ 2020-11-03 4:49 ` Abner Chang 1 sibling, 0 replies; 6+ messages in thread From: Abner Chang @ 2020-11-03 4:49 UTC (permalink / raw) To: devel; +Cc: Ray Ni, Zhichao Gao, Nickle Wang, Peter O'Hanley Add handle parsing for EFI Redfish Discover protocol. Add handle parsing for EFI RestEx protocol. Signed-off-by: Abner Chang <abner.chang@hpe.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Nickle Wang <nickle.wang@hpe.com> Cc: Peter O'Hanley <peter.ohanley@hpe.com> --- .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 ++++++-- .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++- .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c index 500a95a89a..c00337d6b2 100644 --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c @@ -3,7 +3,7 @@ Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR> (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR> + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -2355,7 +2355,11 @@ STATIC CONST GUID_INFO_BLOCK mGuidStringList[] = { {STRING_TOKEN(STR_NET_HTTP), &gEfiHttpProtocolGuid, NULL}, {STRING_TOKEN(STR_NET_HTTP_U), &gEfiHttpUtilitiesProtocolGuid, NULL}, {STRING_TOKEN(STR_REST), &gEfiRestProtocolGuid, NULL}, - +// +// UEFI 2.8 +// + {STRING_TOKEN(STR_REST_EX), &gEfiRestExProtocolGuid, NULL}, + {STRING_TOKEN(STR_REDFISH_DISCOVER), &gEfiRedfishDiscoverProtocolGuid, NULL}, // // PI 1.5 // diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf index 93b69cd8e9..446cd8d609 100644 --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf @@ -2,7 +2,7 @@ # Provides interface to advanced shell functionality for parsing both handle and protocol database. # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR> # (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> -# (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -269,6 +269,8 @@ gEfiHttpProtocolGuid ## UNDEFINED gEfiHttpUtilitiesProtocolGuid ## UNDEFINED gEfiRestProtocolGuid ## UNDEFINED + gEfiRestExProtocolGuid ## UNDEFINED + gEfiRedfishDiscoverProtocolGuid ## UNDEFINED gEfiMmEndOfDxeProtocolGuid ## UNDEFINED gEfiMmIoTrapDispatchProtocolGuid ## UNDEFINED gEfiMmPowerButtonDispatchProtocolGuid ## UNDEFINED diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni index 9c8028d0d5..69fcbdfe0e 100644 --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni @@ -2,7 +2,7 @@ // // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR> // (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> -// (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR> +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR> // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: @@ -308,6 +308,8 @@ #string STR_NET_HTTP #language en-US "Http" #string STR_NET_HTTP_U #language en-US "HttpUtilities" #string STR_REST #language en-US "Rest" +#string STR_REST_EX #language en-US "RestEx" +#string STR_REDFISH_DISCOVER #language en-US "RedfishDiscover" #string STR_MM_EOD #language en-US "MmEndOfDxe" #string STR_MM_ITD #language en-US "MmIoTrapDispatch" -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-06 8:37 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-03 4:49 [EFI Shell PATCH 0/2] Support EFI Redfish protocols Abner Chang 2020-11-03 4:49 ` [EFI Shell PATCH 1/2] MdePkg/Include: EFI Redfish Discover protocol Abner Chang 2020-11-05 1:23 ` 回复: [edk2-devel] " gaoliming 2020-11-06 8:33 ` Abner Chang 2020-11-06 8:36 ` Abner Chang 2020-11-03 4:49 ` [EFI Shell PATCH 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Abner Chang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox