public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <gechao@greatwall.com.cn>, <devel@edk2.groups.io>
Cc: <dandan.bi@intel.com>, <eric.dong@intel.com>
Subject: 回复: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name.
Date: Thu, 12 Nov 2020 09:39:37 +0800	[thread overview]
Message-ID: <001801d6b894$aec73610$0c55a230$@byosoft.com.cn> (raw)
In-Reply-To: <811d2cd2539810b03d21fba07736e1e9a902c916.1605144299.git.GevinGe@hotmail.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: gechao@greatwall.com.cn <gechao@greatwall.com.cn>
> 发送时间: 2020年11月12日 9:34
> 收件人: devel@edk2.groups.io
> 抄送: dandan.bi@intel.com; eric.dong@intel.com;
> gaoliming@byosoft.com.cn; gechao <gechao@greatwall.com.cn>
> 主题: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable
> name.
> 
> From: gechao <gechao@greatwall.com.cn>
> 
> Signed-off-by: gechao <gechao@greatwall.com.cn>
> ---
>  .../Universal/DisplayEngineDxe/FormDisplay.c     | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> index 3b034a1c82..a3898dc2ec 100644
> --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> @@ -372,7 +372,7 @@ GetWidth (
>  {
> 
>    CHAR16                        *String;
> 
>    UINTN                         Size;
> 
> -  EFI_IFR_TEXT                  *TestOp;
> 
> +  EFI_IFR_TEXT                  *TextOp;
> 
>    UINT16                        ReturnWidth;
> 
>    FORM_DISPLAY_ENGINE_STATEMENT *Statement;
> 
> 
> 
> @@ -394,9 +394,9 @@ GetWidth (
>    // See if the second text parameter is really NULL
> 
>    //
> 
>    if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> 
> -    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> -    if (TestOp->TextTwo != 0) {
> 
> -      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> 
> +    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> +    if (TextOp->TextTwo != 0) {
> 
> +      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> 
>        Size   = StrLen (String);
> 
>        FreePool (String);
> 
>      }
> 
> @@ -2166,7 +2166,7 @@ HasOptionString (
>    FORM_DISPLAY_ENGINE_STATEMENT   *Statement;
> 
>    CHAR16                          *String;
> 
>    UINTN                           Size;
> 
> -  EFI_IFR_TEXT                    *TestOp;
> 
> +  EFI_IFR_TEXT                    *TextOp;
> 
> 
> 
>    Size = 0;
> 
>    Statement = MenuOption->ThisTag;
> 
> @@ -2175,9 +2175,9 @@ HasOptionString (
>    // See if the second text parameter is really NULL
> 
>    //
> 
>    if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> 
> -    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> -    if (TestOp->TextTwo != 0) {
> 
> -      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> 
> +    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> +    if (TextOp->TextTwo != 0) {
> 
> +      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> 
>        Size   = StrLen (String);
> 
>        FreePool (String);
> 
>      }
> 
> --
> 2.28.0.windows.1




  reply	other threads:[~2020-11-12  1:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12  1:33 [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local variable name gechao
2020-11-12  1:39 ` gaoliming [this message]
     [not found] ` <16469F0A5D9CED83.27022@groups.io>
2020-11-12 14:29   ` 回复: [edk2-devel] 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001801d6b894$aec73610$0c55a230$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox