From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web08.2084.1668399336483147053 for ; Sun, 13 Nov 2022 20:15:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=CU8cLrc6; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6E8C5CD1F683 for ; Mon, 14 Nov 2022 12:15:31 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1668399331; bh=qkVGc8l/WEYHmhWsTjOyPDPrKzXa1t3VjcnMct2SKkY=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=CU8cLrc6arznk/yiIsCmdcTboYNSQJpTuK835CQ+VCUUxLU+e45gujvHJkP04o44x qhJluFAsKcIRkEnzpnXAf+KxiEtHe6UL/fMYced+aGUsgDFLhEt/jW1zcllI9o6qgW mgzRstbHfmwJ9WB+uMLronbL7xTGUOwF7GfvFIDA= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6AAEDCD1F6D0 for ; Mon, 14 Nov 2022 12:15:31 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 39A3FCD1F6C8 for ; Mon, 14 Nov 2022 12:15:31 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id B8D6ACD1F6A6 for ; Mon, 14 Nov 2022 12:15:27 +0800 (CST) Received: from DESKTOPS6D0PVI ([101.86.144.134]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 14 Nov 2022 12:15:23 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.86.144.134 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Xu, Min M'" Cc: "'Dong, Eric'" , "'Ni, Ray'" , "'Brijesh Singh'" , "'Aktas, Erdem'" , "'Gerd Hoffmann'" , "'James Bottomley'" , "'Tom Lendacky'" , "'Dong, Guo'" , "'Rhodes, Sean'" , "'Lu, James'" , "'Guo, Gua'" , "'Kinney, Michael D'" References: <20221111071710.1596-1-min.m.xu@intel.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItc3RhYmxlMjAyMjExXSBbUEFUQ0ggVjYgMC8zXSBSZW5hbWUgVm1nRXhpdExpYiB0byBDY0V4aXRMaWI=?= Date: Mon, 14 Nov 2022 12:15:23 +0800 Message-ID: <001801d8f7df$b7d84000$2788c000$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGC1LGsbVfgP7k6M2IOU8hpJcVReAHkjf9frtrxMgA= Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Jiewen: This patch set has passed code review before soft feature freeze phase. And, there is no code change recently. So, I agree to merge this patch set for the stable tag.=20 I will help merge it.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Yao, Jiewen > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA11=D4=C212=C8=D5 10:50 > =CA=D5=BC=FE=C8=CB: Xu, Min M ; devel@edk2.groups.io > =B3=AD=CB=CD: Dong, Eric ; Ni, Ray ; Brijesh > Singh ; Aktas, Erdem ; > Gerd Hoffmann ; James Bottomley > ; Tom Lendacky ; Dong, > Guo ; Rhodes, Sean ; Lu, > James ; Guo, Gua ; Kinney, > Michael D ; Gao, Liming > > =D6=F7=CC=E2: [edk2-devel] [edk2-stable202211] [PATCH V6 0/3] Rename VmgE= xitLib > to CcExitLib >=20 > Reviewed by: Jiewen Yao >=20 > Hi Mike/Liming > I suggest this be in edk2-stable202211. >=20 > Thank you > Yao, Jiewen >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Friday, November 11, 2022 3:17 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Dong, Eric ; > > Ni, Ray ; Brijesh Singh ; Aktas, > > Erdem ; Gerd Hoffmann ; > > James Bottomley ; Yao, Jiewen > > ; Tom Lendacky ; > > Dong, Guo ; Rhodes, Sean ; > > Lu, James ; Guo, Gua ; Kinney, > > Michael D ; Gao, Liming > > > > Subject: [PATCH V6 0/3] Rename VmgExitLib to CcExitLib > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4123 > > > > VmgExitLib once was designed to provide interfaces to support #VC handler > > and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is > > introduced, this library is updated to support #VE as well. Now the nam= e > > of VmgExitLib cannot reflect what the lib does. > > > > This patch-set renames VmgExitLib to CcExitLib (Cc means Confidential > > Computing). This is simple renaming and there is no logic changes. Then > > APIs defined in CcExitLib.h are added with a CcExit prefix. This is to > > make the name more meaningful. > > > > Please to be noted, changing the name of VmgExitLib to CcExitLib is a > > non-backwards compatible change from a platform DSC file perspective fo= r > > downstream consumers. So for downstream platform below changes > > should > > be applied: > > 1. For DSC files: > > - VmgExitLib|OvmfPkg/Library/VmgExitLib/SecVmgExitLib.inf =3D> > > CcExitLib|OvmfPkg/Library/CcExitLib/SecCcExitLib.inf > > > > - VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf =3D> > > CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf > > > > - VmgExitLib|OvmfPkg/Library/VmgExitLib/VmgExitLib.inf =3D> > > CcExitLib|OvmfPkg/Library/CcExitLib/CcExitLib.inf > > > > 2. For INF files: > > - VmgExitLib =3D> CcExitLib > > > > 3. For Header files > > - #include =3D> #include > > > > 4. For C files > > - Replace the APIs defined in the VmgExitLib.h with the ones defined in > > CcExitLib.h. The old name is renamed by adding a prefix (CcExit). > > For example VmgInit is renamed as CcExitVmgInit. > > > > Code: https://github.com/mxu9/edk2/tree/CcExitLib.v5 > > > > v6 changes: > > - Fix a typo in patch0@v5. > > - No other changes from v5. So the code is same as v5. > > > > v5 changes: > > - Rebased the code base to c17c3c24d8. > > - Add instructions in patch#0 on what updates to a downstream > > platform DSC. > > > > v4 changes: > > - The previous versions of the patch-set are to first duplicate a new > > CcExitLib then delete the old VmgExitLib. According to this comments > > https://edk2.groups.io/g/devel/message/96019 it suggests renaming in > > a single patch is better. > > - Lib APIs are added with CcExit prefix, not CcExitLib prefix. > > > > v3 changes: > > - Rename CcExitHandleVc / CcExitHandleVe to > > CcExitLibHandleVc / CcExitLibHandleVe to make the nameing > consistent. > > - Update the CcExitLib to merge the patch eff44c008d99 > > (OvmfPkg/VmgExitLig: HALT on #VE when access to private memory). > > > > v2 changes: > > - Patch #3 is added to import CcExitLib in OvmfPkg's *.dsc. This is to > > prevent the building from being broken in the following patches. > > > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Brijesh Singh > > Cc: Erdem Aktas > > Cc: Gerd Hoffmann > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Guo Dong > > Cc: Sean Rhodes > > Cc: James Lu > > Cc: Gua Guo > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: Min Xu > > > > Min M Xu (3): > > OvmfPkg/UefiCpuPkg/UefiPayloadPkg: Rename VmgExitLib to CcExitLib > > OvmfPkg/UefiCpuPkg: Add CcExit prefix to the APIs of CcExitLib > > Maintainers: Update the VmgExitLib to CcExitLib > > > > Maintainers.txt | 2 +- > > OvmfPkg/AmdSev/AmdSevX64.dsc | 4 +- > > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > > OvmfPkg/CloudHv/CloudHvX64.dsc | 6 +- > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 +- > > .../DxeMemEncryptSevLib.inf | 2 +- > > .../PeiMemEncryptSevLib.inf | 2 +- > > .../SecMemEncryptSevLib.inf | 2 +- > > .../X64/SnpPageStateChangeInternal.c | 10 +- > > .../VmgExitLib.c =3D> CcExitLib/CcExitLib.c} | 23 ++-- > > .../CcExitLib.inf} | 17 +-- > > .../CcExitTd.h} | 4 +- > > .../CcExitVcHandler.c} | 129 > +++++++++--------- > > .../CcExitVcHandler.h} | 6 +- > > .../CcExitVeHandler.c} | 6 +- > > .../PeiDxeCcExitVcHandler.c} | 6 +- > > .../SecCcExitLib.inf} | 14 +- > > .../SecCcExitVcHandler.c} | 6 +- > > .../X64/TdVmcallCpuid.nasm | 0 > > OvmfPkg/Microvm/MicrovmX64.dsc | 4 +- > > OvmfPkg/OvmfPkgIa32.dsc | 4 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +- > > OvmfPkg/OvmfPkgX64.dsc | 6 +- > > OvmfPkg/OvmfXen.dsc | 2 +- > > OvmfPkg/PlatformPei/AmdSev.c | 10 +- > > OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- > > .../FvbServicesRuntimeDxe.inf | 2 +- > > .../QemuFlashDxe.c | 10 +- > > .../Library/{VmgExitLib.h =3D> CcExitLib.h} | 29 ++-- > > .../CcExitLibNull.c} | 47 +++++-- > > .../CcExitLibNull.inf} | 12 +- > > .../Library/CcExitLibNull/CcExitLibNull.uni | 14 ++ > > .../DxeCpuExceptionHandlerLib.inf | 2 +- > > .../PeiCpuExceptionHandlerLib.inf | 2 +- > > .../PeiDxeSmmCpuException.c | 6 +- > > .../SecPeiCpuException.c | 6 +- > > .../SecPeiCpuExceptionHandlerLib.inf | 2 +- > > .../SmmCpuExceptionHandlerLib.inf | 2 +- > > .../Xcode5SecPeiCpuExceptionHandlerLib.inf | 2 +- > > UefiCpuPkg/Library/MpInitLib/AmdSev.c | 10 +- > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 2 +- > > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 8 +- > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 2 +- > > UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 10 +- > > .../Library/VmgExitLibNull/VmTdExitNull.c | 38 ------ > > .../Library/VmgExitLibNull/VmgExitLibNull.uni | 15 -- > > UefiCpuPkg/UefiCpuPkg.dec | 4 +- > > UefiCpuPkg/UefiCpuPkg.dsc | 4 +- > > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- > > 50 files changed, 252 insertions(+), 258 deletions(-) > > rename OvmfPkg/Library/{VmgExitLib/VmgExitLib.c =3D> > CcExitLib/CcExitLib.c} > > (89%) > > rename OvmfPkg/Library/{VmgExitLib/VmgExitLib.inf =3D> > > CcExitLib/CcExitLib.inf} (66%) > > rename OvmfPkg/Library/{VmgExitLib/VmTdExitHandler.h =3D> > > CcExitLib/CcExitTd.h} (86%) > > rename OvmfPkg/Library/{VmgExitLib/VmgExitVcHandler.c =3D> > > CcExitLib/CcExitVcHandler.c} (90%) > > rename OvmfPkg/Library/{VmgExitLib/VmgExitVcHandler.h =3D> > > CcExitLib/CcExitVcHandler.h} (89%) > > rename OvmfPkg/Library/{VmgExitLib/VmTdExitVeHandler.c =3D> > > CcExitLib/CcExitVeHandler.c} (95%) > > rename OvmfPkg/Library/{VmgExitLib/PeiDxeVmgExitVcHandler.c =3D> > > CcExitLib/PeiDxeCcExitVcHandler.c} (93%) > > rename OvmfPkg/Library/{VmgExitLib/SecVmgExitLib.inf =3D> > > CcExitLib/SecCcExitLib.inf} (79%) > > rename OvmfPkg/Library/{VmgExitLib/SecVmgExitVcHandler.c =3D> > > CcExitLib/SecCcExitVcHandler.c} (93%) > > rename OvmfPkg/Library/{VmgExitLib =3D> > > CcExitLib}/X64/TdVmcallCpuid.nasm (100%) > > rename UefiCpuPkg/Include/Library/{VmgExitLib.h =3D> CcExitLib.h} (87%= ) > > rename UefiCpuPkg/Library/{VmgExitLibNull/VmgExitLibNull.c =3D> > > CcExitLibNull/CcExitLibNull.c} (76%) > > rename UefiCpuPkg/Library/{VmgExitLibNull/VmgExitLibNull.inf =3D> > > CcExitLibNull/CcExitLibNull.inf} (60%) > > create mode 100644 UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.uni > > delete mode 100644 UefiCpuPkg/Library/VmgExitLibNull/VmTdExitNull.c > > delete mode 100644 > > UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.uni > > > > -- > > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20