From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.16890.1605145715184975546 for ; Wed, 11 Nov 2020 17:48:36 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 12 Nov 2020 09:48:31 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Eric Dong'" , "'Chasel Chiu'" , "'Nate DeSimone'" References: <20201111061608.5303-1-heng.luo@intel.com> In-Reply-To: <20201111061608.5303-1-heng.luo@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIFY1IDEvM10gTWluUGxhdGZvcm1Qa2c6IEFkZCBQQ0RzIGZvciBTZXJpYWwgVGVybWluYWwgZmVhdHVyZQ==?= Date: Thu, 12 Nov 2020 09:48:33 +0800 Message-ID: <001901d6b895$ee085650$ca1902f0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHh2W7ZiDCblfc90EFTBDpMtNcsPamteCnA Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Heng: I see MdeModulePkg SerialDxe uses MdePkg UART PCDs. New added SerialPortTerminalLib should match it and use the same PCD. Right? If = yes, you don't need to add new UART PCDs. =20 gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate ## CONSUMES gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits ## CONSUMES gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity ## CONSUMES gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits ## CONSUMES Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+67278+4905953+8761045@groups.io > =B4=FA=B1=ED Heng Luo > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C211=C8=D5 14:16 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Eric Dong ; Chasel Chiu > ; Nate DeSimone = ; > Liming Gao > =D6=F7=CC=E2: [edk2-devel] [Patch V5 1/3] MinPlatformPkg: Add PCDs for = Serial > Terminal feature >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3014 >=20 > 1. Add PcdSerialTerminalEnable to enable/disable Serial Terminal = feature, > this feature supports console redirect after the shell is loaded. > 2. Add PCDs to configure serial port. >=20 > Cc: Eric Dong > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Heng Luo > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 25 > +++++++++++++++++++++++++ > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++- > 2 files changed, 27 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 7ef189dac8..36050aa1a8 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -205,6 +205,30 @@ > [PcdsDynamic, PcdsDynamicEx] >=20 >=20 > gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0|UINT32|0x900000 > 19 >=20 >=20 >=20 > + # The baud rate setting for the UART style device. A value of 0 >=20 > + # means that the device's default baud rate will be used. >=20 > + > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalBaudRate|115200|UINT6 > 4|0x9000001A >=20 > + >=20 > + # The number of data bits for the UART style device. A value >=20 > + # of 0 means that the device's default number of data bits will be used. >=20 > + > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalDataBits|0x8|UINT8|0x9 > 000001B >=20 > + >=20 > + # The parity setting for the UART style device. >=20 > + # Parity 0x00 - Default Parity. >=20 > + # Parity 0x01 - No Parity. >=20 > + # Parity 0x02 - Even Parity. >=20 > + # Parity 0x03 - Odd Parity. >=20 > + # Parity 0x04 - Mark Parity. >=20 > + # Parity 0x05 - Space Parity. >=20 > + > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalParity|0x1|UINT8|0x900 > 0001C >=20 > + >=20 > + # The number of stop bits for the UART style device. >=20 > + # Stop Bits 0x00 - Default Stop Bits. >=20 > + # Stop Bits 0x01 - 1 Stop Bit. >=20 > + # Stop Bits 0x02 - 1.5 Stop Bits. >=20 > + # Stop Bits 0x03 - 2 Stop Bits. >=20 > + > gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalStopBits|0x1|UINT8|0x9 > 000001D >=20 > + >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >=20 >=20 >=20 > ## >=20 > @@ -318,3 +342,4 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable > |FALSE|BOOLEAN|0xF00000A5 >=20 >=20 > gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE|BOOLE > AN|0xF00000A6 >=20 > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE|BOOLEAN|0xF00000A7 >=20 > + gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable > |FALSE|BOOLEAN|0xF00000B0 >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 112ddff7d9..d0b5593817 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -1,7 +1,7 @@ > ## @file >=20 > # Platform description. >=20 > # >=20 > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights = reserved.
>=20 > +# Copyright (c) 2017 - 2020, Intel Corporation. All rights = reserved.
>=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -44,6 +44,7 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE >=20 > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE >=20 > gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE >=20 > + gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE >=20 >=20 >=20 >=20 > ############################################################## > ################## >=20 > # >=20 > -- > 2.24.0.windows.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#67278): = https://edk2.groups.io/g/devel/message/67278 > Mute This Topic: https://groups.io/mt/78177912/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20