回复: [edk2-devel] [PATCH v2 1/2] MdePkg: Definitions for Extended Interrupt Flags

["gaoliming" <gaoliming@byosoft.com.cn>]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: bounce+27952+65628+4905953+8761045@groups.io
> <bounce+27952+65628+4905953+8761045@groups.io> 代表 Sami Mujawar
> 发送时间: 2020年9月25日 21:18
> 收件人: devel@edk2.groups.io
> 抄送: Sami Mujawar <sami.mujawar@arm.com>; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Alexei.Fedorov@arm.com;
> pierre.gondois@arm.com; Matteo.Carlini@arm.com; Ben.Adderson@arm.com;
> nd@arm.com
> 主题: [edk2-devel] [PATCH v2 1/2] MdePkg: Definitions for Extended
Interrupt
> Flags
> 
> Add Interrupt Vector Flag definitions for Extended Interrupt
> Descriptor, and macros to test the flags.
> Ref: ACPI specification 6.4.3.6
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> Notes:
>     v2
>       - Updated based on review comments to just define the bit     [SAMI]
>         locations. Also dropped the IS_xxx macros.
> 
>  MdePkg/Include/IndustryStandard/Acpi10.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
> b/MdePkg/Include/IndustryStandard/Acpi10.h
> index
> adeb5ae8c219f31d2403fc7aa217bfb4e1e44694..7ac9b967b54dcc92f2c20366
> bf1ff08d67c4c971 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi10.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi10.h
> @@ -2,6 +2,7 @@
>    ACPI 1.0b definitions from the ACPI Specification, revision 1.0b
> 
>  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> 
> @@ -377,6 +378,16 @@ typedef struct {
>  #define   EFI_ACPI_MEMORY_NON_WRITABLE                  0x00
> 
>  //
> +// Interrupt Vector Flags definitions for Extended Interrupt Descriptor
> +// Ref ACPI specification 6.4.3.6
> +//
> +#define
> EFI_ACPI_EXTENDED_INTERRUPT_FLAG_PRODUCER_CONSUMER_MASK   BIT0
> +#define EFI_ACPI_EXTENDED_INTERRUPT_FLAG_MODE_MASK
> BIT1
> +#define EFI_ACPI_EXTENDED_INTERRUPT_FLAG_POLARITY_MASK
> BIT2
> +#define EFI_ACPI_EXTENDED_INTERRUPT_FLAG_SHARABLE_MASK
> BIT3
> +#define EFI_ACPI_EXTENDED_INTERRUPT_FLAG_WAKE_CAPABLITY_MASK
> BIT4
> +
> +//
>  // Ensure proper structure formats
>  //
>  #pragma pack(1)
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 
>