回复: [edk2-devel] [RFC] UnitTestFrameworkPkg cmocka submodule alternatives

["gaoliming" <gaoliming@byosoft.com.cn>]

Mike:
  I review all submodules in edk2. They are all from github except for cmocka. So, I agree to use github mirror for cmocka. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+69010+4905953+8761045@groups.io
> <bounce+27952+69010+4905953+8761045@groups.io> 代表 Michael D
> Kinney
> 发送时间: 2020年12月17日 2:46
> 收件人: rfc@edk2.groups.io; devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>
> 主题: [edk2-devel] [RFC] UnitTestFrameworkPkg cmocka submodule
> alternatives
> 
> Hello,
> 
> We have had at least three incidents in the last year where the link to the
> cmocka submodule in the UnitTestFrameworkPkg has not been available, and
> this
> impacted the EDK II CI system.  The following submodule link is the one that
> is not reliable:
> 
> 	https://git.cryptomilk.org/projects/cmocka.git
> 
> We have identified two potential mirrors of this repo:
> 
> 	https://github.com/neverware-mirrors/cmocka.git
> 	https://gitlab.com/cmocka/cmocka.git
> 
> The following patch provided a temporary fix for the EDK II CI agents, but
> does not help other consumers of the edk2 repository.
> 
> 	https://github.com/tianocore/edk2/commit/be746104d1766a8c363e74
> d6063144657820d688
> 
> I have seen one suggestion that TianoCore create its own
> mirror of cmocka.  This does require monitoring and maintenance
> by the  TianoCore community.  I would prefer to use a well
> maintained mirror in github as long as we do not observe any
> issues with the support of that mirror.
> 
> I propose we update the submodule in the UnitTestFrameworkPkg
> to use the https://github.com/neverware-mirrors/cmocka.git mirror.
> By using a mirror in github, we remove one external dependency.
> 
> Please provide feedback and comments on this proposal.  If there
> are no objections, then we will proceed with a patch review for
> this update.
> 
> Thanks,
> 
> Mike
> 
> 
> 
>