From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.6727.1623115154329342862
 for <devel@edk2.groups.io>;
 Mon, 07 Jun 2021 18:19:15 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Tue, 08 Jun 2021 09:19:10 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Laszlo Ersek'" <lersek@redhat.com>,
	<devel@edk2.groups.io>
Cc: "'Ray Ni'" <ray.ni@intel.com>,
	"'Leif Lindholm'" <leif@nuviainc.com>,
	"'Bob Feng'" <bob.c.feng@intel.com>
References: <20210605011854.1938-1-gaoliming@byosoft.com.cn> <29306b7e-eee2-d858-fd9c-0480dfc89cf3@redhat.com>
In-Reply-To: <29306b7e-eee2-d858-fd9c-0480dfc89cf3@redhat.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzIEdlbkZ3OiBGaXggcmVncmVzc2lvbiBpc3N1ZSB0byBjb252ZXJ0IHRoZSBpbWFnZSB0byBBQ1BJIGRhdGE=?=
Date: Tue, 8 Jun 2021 09:19:11 +0800
Message-ID: <001a01d75c04$49d48cd0$dd7da670$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKngEFrtUQmVheN/c7oAFzToAISIQHEcY4NqVrkDYA=
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Laszlo:
  Thanks for your reminder. When I merge this change, I add the =
regression commit info in the commit message.=20
 =20
  This change is merged at ddb3fdbef30de5a2946f9bd51060e8d5b1987aef.

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Laszlo Ersek <lersek@redhat.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: =
2021=E5=B9=B46=E6=9C=887=E6=97=A5 23:19
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; =
gaoliming@byosoft.com.cn
> =E6=8A=84=E9=80=81: Ray Ni <ray.ni@intel.com>; Leif Lindholm =
<leif@nuviainc.com>; Bob
> Feng <bob.c.feng@intel.com>
> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix =
regression issue to
> convert the image to ACPI data
>=20
> On 06/05/21 03:18, gaoliming wrote:
> > With GCC49 tool chain, aslc file is compiled into elf image.
> > But, its text section has no CODE attribute. So, it can't be =
detected
> > by new GenFw tool.For this type file. its text section is not =
required.
> > Its data section will be converted to acpi table.
> >
> > This fix is to remove assert check when the generated image is ACPI =
data.
> >
> > Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > ---
> >  This patch has been verified on GCC49 for AARCH64 platform.
> >
> >  BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +-
> >  BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> If this is a regression, then the commit message should please =
identify
> the commit that introduced the regression. We usually do this with:
>=20
> Fixes: ....
>=20
> Thanks
> Laszlo
>=20
> >
> > diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c
> b/BaseTools/Source/C/GenFw/Elf32Convert.c
> > index 7c8a065678ac..314f8233234d 100644
> > --- a/BaseTools/Source/C/GenFw/Elf32Convert.c
> > +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c
> > @@ -435,7 +435,7 @@ ScanSections32 (
> >      }
> >    }
> >
> > -  if (!FoundSection) {
> > +  if (!FoundSection && mOutImageType !=3D FW_ACPI_IMAGE) {
> >      Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' =
section.");
> >      assert (FALSE);
> >    }
> > diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c
> b/BaseTools/Source/C/GenFw/Elf64Convert.c
> > index 8fe672e98448..8b09db7b690b 100644
> > --- a/BaseTools/Source/C/GenFw/Elf64Convert.c
> > +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c
> > @@ -714,7 +714,7 @@ ScanSections64 (
> >      }
> >    }
> >
> > -  if (!FoundSection) {
> > +  if (!FoundSection && mOutImageType !=3D FW_ACPI_IMAGE) {
> >      Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' =
section.");
> >      assert (FALSE);
> >    }
> >