public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <bret.barkelew@microsoft.com>
Subject: 回复: [edk2-devel] ECC: main function entry point in host-based unit tests
Date: Fri, 25 Sep 2020 15:24:12 +0800	[thread overview]
Message-ID: <001b01d6930c$de207cd0$9a617670$@byosoft.com.cn> (raw)
In-Reply-To: <MW4PR21MB18576EABAC4F07663BB24192EF360@MW4PR21MB1857.namprd21.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]

Bret:

 ECC mainly checks the firmware source coding style. Host based unit test
code may follow the different rule. I suggest to ignore ECC check result for
them. The ignored file or directory can be added into the Package level
ci.yaml file.

 

Thanks

Liming

发件人: bounce+27952+65601+4905953+8761045@groups.io
<bounce+27952+65601+4905953+8761045@groups.io> 代表 Bret Barkelew via
groups.io
发送时间: 2020年9月25日 10:39
收件人: devel@edk2.groups.io
主题: [edk2-devel] ECC: main function entry point in host-based unit tests

 

ERROR - EFI coding style error

ERROR - *Error code: 7001

ERROR - *There should be no use of int, unsigned, char, void, long in any
.c, .h or .asl files

ERROR - *file:
//home/corthon/_uefi/edk2_qemu_ci/edk2/MdeModulePkg/Library/VariablePolicyLi
b/VariablePolicyUnitTest/VariablePolicyUnitTest.c

ERROR - *Line number: 763

ERROR - *[main] Return type int

ERROR - 

ERROR - EFI coding style error

ERROR - *Error code: 8006

ERROR - *Function name does not follow the rules: 1. First character should
be upper case 2. Must contain lower case characters 3. No white space
characters

ERROR - *file:
//home/corthon/_uefi/edk2_qemu_ci/edk2/MdeModulePkg/Library/VariablePolicyLi
b/VariablePolicyUnitTest/VariablePolicyUnitTest.c

ERROR - *Line number: 2253

ERROR - *The function name [main] does not follow the rules

 

Currently, the host-based unit tests are using a standard C entry point:

int

main ()

 

That’s going to break both of these.

 

Another thing to override/figure out for host-based tests 

 

- Bret 

 




[-- Attachment #2: Type: text/html, Size: 6028 bytes --]

  reply	other threads:[~2020-09-25  7:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25  2:38 ECC: main function entry point in host-based unit tests Bret Barkelew
2020-09-25  7:24 ` gaoliming [this message]
2020-09-25  7:53 ` [edk2-devel] " Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001b01d6930c$de207cd0$9a617670$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox