From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.9495.1608029584842288612 for ; Tue, 15 Dec 2020 02:53:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 15 Dec 2020 18:53:01 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Liu, Zhiguang'" Cc: "'Kinney, Michael D'" , "'Yao, Jiewen'" , "'Huang, Jenny'" , "'Kowalewski, Robert'" , "'Feng, Roger'" References: <20201211013653.11624-1-w.sheng@intel.com> <006001d6d1c3$bcdc2420$36946c60$@byosoft.com.cn> <00fb01d6d2b2$306f4ae0$914de0a0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUEFUQ0hdIE1kZVBrZy9pbmNsdWRlOiBBZGQgRE1BUiBTQVRDIFRhYmxlIERlZmluaXRpb24=?= Date: Tue, 15 Dec 2020 18:53:02 +0800 Message-ID: <001b01d6d2d0$76478f00$62d6ad00$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHEI731H1Py/EssOxrUaQd3+RWu8gIAnFfVAu06SdoB17KmvwF+btLPArLf72ypxaKkMA== Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn I just update PR. Please check again.=20 > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+68855+4905953+8761045@groups.io > =B4=FA=B1=ED Sheng Wei > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA12=D4=C215=C8=D5 16:56 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; gaoliming@byosoft.com.cn; Liu,= Zhiguang > > =B3=AD=CB=CD: Kinney, Michael D ; Yao, Jiewe= n > ; Huang, Jenny ; > Kowalewski, Robert ; Feng, Roger > > =D6=F7=CC=E2: Re: [edk2-devel] =BB=D8=B8=B4: [PATCH] MdePkg/include: Add= DMAR SATC > Table Definition >=20 > Hi Liming, > I just check the PR, there is a "tianocore.PatchCheck" failing. >=20 > The fail belongs to the commit "Merge branch 'master' into MdeDmar" > c5741f1. > The commit of " MdePkg/include: Add DMAR SATC Table Definition " is > af411fd. >=20 > Is it any thing needs to change on this PR ? > BR > Sheng Wei >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > gaoliming > > Sent: 2020=C4=EA12=D4=C215=C8=D5 15:16 > > To: devel@edk2.groups.io; Sheng, W ; Liu, Zhiguang > > > > Cc: Kinney, Michael D ; Yao, Jiewen > > ; Huang, Jenny ; > > Kowalewski, Robert ; Feng, Roger > > > > Subject: =BB=D8=B8=B4: [edk2-devel] =BB=D8=B8=B4: [PATCH] MdePkg/inclu= de: Add DMAR > > SATC Table Definition > > > > PR https://github.com/tianocore/edk2/pull/1230 is created. > > > > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > > =B7=A2=BC=FE=C8=CB: bounce+27952+68842+4905953+8761045@groups.io > > > =B4=FA=B1=ED Sheng We= i > > > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA12=D4=C215=C8=D5 13:59 > > > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; gaoliming@byosoft.com.cn; = Liu, Zhiguang > > > > > > =B3=AD=CB=CD: Kinney, Michael D ; Yao, J= iewen > > > ; Huang, Jenny ; > > > Kowalewski, Robert ; Feng, Roger > > > > > > =D6=F7=CC=E2: Re: [edk2-devel] =BB=D8=B8=B4: [PATCH] MdePkg/include:= Add DMAR SATC > > Table > > > Definition > > > > > > Hi Liming, > > > Thank you for the "Reviewed-by". > > > Could you help to merge the patch to ekd2 master branch ? > > > Thank you. > > > BR > > > Sheng Wei > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > gaoliming > > > > Sent: 2020=C4=EA12=D4=C214=C8=D5 10:49 > > > > To: Liu, Zhiguang ; Sheng, W > > > ; > > > > devel@edk2.groups.io > > > > Cc: Kinney, Michael D ; Yao, Jiewen > > > > ; Huang, Jenny ; > > > > Kowalewski, Robert ; Feng, Roger > > > > > > > > Subject: [edk2-devel] =BB=D8=B8=B4: [PATCH] MdePkg/include: Add DM= AR SATC > > > > Table Definition > > > > > > > > Reviewed-by: Liming Gao > > > > > > > > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > > > > =B7=A2=BC=FE=C8=CB: Liu, Zhiguang > > > > > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA12=D4=C211=C8=D5 10:51 > > > > > =CA=D5=BC=FE=C8=CB: Sheng, W ; devel@edk2.gro= ups.io > > > > > =B3=AD=CB=CD: Kinney, Michael D ; Li= ming Gao > > > > > ; Yao, Jiewen ; > > > > Huang, > > > > > Jenny ; Kowalewski, Robert > > > > > ; Feng, Roger > > > > > =D6=F7=CC=E2: RE: [PATCH] MdePkg/include: Add DMAR SATC Table De= finition > > > > > > > > > > Reviewed-by: Zhiguang Liu > > > > > > > > > > > -----Original Message----- > > > > > > From: Sheng, W > > > > > > Sent: Friday, December 11, 2020 9:37 AM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Kinney, Michael D ; Liming Gao > > > > > > ; Liu, Zhiguang > > > > > > ; Yao, Jiewen ; > > > > > > Huang, Jenny ; Kowalewski, Robert > > > > > > ; Feng, Roger > > > > > > > > > > > > Subject: [PATCH] MdePkg/include: Add DMAR SATC Table Definitio= n > > > > > > > > > > > > SoC Integrated Address Translation Cache (SATC) reporting > > > > > > structure is > > > > one > > > > > > of the Remapping Structure, which is imported since Intel(R) > > > > Virtualization > > > > > > Technology for Directed I/O (VT-D) Architecture Specification v3.2. > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3109 > > > > > > > > > > > > Signed-off-by: Sheng Wei > > > > > > Cc: Michael D Kinney > > > > > > Cc: Liming Gao > > > > > > Cc: Zhiguang Liu > > > > > > Cc: Jiewen Yao > > > > > > Cc: Jenny Huang > > > > > > Cc: Kowalewski Robert > > > > > > Cc: Feng Roger > > > > > > --- > > > > > > .../IndustryStandard/DmaRemappingReportingTable.h | 34 > > > > > > ++++++++++++++++++++-- > > > > > > 1 file changed, 31 insertions(+), 3 deletions(-) > > > > > > > > > > > > diff --git > > > > > a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h > > > > > > > > b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h > > > > > > index 7c50dc972e..48f6959fec 100644 > > > > > > --- > > > > a/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h > > > > > > +++ > > > > b/MdePkg/Include/IndustryStandard/DmaRemappingReportingTable.h > > > > > > @@ -2,13 +2,13 @@ > > > > > > DMA Remapping Reporting (DMAR) ACPI table definition from > > > Intel(R) > > > > > > Virtualization Technology for Directed I/O (VT-D) > > > > > > Architecture > > > > > Specification. > > > > > > > > > > > > - Copyright (c) 2016 - 2018, Intel Corporation. All rights > > > > reserved.
> > > > > > + Copyright (c) 2016 - 2020, Intel Corporation. All rights > > > > reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > > > > > @par Revision Reference: > > > > > > - Intel(R) Virtualization Technology for Directed I/O > > > > > > (VT-D) > > > > > Architecture > > > > > > - Specification v2.5, Dated November 2017. > > > > > > - > > > > > > > > > > > > > > > > > http://www.intel.com/content/dam/www/public/us/en/documents/produc > > > > t- > > > > > > specifications/vt-directed-io-spec.pdf > > > > > > + Specification v3.2, Dated October 2020. > > > > > > + > > > > > > > > > > > > > > > > > https://software.intel.com/content/dam/develop/external/us/en/docume > > > > n > > > > t > > > > > s > > > > > /vt- > > > > > > directed-io-spec.pdf > > > > > > > > > > > > @par Glossary: > > > > > > - HPET - High Precision Event Timer @@ -39,6 +39,7 @@ > > > > > > #define EFI_ACPI_DMAR_TYPE_ATSR 0x02 > > > > > > #define EFI_ACPI_DMAR_TYPE_RHSA 0x03 > > > > > > #define EFI_ACPI_DMAR_TYPE_ANDD 0x04 > > > > > > +#define EFI_ACPI_DMAR_TYPE_SATC 0x05 > > > > > > ///@} > > > > > > > > > > > > /// > > > > > > @@ -216,6 +217,32 @@ typedef struct { > > > > > > UINT8 AcpiDeviceNumber; > > > > > > } EFI_ACPI_DMAR_ANDD_HEADER; > > > > > > > > > > > > +/** > > > > > > + An SoC Integrated Address Translation Cache (SATC) reportin= g > > > > structure > > > > > is > > > > > > + defined in section 8.8. > > > > > > +**/ > > > > > > +typedef struct { > > > > > > + EFI_ACPI_DMAR_STRUCTURE_HEADER Header; > > > > > > + /** > > > > > > + - Bit[0]: ATC_REQUIRED: > > > > > > + - If Set, indicates that every SoC integrated > > > > > > +device > > > > > enumerated > > > > > > + in this table has a functional requirement to > > > > > > + enable > > > > its > > > > > ATC > > > > > > + (via the ATS capability) for device operation= . > > > > > > + - If Clear, any device enumerated in this table > > > > > > + can > > > > > operate when > > > > > > + its respective ATC is not enabled (albeit wit= h > > > reduced > > > > > > + performance or functionality). > > > > > > + - Bits[7:1] Reserved. > > > > > > + **/ > > > > > > + UINT8 Flags; > > > > > > + UINT8 Reserved; > > > > > > + /// > > > > > > + /// The PCI Segment associated with this SATC structure. Al= l > > > > > > + SoC > > > > > integrated > > > > > > + /// devices within a PCI segment with same value for Flags > > > > > > + field must > > > > be > > > > > > + /// enumerated in the same SATC structure. > > > > > > + /// > > > > > > + UINT16 SegmentNumber; > > > > > > +} EFI_ACPI_DMAR_SATC_HEADER; > > > > > > + > > > > > > /** > > > > > > DMA Remapping Reporting Structure Header as defined in > > > > > > section > > > 8.1 > > > > > > This header will be followed by list of Remapping Structure= s > > > > > > listed > > > > > below > > > > > > @@ -224,6 +251,7 @@ typedef struct { > > > > > > - Root Port ATS Capability Reporting (ATSR) > > > > > > - Remapping Hardware Static Affinity (RHSA) > > > > > > - ACPI Name-space Device Declaration (ANDD) > > > > > > + - SoC Integrated Address Translation Cache reporting (SAT= C) > > > > > > These structure types must by reported in numerical order. > > > > > > i.e., All remapping structures of type 0 (DRHD) enumerated > > > > > > before remapping > > > > > > structures of type 1 (RMRR), and so forth. > > > > > > -- > > > > > > 2.16.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20