From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.32860.1613988018714435067 for ; Mon, 22 Feb 2021 02:00:19 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 22 Feb 2021 18:00:15 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Li, Walon'" Cc: , , References: <20210219093931.1458-1-walon.li@hpe.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyXSBNZGVNb2R1bGVQa2cvVWVmaUJvb3RNYW5hZ2VyTGliOiBQdXQgQm9vdE1lbnUgYXQgdGhlIGVuZCBvZiBCb290T3JkZXI=?= Date: Mon, 22 Feb 2021 18:00:16 +0800 Message-ID: <001b01d70901$85840cc0$908c2640$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHSB0iKlCA9c696PmmKdWtJE+YRtgLHz6kQqle19PA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+71931+4905953+8761045@groups.io > =B4=FA=B1=ED Wang, Sunny > (HPS SW) > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA2=D4=C222=C8=D5 17:30 > =CA=D5=BC=FE=C8=CB: Li, Walon ; devel@edk2.groups.io > =B3=AD=CB=CD: lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com; > gaoliming@byosoft.com.cn; Wang, Sunny (HPS SW) > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLi= b: Put > BootMenu at the end of BootOrder >=20 > Yeah, the problem is that always adding the Boot Menu to the top of > BootOrder causes confusion to the users who manipulate the Boot Order > under OS. Also, we can't find any reason why the Boot Menu needs to be > always added to the top of the Boot Order even if we check the change > history and emails. >=20 > Reviewed-by: Sunny Wang >=20 >=20 > -----Original Message----- > From: Li, Walon > Sent: Friday, February 19, 2021 5:40 PM > To: devel@edk2.groups.io > Cc: Li, Walon ; Wang, Sunny (HPS SW) > ; lersek@redhat.com; ray.ni@intel.com; > hao.a.wu@intel.com; gaoliming@byosoft.com.cn > Subject: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at > the end of BootOrder >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3135 >=20 > When Boot Menu does not exist in the BootOrder, > BmRegisterBootManagerMenu will create one into list. However, it should = be > put at the "end" of BootOrder instead of "start" of BootOrder. Replace 0 by -1 > to adjust order of load options. >=20 > Signed-off-by: Walon Li > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > index aff620ad52..6cc34d29c0 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > @@ -3,7 +3,7 @@ > Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. Copyright (c) > 2011 - 2020, Intel Corporation. All rights reserved.
-(C) Copyright > 2015-2016 Hewlett Packard Enterprise Development LP
+(C) Copyright > 2015-2021 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent **/@@ -2505,7 +2505,7 @@ > BmRegisterBootManagerMenu ( > EfiBootManagerFreeLoadOptions (BootOptions, > BootOptionCount); ); - return EfiBootManagerAddLoadOptionVariable > (BootOption, 0);+ return EfiBootManagerAddLoadOptionVariable > (BootOption, (UINTN) -1); } /**-- > 2.23.0.windows.1 >=20 >=20 >=20 >=20 >=20