Timothy:

 Thanks for your report. This is a real issue in Brotli decompress library.
Which tool chain has been verified? GCC5 or VS2019 or Both?

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Lin, Kuei-Hung
(Timothy) via groups.io
发送时间: 2023年1月13日 6:18
收件人: He, Jiangang <Jiangang.He@amd.com>; Chang, Abner
<Abner.Chang@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
devel@edk2.groups.io
抄送: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
<gaoliming@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>
主题: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing
source file to Brotli library

 

[AMD Official Use Only - General]

 

This patch tried to fix following build failure when linking the Brotli
decompress lib.

 

Steps to replicate the issue:

1 - Attach a NULL lib to DxeIpl.inf in any project's .DSC, say
OvmfPkgX64.dsc

  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { 

    <LibraryClasses>

 
NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLi
b.inf

  }

2 - Follow the EDKII'2 package build steps to build that project. Build.py
would compliains with following errors.

...

/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/
brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPrefixCodeRanges'

/usr/bin/ld:
/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/
brotli/c/dec/decode.c:1193: undefined reference to
`_kBrotliContextLookupTable'

/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function
`DecodeCommandBlockSwitch':

... 

/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function
`BrotliUefiDecompress':

/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/
brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefixCodeRanges'

/usr/bin/ld:
/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/
brotli/c/dec/decode.c:1193: undefined reference to
`_kBrotliContextLookupTable'

 

--

Timothy

 

 

 

 

  _____  

From: He, Jiangang <Jiangang.He@amd.com <mailto:Jiangang.He@amd.com> >
Sent: Thursday, January 12, 2023 8:08 AM
To: Chang, Abner <Abner.Chang@amd.com <mailto:Abner.Chang@amd.com> >;
Kinney, Michael D <michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io>  <devel@edk2.groups.io
<mailto:devel@edk2.groups.io> >; Lin, Kuei-Hung (Timothy)
<Kuei-Hung.Lin@amd.com <mailto:Kuei-Hung.Lin@amd.com> >
Cc: Bi, Dandan <dandan.bi@intel.com <mailto:dandan.bi@intel.com> >; Gao,
Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
Kirkendall, Garrett <Garrett.Kirkendall@amd.com
<mailto:Garrett.Kirkendall@amd.com> >; Kinney, Michael D
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing
source file to Brotli library 

 

[AMD Official Use Only - General]

 

Timothy will answer the question.

 

From: Chang, Abner <Abner.Chang@amd.com <mailto:Abner.Chang@amd.com> > 
Sent: Thursday, January 12, 2023 10:05 AM
To: Kinney, Michael D <michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Bi, Dandan <dandan.bi@intel.com <mailto:dandan.bi@intel.com> >; Gao,
Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
Kirkendall, Garrett <Garrett.Kirkendall@amd.com
<mailto:Garrett.Kirkendall@amd.com> >; Kinney, Michael D
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >; He,
Jiangang <Jiangang.He@amd.com <mailto:Jiangang.He@amd.com> >
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing
source file to Brotli library

 

[AMD Official Use Only - General]

 

Hi Mike, 

CC Jiangang, he can give the clear answer.

 

Thanks

Abner 

 

 

Get Outlook for Android <https://aka.ms/AAb9ysg> 

  _____  

From: Kinney, Michael D <michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> >
Sent: Thursday, January 12, 2023 11:23:48 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Chang, Abner
<Abner.Chang@amd.com <mailto:Abner.Chang@amd.com> >
Cc: Bi, Dandan <dandan.bi@intel.com <mailto:dandan.bi@intel.com> >; Gao,
Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
Kirkendall, Garrett <Garrett.Kirkendall@amd.com
<mailto:Garrett.Kirkendall@amd.com> >; Kinney, Michael D
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing
source file to Brotli library 

 

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.


Hi Abner,

What was the failure before this change?

This looks like something that would always break the build of source files
were missing.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Chang,
Abner via groups.io
> Sent: Wednesday, January 11, 2023 9:08 PM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
> Cc: Bi, Dandan <dandan.bi@intel.com <mailto:dandan.bi@intel.com> >; Gao,
Liming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
Garrett Kirkendall <garrett.kirkendall@amd.com
<mailto:garrett.kirkendall@amd.com> >;
> Abner Chang <abner.chang@amd.com <mailto:abner.chang@amd.com> >
> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing
source file to Brotli library
>
> From: Abner Chang <abner.chang@amd.com <mailto:abner.chang@amd.com> >
>
> Add missing source files to Brotli library INF.
>
> Signed-off-by: Jiangang He <jiangang.he@amd.com
<mailto:jiangang.he@amd.com> >
> Cc: Dandan Bi <dandan.bi@intel.com <mailto:dandan.bi@intel.com> >
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com
<mailto:garrett.kirkendall@amd.com> >
> Cc: Abner Chang <abner.chang@amd.com <mailto:abner.chang@amd.com> >
> ---
>  .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf  | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git
a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.i
nf
>
b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.i
nf
> index 525e92408d6..244c2e35023 100644
> ---
a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.i
nf
> +++
b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.i
nf
> @@ -5,6 +5,7 @@
>  #  Brotli was released on the website https://github.com/google/brotli.
>  #
>  #  Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -41,6 +42,10 @@
>    # Wrapper header files end #
>    brotli/c/common/dictionary.c
>    brotli/c/common/transform.c
> +  brotli/c/common/context.c
> +  brotli/c/common/platform.c
> +  brotli/c/common/constants.c
> +  brotli/c/common/shared_dictionary.c
>    brotli/c/dec/bit_reader.c
>    brotli/c/dec/decode.c
>    brotli/c/dec/huffman.c
> --
> 2.37.1.windows.1
>
>
>
> 
>