From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.12547.1674977736948978989 for ; Sat, 28 Jan 2023 23:35:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=HTYKnan2; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 5A824CD1F700 for ; Sun, 29 Jan 2023 15:35:30 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1674977730; bh=rYKYx4WVipBX9WIXm0SrQwU6PKVkQjacBaZreRiE/uM=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=HTYKnan2CoivB5UzVxfVR453Th/btDkdxYmwxwt/Ula1cy/P9qcfC/bczRxZPl2ka blJHG41EUl/KfOy9YfW6iYEb5lbwvK6duCsmU37qfgujFmErafxL8mdVVIO5udIpS/ LZU8b+ntQQ/7VrXXqpyNpsAqAFZxOAXy4pmiNNIA= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 55D94CD1F6BA for ; Sun, 29 Jan 2023 15:35:30 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 11FCDCD1F63E for ; Sun, 29 Jan 2023 15:35:30 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 99E66CD1F65E for ; Sun, 29 Jan 2023 15:35:27 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sun, 29 Jan 2023 15:35:20 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'He, Jiangang'" , "'Chang, Abner'" , "'Kinney, Michael D'" Cc: "'Bi, Dandan'" , "'Kirkendall, Garrett'" References: <20230112050822.1940-1-abner.chang@amd.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYyXSBNZGVNb2R1bGVQa2cvRGVjb21wcmVzczogQWRkIG1pc3Npbmcgc291cmNlIGZpbGUgdG8gQnJvdGxpIGxpYnJhcnk=?= Date: Sun, 29 Jan 2023 15:35:20 +0800 Message-ID: <001c01d933b4$3db80420$b9280c60$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKSDL1LjaDaouG629qjNe5QTMui1wLQvW42ARI+4h4BqPNZAgGuEsxWrQl+egA= Sender: "gaoliming" Content-Type: multipart/alternative; boundary="----=_NextPart_000_001D_01D933F7.4BDD8E10" Content-Language: zh-cn ------=_NextPart_000_001D_01D933F7.4BDD8E10 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Timothy: Thanks for your report. This is a real issue in Brotli decompress library. Which tool chain has been verified? GCC5 or VS2019 or Both? =20 Thanks Liming =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Lin, Kuei-Hung (Timothy) via groups.io =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA1=D4=C213=C8=D5 6:18 =CA=D5=BC=FE=C8=CB: He, Jiangang ; Chang, Abner ; Kinney, Michael D ; devel@edk2.groups.io =B3=AD=CB=CD: Bi, Dandan ; Gao, Liming ; Kirkendall, Garrett =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add miss= ing source file to Brotli library =20 [AMD Official Use Only - General] =20 This patch tried to fix following build failure when linking the Brotli decompress lib. =20 Steps to replicate the issue: 1 - Attach a NULL lib to DxeIpl.inf in any project's .DSC, say OvmfPkgX64.dsc MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {=20 =20 NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressL= i b.inf } 2 - Follow the EDKII'2 package build steps to build that project. Build.py would compliains with following errors. ... /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= / brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPrefixCodeRanges= ' /usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= / brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable' /usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `DecodeCommandBlockSwitch': ...=20 /usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `BrotliUefiDecompress': /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= / brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefixCodeRanges= ' /usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= / brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable' =20 -- Timothy =20 =20 =20 =20 _____ =20 From: He, Jiangang > Sent: Thursday, January 12, 2023 8:08 AM To: Chang, Abner >; Kinney, Michael D >; devel@edk2.groups.io >; Lin, Kuei-Hung (Timothy) > Cc: Bi, Dandan >; Gao, Liming >; Kirkendall, Garrett >; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library=20 =20 [AMD Official Use Only - General] =20 Timothy will answer the question. =20 From: Chang, Abner >=20 Sent: Thursday, January 12, 2023 10:05 AM To: Kinney, Michael D >; devel@edk2.groups.io =20 Cc: Bi, Dandan >; Gao, Liming >; Kirkendall, Garrett >; Kinney, Michael D >; He, Jiangang > Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library =20 [AMD Official Use Only - General] =20 Hi Mike,=20 CC Jiangang, he can give the clear answer. =20 Thanks Abner=20 =20 =20 Get Outlook for Android =20 _____ =20 From: Kinney, Michael D > Sent: Thursday, January 12, 2023 11:23:48 PM To: devel@edk2.groups.io >; Chang, Abner > Cc: Bi, Dandan >; Gao, Liming >; Kirkendall, Garrett >; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library=20 =20 Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, What was the failure before this change? This looks like something that would always break the build of source files were missing. Mike > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Chang, Abner via groups.io > Sent: Wednesday, January 11, 2023 9:08 PM > To: devel@edk2.groups.io =20 > Cc: Bi, Dandan >; Gao, Liming >; Garrett Kirkendall >; > Abner Chang > > Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library > > From: Abner Chang > > > Add missing source files to Brotli library INF. > > Signed-off-by: Jiangang He > > Cc: Dandan Bi > > Cc: Liming Gao > Cc: Garrett Kirkendall > > Cc: Abner Chang > > --- > .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.= i nf > b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.= i nf > index 525e92408d6..244c2e35023 100644 > --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.= i nf > +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.= i nf > @@ -5,6 +5,7 @@ > # Brotli was released on the website https://github.com/google/brotli. > # > # Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved. > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -41,6 +42,10 @@ > # Wrapper header files end # > brotli/c/common/dictionary.c > brotli/c/common/transform.c > + brotli/c/common/context.c > + brotli/c/common/platform.c > + brotli/c/common/constants.c > + brotli/c/common/shared_dictionary.c > brotli/c/dec/bit_reader.c > brotli/c/dec/decode.c > brotli/c/dec/huffman.c > -- > 2.37.1.windows.1 > > > >=20 > ------=_NextPart_000_001D_01D933F7.4BDD8E10 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Timothy:

 Thanks for= your report. This is a real issue in Brotli decompress library. Which tool= chain has been verified? GCC5 or VS2019 or Both?

 

Thanks<= /p>

Liming

=B7=A2=BC=FE=C8=CB:= devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=B1=ED Lin, Kuei-Hung (Timothy) via groups.io
<= span style=3D'font-family:DengXian'>=B7=A2=CB=CD=CA=B1=BC=E4: 2= 023=C4=EA1=D4=C213=C8=D5 6:18
=CA=D5=BC=FE=C8=CB: He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@am= d.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2= .groups.io
=B3=AD=CB=CD: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaolimi= ng@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com&g= t;
=D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source= file to Brotli library

 

[AMD Official Use Only - General]

 

<= div>

This patch tried to fix following build failure when linking the Brot= li decompress lib.

 

Steps to replicate the issue:=

1 - Attach a NULL lib to DxeIpl.inf in any = project's .DSC, say OvmfPkgX64.dsc

  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {

    <LibraryClass= es>

  &n= bsp;   NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCusto= mDecompressLib.inf

  }

2 - Follow the EDKII'2 package build steps to build that project. Build.= py would compliains with following errors.

=

...

/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustom= DecompressLib/brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPr= efixCodeRanges'

/usr/bin/ld: /home/ed= k2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/= c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'

/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltra= ns.o: in function `DecodeCommandBlockSwitch':

<= /div>

...

/usr/bin/ld: /tmp/ccKzzHN0.ltrans0= .ltrans.o: in function `BrotliUefiDecompress':

=

/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDec= ompressLib/brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefi= xCodeRanges'

/usr/bin/ld: /home/edk2/edk= 2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/= decode.c:1193: undefined reference to `_kBrotliContextLookupTable'

 

--

Timothy

 

 

 

 

From: He, Ji= angang <Jiangang.He@amd.com&g= t;
Sent: Thursday, January 12, 2023 8:08 AM
To: Chang, = Abner <Abner.Chang@amd.com>= ;; Kinney, Michael D <mich= ael.d.kinney@intel.com>; dev= el@edk2.groups.io <devel@edk= 2.groups.io>; Lin, Kuei-Hung (Timothy) <Kuei-Hung.Lin@amd.com>
Cc: Bi, Dandan <= dandan.bi@intel.com>; Gao, Li= ming <gaoliming@byosoft.com.= cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>
<= b>Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mis= sing source file to Brotli library

 

[AMD Offici= al Use Only - General]

 

Timothy will answer the question.

 

From:= Chang, Abner <Abner.Chang@amd.com>
Sent: Thursday, January = 12, 2023 10:05 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Cc: Bi, Dandan= <dandan.bi@intel.com>; Ga= o, Liming <gaoliming@byosoft= .com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>= ; He, Jiangang <Jiangang.He@amd.c= om>
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Deco= mpress: Add missing source file to Brotli library

 

[AMD Official Use Only - General]<= /span>

 

Hi Mike= , 

CC Jiangang, he can give the clear answer.

 

Thanks

Abner&nbs= p;

 

 

Get Outlook for Android<= /span>

=

From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Thursday, January 12, 2= 023 11:23:48 PM
To: devel= @edk2.groups.io <devel@edk2.= groups.io>; Chang, Abner <= Abner.Chang@amd.com>
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kirk= endall, Garrett <Garrett.K= irkendall@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: R= E: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file= to Brotli library

 

Caution: This message originated from an External Source. Use pro= per caution when opening attachments, clicking links, or responding.

Hi Abner,

What was the failure before this change?

This = looks like something that would always break the build of source files were= missing.

Mike

> -----Original Message-----
> From: = devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of= Chang, Abner via groups.io
> Sent: Wednesday, January 11, 2023 9:08 = PM
> To: devel@edk2.groups.io=
> Cc: Bi, Dandan <dand= an.bi@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Garrett Kirkendall <garrett.kirkendall@amd.com>;<= br>> Abner Chang <abner.chang@= amd.com>
> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decom= press: Add missing source file to Brotli library
>
> From: Abne= r Chang <abner.chang@amd.com&= gt;
>
> Add missing source files to Brotli library INF.
>=
> Signed-off-by: Jiangang He <jiangang.he@amd.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao &l= t;gaoliming@byosoft.com.cn&= gt;
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> --= -
>  .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf=   | 5 +++++
>  1 file changed, 5 insertions(+)
>
&= gt; diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCusto= mDecompressLib.inf
> b/MdeModulePkg/Library/BrotliCustomDecompressLib= /BrotliCustomDecompressLib.inf
> index 525e92408d6..244c2e35023 10064= 4
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustom= DecompressLib.inf
> +++ b/MdeModulePkg/Library/BrotliCustomDecompress= Lib/BrotliCustomDecompressLib.inf
> @@ -5,6 +5,7 @@
>  #&n= bsp; Brotli was released on the website https://github.com/google/brotli.
>  #
>&nbs= p; #  Copyright (c) 2017 - 2020, Intel Corporation. All rights reserve= d.<BR>
> +#  Copyright (C) 2023 Advanced Micro Devices, In= c. All rights reserved.<BR>
>  #
>  #  SPD= X-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -41,6 = +42,10 @@
>    # Wrapper header files end #
>&nb= sp;   brotli/c/common/dictionary.c
>    brot= li/c/common/transform.c
> +  brotli/c/common/context.c
> +=   brotli/c/common/platform.c
> +  brotli/c/common/constants= .c
> +  brotli/c/common/shared_dictionary.c
>  &= nbsp; brotli/c/dec/bit_reader.c
>    brotli/c/dec/deco= de.c
>    brotli/c/dec/huffman.c
> --
> 2.= 37.1.windows.1
>
>
>
>
>

------=_NextPart_000_001D_01D933F7.4BDD8E10--