From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Feng, Bob C'" <bob.c.feng@intel.com>, <devel@edk2.groups.io>
Cc: "'Chen, Christine'" <yuwei.chen@intel.com>
Subject: 回复: [Patch] BaseTools: Remove the dependency on the build intermediate file
Date: Wed, 4 Nov 2020 08:52:01 +0800 [thread overview]
Message-ID: <001e01d6b244$b52a8030$1f7f8090$@byosoft.com.cn> (raw)
In-Reply-To: <DM6PR11MB4073FCE6035F119399EF5267C9100@DM6PR11MB4073.namprd11.prod.outlook.com>
Bob:
I understand this change. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: Feng, Bob C <bob.c.feng@intel.com>
> 发送时间: 2020年11月2日 17:58
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Chen, Christine <yuwei.chen@intel.com>
> 主题: RE: [Patch] BaseTools: Remove the dependency on the build
> intermediate file
>
> Liming,
>
> Yes, it's also for other source files for AcpiTable, like *.asl.
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, November 2, 2020 9:33 AM
> To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io
> Cc: Chen, Christine <yuwei.chen@intel.com>
> Subject: 回复: [Patch] BaseTools: Remove the dependency on the build
> intermediate file
>
> Bob:
> So, this incremental issue happens when the source file name is changed.
> Is it only for *.aslc file, or also for other file, such as *.asl?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Bob Feng <bob.c.feng@intel.com>
> > 发送时间: 2020年10月26日 20:28
> > 收件人: devel@edk2.groups.io
> > 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen
> > <yuwei.chen@intel.com>
> > 主题: [Patch] BaseTools: Remove the dependency on the build
> intermediate
> > file
> >
> > When generating compressed section, the build tool rely on the build
> > intermediate files, which were generated in last build, to get the
> > file list. This method will cause the incremental build to generate
> > incorrect build result. To reproduce this incremental build error, you
> > can do:
> > 1. build Ovmf
> > 2. change the module OvmfPkg\AcpiTables a source file Facp.aslc name
> > from Facp.aslc to Facpxxx.aslc.
> > 3. change the Facp.aslc file name in [sources] section of
> > AcpiTables.inf 4. incremental build Ovmf
> >
> > you will see the in AcpiTables module Makefile, the corresponding
> > Facp.acpi file is not changed.
> >
> > This patch is to make the build always get file list from the INF.
> >
> > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > ---
> > BaseTools/Source/Python/GenFds/Section.py | 15 ---------------
> > 1 file changed, 15 deletions(-)
> >
> > diff --git a/BaseTools/Source/Python/GenFds/Section.py
> > b/BaseTools/Source/Python/GenFds/Section.py
> > index 2acb70f412..0382b2a759 100644
> > --- a/BaseTools/Source/Python/GenFds/Section.py
> > +++ b/BaseTools/Source/Python/GenFds/Section.py
> > @@ -139,25 +139,10 @@ class Section (SectionClassObject):
> > if File.Ext == Suffix:
> > FileList.append(File.Path)
> >
> > if (not IsMakefile and Suffix is not None and
> > os.path.exists(FfsInf.EfiOutputPath)) or (IsMakefile and Suffix is not
> None):
> > - #
> > - # Get Makefile path and time stamp
> > - #
> > - MakefileDir = FfsInf.EfiOutputPath[:-len('OUTPUT')]
> > - Makefile = os.path.join(MakefileDir, 'Makefile')
> > - if not os.path.exists(Makefile):
> > - Makefile = os.path.join(MakefileDir, 'GNUmakefile')
> > - if os.path.exists(Makefile):
> > - # Update to search files with suffix in all sub-dirs.
> > - Tuple = os.walk(FfsInf.EfiOutputPath)
> > - for Dirpath, Dirnames, Filenames in Tuple:
> > - for F in Filenames:
> > - if os.path.splitext(F)[1] == Suffix:
> > - FullName = os.path.join(Dirpath, F)
> > - if os.path.getmtime(FullName) >
> > os.path.getmtime(Makefile):
> > - FileList.append(FullName)
> > if not FileList:
> > SuffixMap = FfsInf.GetFinalTargetSuffixMap()
> > if Suffix in SuffixMap:
> > FileList.extend(SuffixMap[Suffix])
> >
> > --
> > 2.20.1.windows.1
>
>
next prev parent reply other threads:[~2020-11-04 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 12:27 [Patch] BaseTools: Remove the dependency on the build intermediate file Bob Feng
2020-11-02 1:32 ` 回复: " gaoliming
2020-11-02 9:57 ` Bob Feng
2020-11-04 0:52 ` gaoliming [this message]
2020-11-04 11:33 ` [edk2-devel] 回复: " Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01d6b244$b52a8030$1f7f8090$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox