From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.7546.1603083393799621977 for ; Sun, 18 Oct 2020 21:56:36 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 19 Oct 2020 12:56:31 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Feng, Bob C'" , , Cc: "'Bret Barkelew'" , "'Sean Brogan'" References: <000601d6a5b3$59da0e00$0d8e2a00$@byosoft.com.cn> <000b01d6a5b7$1bc40e00$534c2a00$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gQ0kgdGVzdCBvbiBjb3B5cmlnaHQ=?= Date: Mon, 19 Oct 2020 12:56:30 +0800 Message-ID: <001f01d6a5d4$35eb4830$a1c1d890$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHck2pVl3rctIGXdqdCnng2yG34lwF1Sy3jApttGCYBhtV4JgJWlbRfAnXXdCYCPqW6YwI5QfJqAXb3R6GpD+qpEA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Abner: You have submitted https://bugzilla.tianocore.org/show_bug.cgi?id=3D3011= for this issue. We can use it to track the fix.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66373+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Abner = Chang > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8819=E6=97= =A5 11:26 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Feng, Bob C ; devel@e= dk2.groups.io; > gaoliming ; spbrogan@outlook.com; > shenglei.zhang@intel.com > =E6=8A=84=E9=80=81: 'Bret Barkelew' ; 'Sean= Brogan' > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] CI test on copyright >=20 > Ok. I will submit an one. >=20 > Thanks Bob and Liming. >=20 > > -----Original Message----- > > From: Feng, Bob C [mailto:bob.c.feng@intel.com] > > Sent: Monday, October 19, 2020 11:01 AM > > To: Chang, Abner (HPS SW/FW Technologist) ; > > devel@edk2.groups.io; gaoliming ; > > spbrogan@outlook.com; shenglei.zhang@intel.com > > Cc: 'Bret Barkelew' ; 'Sean Brogan' > > > > Subject: RE: [edk2-devel] CI test on copyright > > > > Yes. > > > > -----Original Message----- > > From: Chang, Abner (HPS SW/FW Technologist) > > Sent: Monday, October 19, 2020 10:48 AM > > To: devel@edk2.groups.io; Feng, Bob C ; gaolimin= g > > ; spbrogan@outlook.com; > > shenglei.zhang@intel.com > > Cc: 'Bret Barkelew' ; 'Sean Brogan' > > > > Subject: RE: [edk2-devel] CI test on copyright > > > > Hi Bob, > > So the fix was only applied on c and h file as your mentioned? If so t= hen we > > need a BZ to add the same rule on the files other then c and h. > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf O= f > > > Bob Feng > > > Sent: Monday, October 19, 2020 10:25 AM > > > To: gaoliming ; devel@edk2.groups.io; > > > spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS > > > SW/FW Technologist) > > > Cc: 'Bret Barkelew' ; 'Sean Brogan' > > > > > > Subject: Re: [edk2-devel] CI test on copyright > > > > > > For the .c and .h, ECC add the rule to allow (C) Copyright format. > > > Looks this bug was not fixed completely. > > > INVALID URI REMOVED > > > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid- > > > > > > 3D2057&d=3DDwIGaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulk > > > > > > skz6qU3NYRO03nHp9P7Z5q59A3E&m=3DoWYb80tvgLGP9RZPAmJdv9pqtmSQb > > > DbP1z9tdxINhI0&s=3DKduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4- > > > mbW5cF4&e=3D > > > > > > Need file a new Bugzilla and fix this issue. > > > > > > Thanks, > > > Bob > > > -----Original Message----- > > > From: gaoliming > > > Sent: Monday, October 19, 2020 9:28 AM > > > To: Feng, Bob C ; devel@edk2.groups.io; > > > spbrogan@outlook.com; shenglei.zhang@intel.com; > > abner.chang@hpe.com > > > Cc: 'Bret Barkelew' ; 'Sean Brogan' > > > > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] CI test on copyright > > > > > > Bob: > > > Now, the problem is the inconsistent behavior. The same copyright > > > style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP = ) > > > in .c can pass ECC, but in .inf file can't pass ECC. I want to know = the > reason. > > > > > > Thanks > > > Liming > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Feng, Bob C > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8819= =E6=97=A5 9:25 > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byoso= ft.com.cn; > > > > spbrogan@outlook.com; shenglei.zhang@intel.com; > > > abner.chang@hpe.com > > > > =E6=8A=84=E9=80=81: 'Bret Barkelew' ;= 'Sean Brogan' > > > > > > > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] CI test on copyright > > > > > > > > In the ECC, the rule to check Copyright is to see if the Copyright > > > > is the first word of a line, and the Copyright should be followed = by > > > > a ( > > > > > > > > Liming, for your reference, the code in ECC > > > > > > > > ## _IsCopyrightLine > > > > # check whether current line is copyright line, the criteria is > > > > whether there is case insensitive keyword "Copyright" > > > > # followed by zero or more white space characters followed by a "(= " > > > > character # # @param LineContent: the line need to be checked # > > > > @return: True if current line is copyright line, False else # > > > > > > > > -Bob > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > gaoliming > > > > Sent: Monday, October 19, 2020 9:01 AM > > > > To: devel@edk2.groups.io; spbrogan@outlook.com; > > > > shenglei.zhang@intel.com; abner.chang@hpe.com > > > > Cc: 'Bret Barkelew' ; 'Sean Brogan' > > > > > > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] CI test on copyright > > > > > > > > I will check this issue first. > > > > > > > > Thanks > > > > Liming > > > > > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66349+4905953+8761045@= groups.io > > > > > =E4=BB=A3=E8=A1= =A8 Sean > > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8817= = =E6=97=A5 12:46 > > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; shenglei.zhan= g@intel.com; > > > > > abner.chang@hpe.com > > > > > =E6=8A=84=E9=80=81: Bret Barkelew ;= Sean Brogan > > > > > > > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] CI test on copyright > > > > > > > > > > ECC stuff was done by Intel. I would defer to them. > > > > > > > > > > Adding shenglei.zhang@intel.com > > > > > > > > > > On 10/15/2020 9:21 AM, Abner Chang wrote: > > > > > > Hi Sean and Bret, > > > > > > I got the CI test error which says the first line in file head= er > > > > > > section > > > > must > > > > > have the copyright information, however the copyright is there a= nd > > > > > looks > > > > to > > > > > me fine as below, > > > > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP > > > > > > > > > > > > [cid:image001.png@01D6A351.31688460] > > > > > > > > > > > > > > > > > > The interesting part is CI seems happy with below format of > > > > > > copyright, > > > > and > > > > > this issue only happens on INF file but not on the *.c and *.h. > > > > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP > > > > > > > > > > > > Any idea on this? > > > > > > Abner > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20