public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Ard Biesheuvel'" <ard.biesheuvel@arm.com>,
	"'Masahisa Kojima'" <masahisa.kojima@linaro.org>,
	"'edk2-devel-groups-io'" <devel@edk2.groups.io>
Cc: <Bret.Barkelew@microsoft.com>, <jian.j.wang@intel.com>,
	<hao.a.wu@intel.com>, "'Sami Mujawar'" <sami.mujawar@arm.com>,
	<jiewen.yao@intel.com>, "'Laszlo Ersek'" <lersek@redhat.com>
Subject: 回复: VariablePolicy support in StandaloneMM
Date: Wed, 2 Dec 2020 17:41:53 +0800	[thread overview]
Message-ID: <001f01d6c88f$5e394b60$1aabe220$@byosoft.com.cn> (raw)
In-Reply-To: <26f3dd80-0cda-c592-2482-000beada4c91@arm.com>

I just quick check. VarCheckPolicyLib doesn't consume DxeServicesLib. But, VarCheckPolicyLib library doesn't StandaloneMM type. 

So, I think StandaloneMM version VarCheckPolicyLib is required. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 发送时间: 2020年12月2日 17:02
> 收件人: Masahisa Kojima <masahisa.kojima@linaro.org>;
> edk2-devel-groups-io <devel@edk2.groups.io>
> 抄送: Bret.Barkelew@microsoft.com; jian.j.wang@intel.com;
> hao.a.wu@intel.com; gaoliming@byosoft.com.cn; Sami Mujawar
> <sami.mujawar@arm.com>; jiewen.yao@intel.com; Laszlo Ersek
> <lersek@redhat.com>
> 主题: Re: VariablePolicy support in StandaloneMM
> 
> (+ Laszlo)
> 
> On 12/2/20 9:57 AM, Masahisa Kojima wrote:
> > Hello All,
> >
> > VariablePolicy was introduced in November.
> > When Developerbox(aarch64 platform) boots with UEFI secure boot
> enabled,
> > the following error appears.
> > Note that this platform supports UEFI secure boot using the standalone
> > MM framework.
> >
> > --- StandaloneMM log ---
> > VariableLockRequestToLock - Failed to lock variable CapsuleMax! Not Ready
> >
> > ASSERT_EFI_ERROR (Status = Not Ready)
> > ASSERT [VariableStandaloneMm]
> >
> /home/ubuntu/src/uefi/edk2/MdeModulePkg/Universal/Variable/RuntimeDx
> e/VariableLockRequestToLock.c(64):
> > !EFI_ERROR (Status)
> > MmEntryPoint Done
> > ---
> >
> > In my check, this is simply because
> >
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c::InitVariablePoli
> cyLib()
> > is not called.
> >
> > InitVariablePolicyLib() is called from the following two files.
> > ---
> >   MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c:
> Status
> > = InitVariablePolicyLib( VariableServiceGetVariable );
> >   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c:  Status
> =
> > InitVariablePolicyLib (VariableServiceGetVariable);
> > ---
> > VariableDxe.c is not for MM_STANDALONE, so I tried to use
> > "VarCheckPolicyLib" as VarCheckLib,
> > but "VarCheckPolicyLib" requires
> > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf and
> > DxeServicesLib.inf is not for MM_STANDALONE, I am stuck here.
> >
> > Could you please take a look at this error?
> >
> 
> Thanks for the report.
> 
> Bret, could you please suggest a fix here?



  reply	other threads:[~2020-12-02  9:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  8:57 VariablePolicy support in StandaloneMM Masahisa Kojima
2020-12-02  9:02 ` Ard Biesheuvel
2020-12-02  9:41   ` gaoliming [this message]
2020-12-02 12:06     ` Yao, Jiewen
2020-12-03  9:14       ` Laszlo Ersek
2020-12-03 21:58       ` [edk2-devel] " Kun Qin
2020-12-14  6:14         ` Masahisa Kojima
2020-12-14 22:20           ` Kun Qin
2020-12-16 11:53             ` Masahisa Kojima
2020-12-16 17:52               ` Kun Qin
2020-12-17  1:10               ` 回复: " gaoliming
2020-12-17  1:56                 ` Masahisa Kojima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001f01d6c88f$5e394b60$1aabe220$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox