From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.8922.1642482892690109206 for ; Mon, 17 Jan 2022 21:14:53 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 18 Jan 2022 13:14:49 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Zhiguang Liu'" References: <084f67a9eecea828c8d03f5273ddbdaae170a4da.1642399328.git.zhiguang.liu@intel.com> <16CB0814A988873E.7166@groups.io> In-Reply-To: <16CB0814A988873E.7166@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbV2lraSBWMl0gV2lraTogQWRkIG9wdGlvbmFsIHN0ZXBzIGZvciBkZXZlbG9wZXIgdG8gcnVuIENJIHRlc3QgYmVmb3JlIHNlbmRpbmc=?= Date: Tue, 18 Jan 2022 13:14:51 +0800 Message-ID: <001f01d80c2a$5285f4a0$f791dde0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJk4dOP5LTh/IYw5eHtw/4UdqdMhQJ6eObzqzq9G5A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Push it at 7a96af0c093c90bb265243f99b6f07e9b8256451 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED gaoliming > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA1=D4=C217=C8=D5 18:29 > =CA=D5=BC=FE=C8=CB: 'Zhiguang Liu' ; devel@edk2.g= roups.io > =D6=F7=CC=E2: [edk2-devel] =BB=D8=B8=B4: [Wiki V2] Wiki: Add optional ste= ps for developer to > run CI test before sending >=20 > Reviewed-by: Liming Gao >=20 > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > =B7=A2=BC=FE=C8=CB: Zhiguang Liu > > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA1=D4=C217=C8=D5 14:03 > > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > > =B3=AD=CB=CD: Liming Gao > > =D6=F7=CC=E2: [Wiki V2] Wiki: Add optional steps for developer to run C= I test > before > > sending > > > > V2: Add the step to join in https://edk2.groups.io/g/devel and wait for > > approval when first sending patch. > > > > Cc: Liming Gao > > Signed-off-by: Zhiguang Liu > > --- > > EDK-II-Development-Process.md | 69 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++--------------- > > -- > > 1 file changed, 52 insertions(+), 17 deletions(-) > > > > diff --git a/EDK-II-Development-Process.md > > b/EDK-II-Development-Process.md > > index 469a979..d02baa7 100644 > > --- a/EDK-II-Development-Process.md > > +++ b/EDK-II-Development-Process.md > > @@ -59,20 +59,50 @@ The developer process for the EDK II project > > > > `$ git rebase origin/master` > > > > -9. Run the automated code formatting tool (Uncrustify) against your > changes > > > > - > > > > - - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") > > > > - > > > > - - The changes must pass local CI which includes a code formatting > check > > > > - in order to be merged into the code base. > > > > - > > > > - - It is strongly recommended that you format the code after each > commit. > > > > - The code can then be easily amended with the formatted output. > > Some > > > > - developers might also prefer to format frequently while writing the > > > > - code using the plugin instructions described in the code formatting > > > > - wiki page. > > > > - > > > > -10. Create patch (serial) to the [[edk2-devel]] mailing list > > > > +9. Run the automated code formatting tool (Uncrustify) against your > changes > > + > > + - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") > > + > > + - The changes must pass local CI which includes a code formatting > check > > + in order to be merged into the code base. > > + > > + - It is strongly recommended that you format the code after each > > commit. > > + The code can then be easily amended with the formatted output. > > Some > > + developers might also prefer to format frequently while writing the > > + code using the plugin instructions described in the code formatting > > + wiki page. > > + > > +10. (Optional) Push changes to the developer's fork of the EDK II project > > + repository. > > + > > + - How to create a [GitHub > > > fork](https://help.github.com/en/github/getting-started-with-github/fork-a-= r > > epo) > > + - **NOTE:** A GitHub fork can also be created using the command > > line > > + utility called [`hub`](https://github.com/github/hub/releases)= . > > The > > + `hub` usage information can be found > > [here](https://hub.github.com/hub.1.html). > > + > > + - Add remote to the developer's fork of the EDK II project > > + > > + `$ git remote add > > https://github.com//edk2.git` > > + > > + - Push the integration branch. > > + > > + `$ git push ` > > + > > +11. (Optional) Create a GitHub pull request from the developer's > > + to edk2/master to run CI check. > > + > > + - How to create a [GitHub pull > > > request](https://help.github.com/en/github/collaborating-with-issues-and-pu > > ll-requests/creating-a-pull-request) > > + - **NOTE:** A GitHub pull request can also be created using the > > command > > + line utility called > [`hub`](https://github.com/github/hub/releases). > > + The `hub` usage information can be found > > [here](https://hub.github.com/hub.1.html). > > + > > + - Declare that it is for CI check test in the pull request title and > > + description. > > + > > + - Resolve GitHub pull request issues if it fails. Please refrence > step 8 > > + in the below **The maintainer process for the EDK II project** > > + > > +12. Create patch (serial) to the [[edk2-devel]] mailing list > > > > - Clean out any old patches: `$ rm *.patch` > > > > @@ -84,10 +114,15 @@ The developer process for the EDK II project > > - Add the `--subject-prefix=3D"PATCH v2"` if you are sending out= a > > second version of the patch series. > > > > - - `$ git send-email *.patch` > > + - `$ git send-email *.patch --to devel@edk2.groups.io` > > + > > + - If it is the first time to send mail to edk2 mail list, please join > > + https://edk2.groups.io/g/devel and expect there will be delay > > because > > + the mail needs manual approval from the admin > > (gaoliming@byosoft.com.cn > > + or michael.d.kinney@intel.com) of https://edk2.groups.io/g/devel > > > > -11. Modify local commits based on the review feedbacks and repeat step= s > > > > - 3 to 9 > > +13. Modify local commits based on the review feedbacks and repeat step= s > > + 3 to 11 > > > > - For the latest commit, you can use `$ git commit --amend` > > > > -- > > 2.32.0.windows.2 >=20 >=20 >=20 >=20 >=20 >=20 >=20