public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: <devel@edk2.groups.io>, <abner.chang@amd.com>
Cc: "'Abdul Lateef Attar'" <AbdulLateef.Attar@amd.com>,
	"'Isaac Oram'" <isaac.w.oram@intel.com>,
	"'Nickle Wang'" <nicklew@nvidia.com>
Subject: 回复: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg
Date: Wed, 11 Oct 2023 09:56:08 +0800	[thread overview]
Message-ID: <002001d9fbe6$1b59f370$520dda50$@byosoft.com.cn> (raw)
In-Reply-To: <20231010082223.1421-1-abner.chang@amd.com>

This change is a good clean. Reviewed-by: Liming Gao <gaoliming@byosoft.com.
cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Chang, Abner
> via groups.io
> 发送时间: 2023年10月10日 16:22
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Isaac Oram
> <isaac.w.oram@intel.com>; Nickle Wang <nicklew@nvidia.com>
> 主题: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi:
> Remove IpmiCommandLib.h from ManageabilityPkg
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Remove duplicate IpmiCommandLib.h and use the one
> under MdeModulePKg instead.
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> ---
>  .../Universal/IpmiBmcElog/BmcElog.inf         |   1 +
>  .../Universal/IpmiFrb/FrbPei.inf              |   1 +
>  .../Universal/IpmiFru/IpmiFru.inf             |   1 +
>  .../Universal/IpmiOsWdt/OsWdt.inf             |   1 +
>  .../Universal/IpmiSolStatus/SolStatus.inf     |   1 +
>  .../Include/Library/IpmiCommandLib.h          | 620 ------------------
>  6 files changed, 5 insertions(+), 620 deletions(-)
>  delete mode 100644
> Features/ManageabilityPkg/Include/Library/IpmiCommandLib.h
> 
> diff --git a/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.inf
> b/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.inf
> index 4c28862fe5..e624f9c8fa 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.inf
> +++ b/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.inf
> @@ -21,6 +21,7 @@
> 
>  [Packages]
>    ManageabilityPkg/ManageabilityPkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
> 
>  [LibraryClasses]
> diff --git a/Features/ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf
> b/Features/ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf
> index 89d633f32e..74d9f5d57e 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf
> +++ b/Features/ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf
> @@ -20,6 +20,7 @@
> 
>  [Packages]
>    ManageabilityPkg/ManageabilityPkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
> 
>  [LibraryClasses]
> diff --git a/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf
> b/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf
> index ddef310309..2eaad95417 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf
> +++ b/Features/ManageabilityPkg/Universal/IpmiFru/IpmiFru.inf
> @@ -21,6 +21,7 @@
> 
>  [Packages]
>    ManageabilityPkg/ManageabilityPkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
> 
>  [LibraryClasses]
> diff --git a/Features/ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf
> b/Features/ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf
> index b5af3b25e1..b7720ee4d3 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf
> +++ b/Features/ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf
> @@ -20,6 +20,7 @@
> 
>  [Packages]
>    ManageabilityPkg/ManageabilityPkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
> 
>  [LibraryClasses]
> diff --git
a/Features/ManageabilityPkg/Universal/IpmiSolStatus/SolStatus.inf
> b/Features/ManageabilityPkg/Universal/IpmiSolStatus/SolStatus.inf
> index 1d7cbf1a08..0525ad7d76 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiSolStatus/SolStatus.inf
> +++ b/Features/ManageabilityPkg/Universal/IpmiSolStatus/SolStatus.inf
> @@ -21,6 +21,7 @@
> 
>  [Packages]
>    ManageabilityPkg/ManageabilityPkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
> 
>  [Pcd]
> diff --git a/Features/ManageabilityPkg/Include/Library/IpmiCommandLib.h
> b/Features/ManageabilityPkg/Include/Library/IpmiCommandLib.h
> deleted file mode 100644
> index 42d4f69359..0000000000
> --- a/Features/ManageabilityPkg/Include/Library/IpmiCommandLib.h
> +++ /dev/null
> @@ -1,620 +0,0 @@
> -/** @file
> -  This library abstract how to send/receive IPMI command.
> -
> -Copyright (c) 2018-2021, Intel Corporation. All rights reserved.<BR>
> -Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> -
> -SPDX-License-Identifier: BSD-2-Clause-Patent
> -
> -**/
> -
> -#ifndef IPMI_COMMAND_LIB_H_
> -#define IPMI_COMMAND_LIB_H_
> -
> -#include <Uefi.h>
> -#include <IndustryStandard/Ipmi.h>
> -
> -///
> -/// Functions for IPMI NetFnApp commands
> -///
> -
> -/**
> -  This function is used to retrieve device ID.
> -
> -  @param [out]  DeviceId  The pointer to receive
> IPMI_GET_DEVICE_ID_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetDeviceId (
> -  OUT IPMI_GET_DEVICE_ID_RESPONSE  *DeviceId
> -  );
> -
> -/**
> -  This function returns device self test results
> -
> -  @param [out]  SelfTestResult  The pointer to receive
> IPMI_SELF_TEST_RESULT_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSelfTestResult (
> -  OUT IPMI_SELF_TEST_RESULT_RESPONSE  *SelfTestResult
> -  );
> -
> -/**
> -  This function is used for starting and restarting the Watchdog
> -  Timer from the initial countdown value that was specified in
> -  the Set Watchdog Timer command the watchdog timer.
> -
> -  @param [out]  CompletionCode  IPMI completetion code, refer to
> Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiResetWatchdogTimer (
> -  OUT UINT8  *CompletionCode
> -  );
> -
> -/**
> -  This function  is used for initializing and configuring
> -  the watchdog timer.
> -
> -  @param [in]   SetWatchdogTimer  Pointer to receive
> IPMI_SET_WATCHDOG_TIMER_REQUEST.
> -  @param [out]  CompletionCode    IPMI completetion code, refer to
> Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSetWatchdogTimer (
> -  IN  IPMI_SET_WATCHDOG_TIMER_REQUEST  *SetWatchdogTimer,
> -  OUT UINT8                            *CompletionCode
> -  );
> -
> -/**
> -  This function retrieves the current settings and present
> -  countdown of the watchdog timer.
> -
> -  @param [out]  GetWatchdogTimer  Pointer to receive
> IPMI_GET_WATCHDOG_TIMER_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetWatchdogTimer (
> -  OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE  *GetWatchdogTimer
> -  );
> -
> -/**
> -  This function enables message reception into Message Buffers,
> -  and any interrupt associated with that buffer getting full.
> -
> -  @param [in]   SetBmcGlobalEnables  Pointer receive to
> IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST.
> -  @param [out]  CompletionCode       IPMI completetion code, refer to
> Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSetBmcGlobalEnables (
> -  IN  IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST
> *SetBmcGlobalEnables,
> -  OUT UINT8                                *CompletionCode
> -  );
> -
> -/**
> -  This function retrieves the present setting of the Global Enables
> -
> -  @param [out]  GetBmcGlobalEnables  Pointer to receive
> IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetBmcGlobalEnables (
> -  OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE
> *GetBmcGlobalEnables
> -  );
> -
> -/**
> -  This function is used to flush unread data from the Receive
> -  Message Queue or Event Message Buffer
> -
> -  @param [in]   ClearMessageFlagsRequest
> IPMI_CLEAR_MESSAGE_FLAGS_REQUEST
> -  @param [out]  CompletionCode           IPMI completetion code,
> refer to Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiClearMessageFlags (
> -  IN  IPMI_CLEAR_MESSAGE_FLAGS_REQUEST
> *ClearMessageFlagsRequest,
> -  OUT UINT8                             *CompletionCode
> -  );
> -
> -/**
> -  This function is used to retrieve the present message available states.
> -
> -  @param [out]  GetMessageFlagsResponse  Pointer to receive
> IPMI_GET_MESSAGE_FLAGS_RESPONSE
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetMessageFlags (
> -  OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE
> *GetMessageFlagsResponse
> -  );
> -
> -/**
> -  This function is used to get data from the Receive Message Queue.
> -
> -  @param [out]      GetMessageResponse      Pointer to receive
> IPMI_GET_MESSAGE_RESPONSE.
> -  @param [in, out]  GetMessageResponseSize  When in, which is the
> expected size of
> -                                            response. When out,
> which is the actual
> -                                            size returned.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetMessage (
> -  OUT IPMI_GET_MESSAGE_RESPONSE  *GetMessageResponse,
> -  IN OUT UINT32                  *GetMessageResponseSize
> -  );
> -
> -/**
> -  This function is used for bridging IPMI messages between channels,
> -  and between the system management software (SMS) and a given
> channel
> -
> -  @param [in]   SendMessageRequest       Pointer to
> IPMI_SEND_MESSAGE_REQUEST.
> -  @param [in]   SendMessageRequestSize   Size of entire
> SendMessageRequestSize.
> -  @param [out]  SendMessageResponse      Pointer to receive
> IPMI_SEND_MESSAGE_RESPONSE.
> -  @param [in]   SendMessageResponseSize  When in, which is the
> expected size of
> -                                         response. When out,
> which is the actual
> -                                         size returned.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSendMessage (
> -  IN  IPMI_SEND_MESSAGE_REQUEST   *SendMessageRequest,
> -  IN  UINT32                      SendMessageRequestSize,
> -  OUT IPMI_SEND_MESSAGE_RESPONSE  *SendMessageResponse,
> -  IN OUT UINT32                   *SendMessageResponseSize
> -  );
> -
> -/**
> -  This function gets the system UUID.
> -
> -  @param [out]  SystemGuid   The pointer to retrieve system UUID.
> -
> -  @retval EFI_SUCCESS               UUID is returned.
> -  @retval EFI_INVALID_PARAMETER     SystemGuid is a NULL pointer.
> -  @retval Others                    See return value of
> IpmiSubmitCommand () function.
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSystemUuid (
> -  OUT EFI_GUID  *SystemGuid
> -  );
> -
> -/**
> -  This function gets the channel information.
> -
> -  @param [in]   GetChannelInfoRequest       The get channel
> information request.
> -  @param [out]  GetChannelInfoResponse      The get channel
> information response.
> -  @param [out]  GetChannelInfoResponseSize  When input, the expected
> size of response.
> -                                            When output, the
> exact size of the returned
> -                                            response.
> -
> -  @retval EFI_SUCCESS            Get channel information successfully.
> -  @retval EFI_INVALID_PARAMETER  One of the given input parameters is
> invalid.
> -  @retval Others                 See return value of
> IpmiSubmitCommand () function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetChannelInfo (
> -  IN  IPMI_GET_CHANNEL_INFO_REQUEST   *GetChannelInfoRequest,
> -  OUT IPMI_GET_CHANNEL_INFO_RESPONSE  *GetChannelInfoResponse,
> -  OUT UINT32
> *GetChannelInfoResponseSize
> -  );
> -
> -///
> -/// Functions for IPMI NetFnTransport commands.
> -///
> -
> -/**
> -  This function sends command to BMC to notify a remote application
> -  that a SOL payload is activating on another channel.
> -
> -  @param [in]   SolActivatingRequest  Pointer to
> IPMI_SOL_ACTIVATING_REQUEST.
> -  @param [out]  CompletionCode        IPMI completetion code, refer
> to Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSolActivating (
> -  IN  IPMI_SOL_ACTIVATING_REQUEST  *SolActivatingRequest,
> -  OUT UINT8                        *CompletionCode
> -  );
> -
> -/**
> -  This function is used to set parameters such as the network addressing
> -  information required for SOL payload operation.
> -
> -  @param [in]  SetConfigurationParametersRequest      Pointer to
> IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST.
> -  @param [in]  SetConfigurationParametersRequestSize  Size of entire
> SetConfigurationParametersRequestSize.
> -  @param [out] CompletionCode                         IPMI
> completetion code, refer to Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSetSolConfigurationParameters (
> -  IN  IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST
> *SetConfigurationParametersRequest,
> -  IN  UINT32
> SetConfigurationParametersRequestSize,
> -  OUT UINT8
> *CompletionCode
> -  );
> -
> -/**
> -  This function is used to retrieve the configuration parameters from the
> -  Set SOL Configuration Parameters.
> -
> -  @param [in]       GetConfigurationParametersRequest       Pointer
> to IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST.
> -  @param [out]      GetConfigurationParametersResponse      Pointer
> to receive IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE.
> -  @param [in, out]  GetConfigurationParametersResponseSize  When in,
> which is the expected size of
> -
> response. When out, which is the actual
> -
> size returned.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSolConfigurationParameters (
> -  IN  IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST
> *GetConfigurationParametersRequest,
> -  OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE
> *GetConfigurationParametersResponse,
> -  IN OUT UINT32
> *GetConfigurationParametersResponseSize
> -  );
> -
> -/**
> -  This function gets the LAN configuration parameter.
> -
> -  @param[in]      GetLanConfigurationParametersRequest   Request
> data
> -  @param[out]     GetLanConfigurationParametersResponse  Response
> data
> -  @param[in,out]  GetLanConfigurationParametersSize      When input,
> the expected size of response data.
> -
> When out, the exact size of response data.
> -
> -  @retval EFI_SUCCESS            Lan configuration parameter is
> returned in the response.
> -  @retval EFI_INVALID_PARAMETER  One of the given input parameters is
> invalid.
> -  @retval Others                 Other errors.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetLanConfigurationParameters (
> -  IN     IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST
> *GetLanConfigurationParametersRequest,
> -  OUT    IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE
> *GetLanConfigurationParametersResponse,
> -  IN OUT UINT32
> *GetLanConfigurationParametersSize
> -  );
> -
> -///
> -/// Functions for IPMI NetFnChasis commands
> -///
> -
> -/**
> -  This function returns information about which main chassis management
> functions are
> -  present and  what addresses are used to access those functions.
> -
> -  @param [out]  GetChassisCapabilitiesResponse  Pointer to
> IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetChassisCapabilities (
> -  OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE
> *GetChassisCapabilitiesResponse
> -  );
> -
> -/**
> -  This function gets  information regarding the high-level status of the
> system
> -  chassis and main power subsystem.
> -
> -  @param [out]  GetChassisStatusResponse  Pointer to
> IPMI_GET_CHASSIS_STATUS_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetChassisStatus (
> -  OUT IPMI_GET_CHASSIS_STATUS_RESPONSE
> *GetChassisStatusResponse
> -  );
> -
> -/**
> -  This function sends command to control power up, power down, and reset.
> -
> -  @param [in]   ChassisControlRequest  Pointer to
> IPMI_CHASSIS_CONTROL_REQUEST.
> -  @param [out]  CompletionCode         IPMI completetion code, refer
> to Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiChassisControl (
> -  IN IPMI_CHASSIS_CONTROL_REQUEST  *ChassisControlRequest,
> -  OUT UINT8                        *CompletionCode
> -  );
> -
> -/**
> -  This function is used to configure the power restore policy.
> -
> -  @param [in]   ChassisControlRequest   Pointer to
> IPMI_SET_POWER_RESTORE_POLICY_REQUEST.
> -  @param [out]  ChassisControlResponse  Pointer to
> IPMI_SET_POWER_RESTORE_POLICY_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSetPowerRestorePolicy (
> -  IN  IPMI_SET_POWER_RESTORE_POLICY_REQUEST
> *ChassisControlRequest,
> -  OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE
> *ChassisControlResponse
> -  );
> -
> -/**
> -  This function is used to set parameters that direct the system boot
> -  following a system power up or reset.
> -
> -  @param [in]   BootOptionsRequest   Pointer to
> IPMI_SET_BOOT_OPTIONS_REQUEST.
> -  @param [out]  BootOptionsResponse  Pointer to
> IPMI_SET_BOOT_OPTIONS_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSetSystemBootOptions (
> -  IN  IPMI_SET_BOOT_OPTIONS_REQUEST   *BootOptionsRequest,
> -  OUT IPMI_SET_BOOT_OPTIONS_RESPONSE  *BootOptionsResponse
> -  );
> -
> -/**
> -  This function is used to retrieve the boot options set by the
> -  Set System Boot Options command.
> -
> -  @param [in]   BootOptionsRequest   Pointer to
> IPMI_GET_BOOT_OPTIONS_REQUEST.
> -  @param [out]  BootOptionsResponse  Pointer to
> IPMI_GET_BOOT_OPTIONS_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSystemBootOptions (
> -  IN  IPMI_GET_BOOT_OPTIONS_REQUEST   *BootOptionsRequest,
> -  OUT IPMI_GET_BOOT_OPTIONS_RESPONSE  *BootOptionsResponse
> -  );
> -
> -///
> -/// Functions for IPMI NetFnStorage commands
> -///
> -
> -/**
> -  This function is used to retrieve FRU Inventory Area
> -
> -  @param [in]   GetFruInventoryAreaInfoRequest   Pointer to
> IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST.
> -  @param [out]  GetFruInventoryAreaInfoResponse  Pointer to
> IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetFruInventoryAreaInfo (
> -  IN  IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST
> *GetFruInventoryAreaInfoRequest,
> -  OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE
> *GetFruInventoryAreaInfoResponse
> -  );
> -
> -/**
> -  This function returns specified data from the FRU Inventory Info area.
> -
> -  @param [in]       ReadFruDataRequest       Pointer to
> IPMI_READ_FRU_DATA_REQUEST.
> -  @param [out]      ReadFruDataResponse      Pointer to
> IPMI_READ_FRU_DATA_RESPONSE.
> -  @param [in, out]  ReadFruDataResponseSize  Returns the size of
> ReadFruDataResponse.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiReadFruData (
> -  IN  IPMI_READ_FRU_DATA_REQUEST   *ReadFruDataRequest,
> -  OUT IPMI_READ_FRU_DATA_RESPONSE  *ReadFruDataResponse,
> -  IN OUT UINT32                    *ReadFruDataResponseSize
> -  );
> -
> -/**
> -  This function writes specified data from the FRU Inventory Info area.
> -
> -  @param [in]   WriteFruDataRequest      Pointer to
> IPMI_WRITE_FRU_DATA_REQUEST.
> -  @param [in]   WriteFruDataRequestSize  Size of WriteFruDataRequest.
> -  @param [out]  WriteFruDataResponse     Pointer to receive
> IPMI_WRITE_FRU_DATA_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiWriteFruData (
> -  IN  IPMI_WRITE_FRU_DATA_REQUEST   *WriteFruDataRequest,
> -  IN  UINT32                        WriteFruDataRequestSize,
> -  OUT IPMI_WRITE_FRU_DATA_RESPONSE  *WriteFruDataResponse
> -  );
> -
> -/**
> -  This function returns the number of entries in the SEL
> -
> -  @param [out] GetSelInfoResponse     Pointer to receive
> IPMI_GET_SEL_INFO_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSelInfo (
> -  OUT IPMI_GET_SEL_INFO_RESPONSE  *GetSelInfoResponse
> -  );
> -
> -/**
> -  This function retrieves entries from the SEL
> -
> -  @param [in]   GetSelEntryRequest       Pointer to
> IPMI_GET_SEL_ENTRY_REQUEST.
> -  @param [out]  GetSelEntryResponse      Pointer to receive
> IPMI_GET_SEL_ENTRY_RESPONSE.
> -  @param [in]   GetSelEntryResponseSize  Size of entire
> GetSelEntryResponse.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSelEntry (
> -  IN IPMI_GET_SEL_ENTRY_REQUEST    *GetSelEntryRequest,
> -  OUT IPMI_GET_SEL_ENTRY_RESPONSE  *GetSelEntryResponse,
> -  IN OUT UINT32                    *GetSelEntryResponseSize
> -  );
> -
> -/**
> -  This function adds an entry in the SEL
> -
> -  @param [in]   AddSelEntryRequest   Pointer to
> IPMI_ADD_SEL_ENTRY_REQUEST.
> -  @param [out]  AddSelEntryResponse  Pointer to receive
> IPMI_ADD_SEL_ENTRY_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiAddSelEntry (
> -  IN IPMI_ADD_SEL_ENTRY_REQUEST    *AddSelEntryRequest,
> -  OUT IPMI_ADD_SEL_ENTRY_RESPONSE  *AddSelEntryResponse
> -  );
> -
> -/**
> -  This function adds SEL Entry command that allows the record to be
> incrementally
> -  added to the SEL.
> -
> -  @param [in]  PartialAddSelEntryRequest      Pointer to
> IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST.
> -  @param [in]  PartialAddSelEntryRequestSize  Size of entire
> PartialAddSelEntryRequest.
> -  @param [out] PartialAddSelEntryResponse     Pointer to receive
> IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE.
> -
> -  @retval EFI_STATUS   See return value of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiPartialAddSelEntry (
> -  IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST
> *PartialAddSelEntryRequest,
> -  IN UINT32
> PartialAddSelEntryRequestSize,
> -  OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE
> *PartialAddSelEntryResponse
> -  );
> -
> -/**
> -  This function erases all contents of the System Event Log.
> -
> -  @param [in]   ClearSelRequest   Pointer to
> IPMI_CLEAR_SEL_REQUEST.
> -  @param [out]  ClearSelResponse  Pointer to receive
> IPMI_CLEAR_SEL_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiClearSel (
> -  IN IPMI_CLEAR_SEL_REQUEST    *ClearSelRequest,
> -  OUT IPMI_CLEAR_SEL_RESPONSE  *ClearSelResponse
> -  );
> -
> -/**
> -  This function returns the time from the SEL Device.
> -
> -  @param [out]  GetSelTimeResponse  Pointer to
> IPMI_GET_SEL_TIME_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSelTime (
> -  OUT IPMI_GET_SEL_TIME_RESPONSE  *GetSelTimeResponse
> -  );
> -
> -/**
> -  This function set the time in the SEL Device.
> -
> -  @param [in]   SetSelTimeRequest  Pointer to
> IPMI_SET_SEL_TIME_REQUEST.
> -  @param [out]  CompletionCode     IPMI completetion code, refer to
> Ipmi.h.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiSetSelTime (
> -  IN IPMI_SET_SEL_TIME_REQUEST  *SetSelTimeRequest,
> -  OUT UINT8                     *CompletionCode
> -  );
> -
> -/**
> -  This function returns the SDR command version for the SDR Repository.
> -
> -  @param [out]  ClearSelResponse  Pointer to receive
> IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSdrRepositoryInfo (
> -  OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE
> *GetSdrRepositoryInfoResp
> -  );
> -
> -/**
> -  This function returns the sensor record specified by Record ID.
> -
> -  @param [in]       GetSdrRequest       Pointer to
> IPMI_GET_SDR_REQUEST.
> -  @param [out]      GetSdrResponse      Pointer to receive
> IPMI_GET_SDR_RESPONSE.
> -  @param [in, out]  GetSdrResponseSize  Size of entire GetSdrResponse.
> -
> -  @retval EFI_STATUS   See the return values of IpmiSubmitCommand ()
> function.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -IpmiGetSdr (
> -  IN  IPMI_GET_SDR_REQUEST   *GetSdrRequest,
> -  OUT IPMI_GET_SDR_RESPONSE  *GetSdrResponse,
> -  IN OUT UINT32              *GetSdrResponseSize
> -  );
> -
> -#endif // IPMI_COMMAND_LIB_H_
> --
> 2.37.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109509): https://edk2.groups.io/g/devel/message/109509
Mute This Topic: https://groups.io/mt/101889096/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-10-11  1:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  8:22 [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg Chang, Abner via groups.io
2023-10-10  8:22 ` [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg Chang, Abner via groups.io
2023-10-11  1:56   ` 回复: " gaoliming via groups.io
2023-10-11  1:56 ` gaoliming via groups.io [this message]
     [not found] ` <178CB15EC6448604.24994@groups.io>
2023-10-18  4:52   ` Chang, Abner via groups.io
2023-10-29  2:07     ` Chang, Abner via groups.io
     [not found]   ` <178F1A8A0B9F4787.14388@groups.io>
2023-10-27  1:49     ` Chang, Abner via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002001d9fbe6$1b59f370$520dda50$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox