From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.1704.1604540535287614920 for ; Wed, 04 Nov 2020 17:42:16 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 05 Nov 2020 09:42:11 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Dandan Bi'" , "'Eric Dong'" , "'Gao, Liming'" References: <20201104063557.22857-1-abner.chang@hpe.com> <16443D0E1EA9DC18.19640@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1ZGUiBzdXBwb3J0IFJFU1RfU1RZTEUgUEFUQ0ggdjMgMy80XSBNZGVNb2R1bGVQa2cvTGlicmFyeTogUmV2aXNlIEhpaUxpYiB0byBzdXBwb3J0IFJFU1RfU1RZTEU=?= Date: Thu, 5 Nov 2020 09:42:12 +0800 Message-ID: <002301d6b314$e2016b70$a6044250$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQL0rBfRlVyWH3zy7VT0HmS4zOWWuQG6ibhgAexA5hGnX5rNwA== Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn This patch is to check REST_STYLE flag. I think the commit message may be check REST_STYLE flag. > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+66976+4905953+8761045@groups.io > =B4=FA=B1=ED Abner Chang > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C24=C8=D5 16:21 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Techno= logist) > > =B3=AD=CB=CD: 'Dandan Bi' ; 'Eric Dong' ; > Gao, Liming > =D6=F7=CC=E2: Re: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE >=20 > Sorry, forget to CC reviewers. >=20 > Abner >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Wednesday, November 4, 2020 2:36 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] > > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE > > > > Add REST_STYLE support > > > > Signed-off-by: Jiaxin Wu > > Signed-off-by: Ting Ye > > Signed-off-by: Siyuan Fu > > Signed-off-by: Fan Wang > > Signed-off-by: Abner Chang > > --- > > MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > > b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > > index 564169bc14..57602828fe 100644 > > --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > > @@ -3605,7 +3605,7 @@ HiiCreateCheckBoxOpCode ( > > EFI_IFR_CHECKBOX OpCode; > > UINTN Position; > > > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > > > > ZeroMem (&OpCode, sizeof (OpCode)); > > OpCode.Question.QuestionId =3D QuestionId; > > @@ -3674,7 +3674,7 @@ HiiCreateNumericOpCode ( > > UINTN Position; > > UINTN Length; > > > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > > > > Length =3D 0; > > ZeroMem (&OpCode, sizeof (OpCode)); > > @@ -3773,7 +3773,7 @@ HiiCreateStringOpCode ( > > EFI_IFR_STRING OpCode; > > UINTN Position; > > > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > > > > ZeroMem (&OpCode, sizeof (OpCode)); > > OpCode.Question.Header.Prompt =3D Prompt; > > @@ -3841,7 +3841,7 @@ HiiCreateOneOfOpCode ( > > UINTN Length; > > > > ASSERT (OptionsOpCodeHandle !=3D NULL); > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > > > > ZeroMem (&OpCode, sizeof (OpCode)); > > OpCode.Question.Header.Prompt =3D Prompt; > > @@ -3912,7 +3912,7 @@ HiiCreateOrderedListOpCode ( > > UINTN Position; > > > > ASSERT (OptionsOpCodeHandle !=3D NULL); > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > > > > ZeroMem (&OpCode, sizeof (OpCode)); > > OpCode.Question.Header.Prompt =3D Prompt; > > @@ -4009,7 +4009,7 @@ HiiCreateDateOpCode ( > > EFI_IFR_DATE OpCode; > > UINTN Position; > > > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > > ASSERT ((DateFlags & (~(EFI_QF_DATE_YEAR_SUPPRESS | > > EFI_QF_DATE_MONTH_SUPPRESS | EFI_QF_DATE_DAY_SUPPRESS | > > EFI_QF_DATE_STORAGE))) =3D=3D 0); > > > > ZeroMem (&OpCode, sizeof (OpCode)); > > @@ -4074,7 +4074,7 @@ HiiCreateTimeOpCode ( > > EFI_IFR_TIME OpCode; > > UINTN Position; > > > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > > ASSERT ((TimeFlags & (~(QF_TIME_HOUR_SUPPRESS | > > QF_TIME_MINUTE_SUPPRESS | QF_TIME_SECOND_SUPPRESS | > > QF_TIME_STORAGE))) =3D=3D 0); > > > > ZeroMem (&OpCode, sizeof (OpCode)); > > -- > > 2.17.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20