From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.5589.1604625108271650350
 for <devel@edk2.groups.io>;
 Thu, 05 Nov 2020 17:11:49 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <devel@edk2.groups.io>; Fri, 06 Nov 2020 09:11:41 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Gao, Zhichao'" <zhichao.gao@intel.com>,
	<devel@edk2.groups.io>,
	<zhuenze@byosoft.com.cn>
References: <672cc8963666b2afe09b9ee899cc114e6a220930.1603680168.git.zhuenze@byosoft.com.cn> <00a701d6b17c$9cbc3750$d634a5f0$@byosoft.com.cn> <MWHPR11MB16472BB619454B53B37DA579F6110@MWHPR11MB1647.namprd11.prod.outlook.com>
In-Reply-To: <MWHPR11MB16472BB619454B53B37DA579F6110@MWHPR11MB1647.namprd11.prod.outlook.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBTaGVsbFBrZzpGaXggYnVnIGluIEZpbGVCdWZmZXIuYw==?=
Date: Fri, 6 Nov 2020 09:11:43 +0800
Message-ID: <002401d6b3d9$ca190200$5e4b0600$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGwGd8Jlhm6UHDcQkdGm74Llxj6ywKC9zdTAYkbavOp5x8rEA==
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Create PR https://github.com/tianocore/edk2/pull/1089

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Gao, Zhichao <zhichao.gao@intel.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=883=E6=97=A5=
 13:05
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com=
.cn;
> zhuenze@byosoft.com.cn
> =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuf=
fer.c
>=20
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>=20
> Thanks,
> Zhichao
>=20
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> > Sent: Tuesday, November 3, 2020 9:00 AM
> > To: devel@edk2.groups.io; zhuenze@byosoft.com.cn; Gao, Zhichao
> > <zhichao.gao@intel.com>
> > Cc: gaoliming@byosoft.com.cn
> > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] ShellPkg:Fix bug in =
FileBuffer.c
> >
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66594+4905953+8761045@grou=
ps.io
> > > <bounce+27952+66594+4905953+8761045@groups.io> =E4=BB=A3=E8=A1=A8 En=
ze Zhu
> > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8826=E6=
=97=A5 16:40
> > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuf=
fer.c
> > >
> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2998
> > >
> > > In the function FileBufferCutLine(),set the CutLine pointer to NULL,
> > > The function header specifies that the pointer is valid on a
> > > successful or failed return code.
> > >
> > > Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> > > ---
> > >  ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 +=
+
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > index 5659ec9810..925d910ae2 100644
> > > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > @@ -2767,6 +2767,8 @@ FileBufferCutLine (
> > >    UINTN           Row;
> > >    UINTN           Col;
> > >
> > > +  *CutLine      =3D NULL;
> > > +
> > >    if (FileBuffer.ReadOnly) {
> > >      StatusBarSetStatusString (L"Read Only File Can Not Be Modified"=
);
> > >      return EFI_SUCCESS;
> > > --
> > > 2.27.0.windows.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >=20
> >