public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL
       [not found] <cover.1703048630.git.suqiangx.ren@intel.com>
@ 2023-12-20  5:35 ` SuqiangX Ren
  2023-12-21  1:02   ` 回复: " gaoliming via groups.io
  0 siblings, 1 reply; 4+ messages in thread
From: SuqiangX Ren @ 2023-12-20  5:35 UTC (permalink / raw)
  To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Yi Li

Add the description of EFI_NVDIMM_LABEL_FLAGS_LOCAL to
align with UEFI spec 2.10.

REF: UEFI spec 2.10 Table 13.19.4

Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
 MdePkg/Include/Protocol/NvdimmLabel.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h b/MdePkg/Include/Protocol/NvdimmLabel.h
index e46999a3ab4a..59416f11cb03 100644
--- a/MdePkg/Include/Protocol/NvdimmLabel.h
+++ b/MdePkg/Include/Protocol/NvdimmLabel.h
@@ -108,6 +108,8 @@ typedef struct {
 ///
 /// When set, the complete label set is local to a single NVDIMM Label Storage Area.
 /// When clear, the complete label set is contained on multiple NVDIMM Label Storage Areas.
+/// If NLabel is 1 then setting this flag is optional and it is implied that the
+/// EFI_NVDIMM_LABEL_FLAGS_LOCAL flag is set as the complete label set is local to a single NVDIMM Label Storage Area.
 ///
 #define EFI_NVDIMM_LABEL_FLAGS_LOCAL  0x00000002
 
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112745): https://edk2.groups.io/g/devel/message/112745
Mute This Topic: https://groups.io/mt/103276607/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL
  2023-12-20  5:35 ` [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL SuqiangX Ren
@ 2023-12-21  1:02   ` gaoliming via groups.io
  2024-01-08  7:50     ` Ren, Suqiang
  0 siblings, 1 reply; 4+ messages in thread
From: gaoliming via groups.io @ 2023-12-21  1:02 UTC (permalink / raw)
  To: devel, suqiangx.ren
  Cc: 'Michael D Kinney', 'Zhiguang Liu',
	'Yi Li'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月20日 13:36
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li
> <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of
> EFI_NVDIMM_LABEL_FLAGS_LOCAL
> 
> Add the description of EFI_NVDIMM_LABEL_FLAGS_LOCAL to
> align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 13.19.4
> 
> Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/NvdimmLabel.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h
> b/MdePkg/Include/Protocol/NvdimmLabel.h
> index e46999a3ab4a..59416f11cb03 100644
> --- a/MdePkg/Include/Protocol/NvdimmLabel.h
> +++ b/MdePkg/Include/Protocol/NvdimmLabel.h
> @@ -108,6 +108,8 @@ typedef struct {
>  ///
>  /// When set, the complete label set is local to a single NVDIMM Label
> Storage Area.
>  /// When clear, the complete label set is contained on multiple NVDIMM
> Label Storage Areas.
> +/// If NLabel is 1 then setting this flag is optional and it is implied
that the
> +/// EFI_NVDIMM_LABEL_FLAGS_LOCAL flag is set as the complete label set
> is local to a single NVDIMM Label Storage Area.
>  ///
>  #define EFI_NVDIMM_LABEL_FLAGS_LOCAL  0x00000002
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112788): https://edk2.groups.io/g/devel/message/112788
Mute This Topic: https://groups.io/mt/103292651/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL
  2023-12-21  1:02   ` 回复: " gaoliming via groups.io
@ 2024-01-08  7:50     ` Ren, Suqiang
  2024-01-09  2:02       ` 回复: " gaoliming via groups.io
  0 siblings, 1 reply; 4+ messages in thread
From: Ren, Suqiang @ 2024-01-08  7:50 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io
  Cc: Kinney, Michael D, Liu, Zhiguang, Li, Yi1

Hi Liming,

	Could you please have a check and merge this patch?
	https://github.com/tianocore/edk2/pull/5167


Thanks
Ren, Suqiang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Thursday, December 21, 2023 9:02 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月20日 13:36
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi 
> Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of 
> EFI_NVDIMM_LABEL_FLAGS_LOCAL
> 
> Add the description of EFI_NVDIMM_LABEL_FLAGS_LOCAL to align with UEFI 
> spec 2.10.
> 
> REF: UEFI spec 2.10 Table 13.19.4
> 
> Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/NvdimmLabel.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h
> b/MdePkg/Include/Protocol/NvdimmLabel.h
> index e46999a3ab4a..59416f11cb03 100644
> --- a/MdePkg/Include/Protocol/NvdimmLabel.h
> +++ b/MdePkg/Include/Protocol/NvdimmLabel.h
> @@ -108,6 +108,8 @@ typedef struct {
>  ///
>  /// When set, the complete label set is local to a single NVDIMM 
> Label Storage Area.
>  /// When clear, the complete label set is contained on multiple 
> NVDIMM Label Storage Areas.
> +/// If NLabel is 1 then setting this flag is optional and it is 
> +implied
that the
> +/// EFI_NVDIMM_LABEL_FLAGS_LOCAL flag is set as the complete label 
> +set
> is local to a single NVDIMM Label Storage Area.
>  ///
>  #define EFI_NVDIMM_LABEL_FLAGS_LOCAL  0x00000002
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113368): https://edk2.groups.io/g/devel/message/113368
Mute This Topic: https://groups.io/mt/103593584/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL
  2024-01-08  7:50     ` Ren, Suqiang
@ 2024-01-09  2:02       ` gaoliming via groups.io
  0 siblings, 0 replies; 4+ messages in thread
From: gaoliming via groups.io @ 2024-01-09  2:02 UTC (permalink / raw)
  To: 'Ren, SuqiangX', devel
  Cc: 'Kinney, Michael D', 'Liu, Zhiguang',
	'Li, Yi1'

I just add push label for this PR. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Ren, SuqiangX <suqiangx.ren@intel.com>
> 发送时间: 2024年1月8日 15:50
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> 主题: RE: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of
> EFI_NVDIMM_LABEL_FLAGS_LOCAL
> 
> Hi Liming,
> 
> 	Could you please have a check and merge this patch?
> 	https://github.com/tianocore/edk2/pull/5167
> 
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Thursday, December 21, 2023 9:02 AM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition
> of EFI_NVDIMM_LABEL_FLAGS_LOCAL
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX
> Ren
> > 发送时间: 2023年12月20日 13:36
> > 收件人: devel@edk2.groups.io
> > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi
> > Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of
> > EFI_NVDIMM_LABEL_FLAGS_LOCAL
> >
> > Add the description of EFI_NVDIMM_LABEL_FLAGS_LOCAL to align with
> UEFI
> > spec 2.10.
> >
> > REF: UEFI spec 2.10 Table 13.19.4
> >
> > Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> >  MdePkg/Include/Protocol/NvdimmLabel.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h
> > b/MdePkg/Include/Protocol/NvdimmLabel.h
> > index e46999a3ab4a..59416f11cb03 100644
> > --- a/MdePkg/Include/Protocol/NvdimmLabel.h
> > +++ b/MdePkg/Include/Protocol/NvdimmLabel.h
> > @@ -108,6 +108,8 @@ typedef struct {
> >  ///
> >  /// When set, the complete label set is local to a single NVDIMM
> > Label Storage Area.
> >  /// When clear, the complete label set is contained on multiple
> > NVDIMM Label Storage Areas.
> > +/// If NLabel is 1 then setting this flag is optional and it is
> > +implied
> that the
> > +/// EFI_NVDIMM_LABEL_FLAGS_LOCAL flag is set as the complete label
> > +set
> > is local to a single NVDIMM Label Storage Area.
> >  ///
> >  #define EFI_NVDIMM_LABEL_FLAGS_LOCAL  0x00000002
> >
> > --
> > 2.26.2.windows.1
> >
> >
> >
> > 
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113416): https://edk2.groups.io/g/devel/message/113416
Mute This Topic: https://groups.io/mt/103612986/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-09  2:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1703048630.git.suqiangx.ren@intel.com>
2023-12-20  5:35 ` [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL SuqiangX Ren
2023-12-21  1:02   ` 回复: " gaoliming via groups.io
2024-01-08  7:50     ` Ren, Suqiang
2024-01-09  2:02       ` 回复: " gaoliming via groups.io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox