[edk2-devel] [PATCH v2 0/1]

[edk2-devel] [PATCH v2 0/1]

[Praveen Sankar N via groups.io]

*** BLURB HERE ***

praveensankarn (1):
  Subject: MdePkg:Added new SPCR table stucture members as in
    Rev4.

 .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118148): https://edk2.groups.io/g/devel/message/118148
Mute This Topic: https://groups.io/mt/105690933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[Praveen Sankar N via groups.io]

In SPCR table, 4 structure members have been added newly as per
SPCR table Rev4, which has to be added in
MdePkg/SerialPortConsoleRedirectionTable.h file.

Signed-off-by: Praveen Sankar N praveensankarn@ami.com
Cc: michael.d.kinney@intel.com
Cc: gaoliming@byosoft.com.cn
Cc: zhiguang.liu@intel.com
Cc: Felixp@ami.com
Cc: srinivasanm@ami.com
Cc: sundaresans@ami.com
---
 .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index eb5ae28390..f0001ab137 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -47,7 +47,11 @@ typedef struct {
   UINT8                                     PciFunctionNumber;

   UINT32                                    PciFlags;

   UINT8                                     PciSegment;

-  UINT32                                    Reserved3;

+  UINT32                                    UartClockFrequency;

+  UINT32                                    PreciseBaudRate;

+  UINT16                                    NameSpaceStrLength;

+  UINT16                                    NameSpaceStrOffset;

+  CHAR8                                     NameSpaceString[0];

 } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;



 #pragma pack()

--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118149): https://edk2.groups.io/g/devel/message/118149
Mute This Topic: https://groups.io/mt/105690934/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[gaoliming via groups.io]

Seemly, this is an incompatible change. What's impact with this change?

Thanks
Liming
> -----邮件原件-----
> 发件人: Praveen Sankar N <praveensankarn@ami.com>
> 发送时间: 2024年4月22日 19:26
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan Mani
> <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
> 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> stucture members as in Rev4.
> 
> In SPCR table, 4 structure members have been added newly as per
> SPCR table Rev4, which has to be added in
> MdePkg/SerialPortConsoleRedirectionTable.h file.
> 
> Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> Cc: michael.d.kinney@intel.com
> Cc: gaoliming@byosoft.com.cn
> Cc: zhiguang.liu@intel.com
> Cc: Felixp@ami.com
> Cc: srinivasanm@ami.com
> Cc: sundaresans@ami.com
> ---
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..f0001ab137 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -47,7 +47,11 @@ typedef struct {
>    UINT8                                     PciFunctionNumber;
> 
>    UINT32                                    PciFlags;
> 
>    UINT8                                     PciSegment;
> 
> -  UINT32                                    Reserved3;
> 
> +  UINT32                                    UartClockFrequency;
> 
> +  UINT32                                    PreciseBaudRate;
> 
> +  UINT16
> NameSpaceStrLength;
> 
> +  UINT16
> NameSpaceStrOffset;
> 
> +  CHAR8
> NameSpaceString[0];
> 
>  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> 
> 
> 
>  #pragma pack()
> 
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118140): https://edk2.groups.io/g/devel/message/118140
Mute This Topic: https://groups.io/mt/105689097/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[Praveen Sankar N via groups.io]

Hi Liming,
        I am about to resubmit the patch with the changes in the files SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure from SerialPortConsoleRedirectionTable.h file and these files seemingly initializes the SPCR structure members. So please let me know about your opinion on this and I think you mean the incompatible change as these files are affected with the initial patch.

Thanks,
Praveen Sankar N

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, April 23, 2024 6:47 PM
To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Seemly, this is an incompatible change. What's impact with this change?

Thanks
Liming
> -----邮件原件-----
> 发件人: Praveen Sankar N <praveensankarn@ami.com>
> 发送时间: 2024年4月22日 19:26
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan
> Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
> 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> stucture members as in Rev4.
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Rev4, which has to be added in
> MdePkg/SerialPortConsoleRedirectionTable.h file.
>
> Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> Cc: michael.d.kinney@intel.com
> Cc: gaoliming@byosoft.com.cn
> Cc: zhiguang.liu@intel.com
> Cc: Felixp@ami.com
> Cc: srinivasanm@ami.com
> Cc: sundaresans@ami.com
> ---
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..f0001ab137 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -47,7 +47,11 @@ typedef struct {
>    UINT8                                     PciFunctionNumber;
>
>    UINT32                                    PciFlags;
>
>    UINT8                                     PciSegment;
>
> -  UINT32                                    Reserved3;
>
> +  UINT32                                    UartClockFrequency;
>
> +  UINT32                                    PreciseBaudRate;
>
> +  UINT16
> NameSpaceStrLength;
>
> +  UINT16
> NameSpaceStrOffset;
>
> +  CHAR8
> NameSpaceString[0];
>
>  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
>  #pragma pack()
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=


-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118351): https://edk2.groups.io/g/devel/message/118351
Mute This Topic: https://groups.io/mt/105689097/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[gaoliming via groups.io]

Praveen:
  I want to know what will happen if the platform doesn't make changes with the updated table. 

  According to its impact, we can make direction how and when to merge this patch. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Praveen
> Sankar N via groups.io
> 发送时间: 2024年4月26日 12:58
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added new SPCR table stucture members as in Rev4.
> 
> Hi Liming,
>         I am about to resubmit the patch with the changes in the files
> SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure from
> SerialPortConsoleRedirectionTable.h file and these files seemingly initializes
> the SPCR structure members. So please let me know about your opinion on
> this and I think you mean the incompatible change as these files are affected
> with the initial patch.
> 
> Thanks,
> Praveen Sankar N
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, April 23, 2024 6:47 PM
> To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added
> new SPCR table stucture members as in Rev4.
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Seemly, this is an incompatible change. What's impact with this change?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Praveen Sankar N <praveensankarn@ami.com>
> > 发送时间: 2024年4月22日 19:26
> > 收件人: devel@edk2.groups.io
> > 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan
> > Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
> > 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> > stucture members as in Rev4.
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Rev4, which has to be added in
> > MdePkg/SerialPortConsoleRedirectionTable.h file.
> >
> > Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> > Cc: michael.d.kinney@intel.com
> > Cc: gaoliming@byosoft.com.cn
> > Cc: zhiguang.liu@intel.com
> > Cc: Felixp@ami.com
> > Cc: srinivasanm@ami.com
> > Cc: sundaresans@ami.com
> > ---
> >  .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index eb5ae28390..f0001ab137 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -47,7 +47,11 @@ typedef struct {
> >    UINT8
> PciFunctionNumber;
> >
> >    UINT32                                    PciFlags;
> >
> >    UINT8                                     PciSegment;
> >
> > -  UINT32                                    Reserved3;
> >
> > +  UINT32
> UartClockFrequency;
> >
> > +  UINT32                                    PreciseBaudRate;
> >
> > +  UINT16
> > NameSpaceStrLength;
> >
> > +  UINT16
> > NameSpaceStrOffset;
> >
> > +  CHAR8
> > NameSpaceString[0];
> >
> >  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> >  #pragma pack()
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
> > you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply e-mail
> > or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118359): https://edk2.groups.io/g/devel/message/118359
Mute This Topic: https://groups.io/mt/105793070/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[Praveen Sankar N via groups.io]

Hi Liming,
      We are updating the ACPI tables with newer revision released recently and SPCR table has its revision 4 upgradation. So, we updated the SPCR table to revision 4, tested in our AMI BIOS environment and validated Windows Server EMS functionality.

Thanks,
Praveen Sankar

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Monday, April 29, 2024 6:27 AM
To: devel@edk2.groups.io; Praveen Sankar N <praveensankarn@ami.com>
Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Praveen:
  I want to know what will happen if the platform doesn't make changes with the updated table.

  According to its impact, we can make direction how and when to merge this patch.

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Praveen Sankar N
> via groups.io
> 发送时间: 2024年4月26日 12:58
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added
> new SPCR table stucture members as in Rev4.
>
> Hi Liming,
>         I am about to resubmit the patch with the changes in the files
> SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure
> from SerialPortConsoleRedirectionTable.h file and these files
> seemingly initializes the SPCR structure members. So please let me
> know about your opinion on this and I think you mean the incompatible
> change as these files are affected with the initial patch.
>
> Thanks,
> Praveen Sankar N
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, April 23, 2024 6:47 PM
> To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added
> new SPCR table stucture members as in Rev4.
>
>
> **CAUTION: The e-mail below is from an external source. Please
> exercise caution before opening attachments, clicking links, or
> following guidance.**
>
> Seemly, this is an incompatible change. What's impact with this change?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Praveen Sankar N <praveensankarn@ami.com>
> > 发送时间: 2024年4月22日 19:26
> > 收件人: devel@edk2.groups.io
> > 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan
> > Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
> > 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> > stucture members as in Rev4.
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Rev4, which has to be added in
> > MdePkg/SerialPortConsoleRedirectionTable.h file.
> >
> > Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> > Cc: michael.d.kinney@intel.com
> > Cc: gaoliming@byosoft.com.cn
> > Cc: zhiguang.liu@intel.com
> > Cc: Felixp@ami.com
> > Cc: srinivasanm@ami.com
> > Cc: sundaresans@ami.com
> > ---
> >  .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > index eb5ae28390..f0001ab137 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > @@ -47,7 +47,11 @@ typedef struct {
> >    UINT8
> PciFunctionNumber;
> >
> >    UINT32                                    PciFlags;
> >
> >    UINT8                                     PciSegment;
> >
> > -  UINT32                                    Reserved3;
> >
> > +  UINT32
> UartClockFrequency;
> >
> > +  UINT32                                    PreciseBaudRate;
> >
> > +  UINT16
> > NameSpaceStrLength;
> >
> > +  UINT16
> > NameSpaceStrOffset;
> >
> > +  CHAR8
> > NameSpaceString[0];
> >
> >  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> >  #pragma pack()
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or
> > by
> their
> > designee. If the reader of this message is not the intended
> > recipient, you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply
> > e-mail or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
>
>
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not
> the intended recipient, you are on notice that any distribution of
> this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
>
>
> 
>



-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118390): https://edk2.groups.io/g/devel/message/118390
Mute This Topic: https://groups.io/mt/105793070/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[gaoliming via groups.io]

Praveen:
  To be compatible, I would suggest to follow new ACPI version definition to add new structure for SPCR table version 4, and also need to define version 4 macro. 
  
  For example, 

#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION_4  0x04

EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_V4

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Praveen
> Sankar N via groups.io
> 发送时间: 2024年4月29日 18:58
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> 主题: Re: 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added new SPCR table stucture members as in Rev4.
> 
> Hi Liming,
>       We are updating the ACPI tables with newer revision released recently
> and SPCR table has its revision 4 upgradation. So, we updated the SPCR table
> to revision 4, tested in our AMI BIOS environment and validated Windows
> Server EMS functionality.
> 
> Thanks,
> Praveen Sankar
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, April 29, 2024 6:27 AM
> To: devel@edk2.groups.io; Praveen Sankar N <praveensankarn@ami.com>
> Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject:
> [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Praveen:
>   I want to know what will happen if the platform doesn't make changes with
> the updated table.
> 
>   According to its impact, we can make direction how and when to merge
> this patch.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Praveen
> Sankar N
> > via groups.io
> > 发送时间: 2024年4月26日 12:58
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> > <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan
> S
> > <sundaresans@ami.com>
> > 主题: Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added
> > new SPCR table stucture members as in Rev4.
> >
> > Hi Liming,
> >         I am about to resubmit the patch with the changes in the files
> > SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure
> > from SerialPortConsoleRedirectionTable.h file and these files
> > seemingly initializes the SPCR structure members. So please let me
> > know about your opinion on this and I think you mean the incompatible
> > change as these files are affected with the initial patch.
> >
> > Thanks,
> > Praveen Sankar N
> >
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Tuesday, April 23, 2024 6:47 PM
> > To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
> > Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov
> > <Felixp@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Sundaresan
> S
> > <sundaresans@ami.com>
> > Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added
> > new SPCR table stucture members as in Rev4.
> >
> >
> > **CAUTION: The e-mail below is from an external source. Please
> > exercise caution before opening attachments, clicking links, or
> > following guidance.**
> >
> > Seemly, this is an incompatible change. What's impact with this change?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Praveen Sankar N <praveensankarn@ami.com>
> > > 发送时间: 2024年4月22日 19:26
> > > 收件人: devel@edk2.groups.io
> > > 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > > zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Srinivasan
> > > Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>
> > > 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> > > stucture members as in Rev4.
> > >
> > > In SPCR table, 4 structure members have been added newly as per SPCR
> > > table Rev4, which has to be added in
> > > MdePkg/SerialPortConsoleRedirectionTable.h file.
> > >
> > > Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> > > Cc: michael.d.kinney@intel.com
> > > Cc: gaoliming@byosoft.com.cn
> > > Cc: zhiguang.liu@intel.com
> > > Cc: Felixp@ami.com
> > > Cc: srinivasanm@ami.com
> > > Cc: sundaresans@ami.com
> > > ---
> > >  .../IndustryStandard/SerialPortConsoleRedirectionTable.h    | 6
> +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > index eb5ae28390..f0001ab137 100644
> > > ---
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > +++
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > @@ -47,7 +47,11 @@ typedef struct {
> > >    UINT8
> > PciFunctionNumber;
> > >
> > >    UINT32                                    PciFlags;
> > >
> > >    UINT8                                     PciSegment;
> > >
> > > -  UINT32                                    Reserved3;
> > >
> > > +  UINT32
> > UartClockFrequency;
> > >
> > > +  UINT32                                    PreciseBaudRate;
> > >
> > > +  UINT16
> > > NameSpaceStrLength;
> > >
> > > +  UINT16
> > > NameSpaceStrOffset;
> > >
> > > +  CHAR8
> > > NameSpaceString[0];
> > >
> > >  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> > >
> > >
> > >
> > >  #pragma pack()
> > >
> > > --
> > > 2.38.1.windows.1
> > > -The information contained in this message may be confidential and
> > > proprietary to American Megatrends (AMI). This communication is
> > > intended
> > to
> > > be read only by the individual or entity to whom it is addressed or
> > > by
> > their
> > > designee. If the reader of this message is not the intended
> > > recipient, you
> > are
> > > on notice that any distribution of this message, in any form, is
> > > strictly prohibited. Please promptly notify the sender by reply
> > > e-mail or by
> > telephone
> > > at 770-246-8600, and then delete or destroy all copies of the
> > transmission=
> >
> >
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended to be read only by the individual or entity to whom it is
> > addressed or by their designee. If the reader of this message is not
> > the intended recipient, you are on notice that any distribution of
> > this message, in any form, is strictly prohibited. Please promptly
> > notify the sender by reply e-mail or by telephone at 770-246-8600, and then
> delete or destroy all copies of the transmission.
> >
> >
> >
> >
> 
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118399): https://edk2.groups.io/g/devel/message/118399
Mute This Topic: https://groups.io/mt/105814254/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-