From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Sheng, W'" <w.sheng@intel.com>,
"'Kinney, Michael D'" <michael.d.kinney@intel.com>,
<devel@edk2.groups.io>
Cc: "'Liu, Zhiguang'" <zhiguang.liu@intel.com>,
"'Yao, Jiewen'" <jiewen.yao@intel.com>,
"'Andrew Fish'" <afish@apple.com>,
"'Laszlo Ersek'" <lersek@redhat.com>,
"'Feng, Roger'" <roger.feng@intel.com>
Subject: 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
Date: Tue, 2 Feb 2021 11:50:59 +0800 [thread overview]
Message-ID: <002501d6f916$9e7cbce0$db7636a0$@byosoft.com.cn> (raw)
In-Reply-To: <CY4PR11MB19286F87FF3C6807946181AEE1B59@CY4PR11MB1928.namprd11.prod.outlook.com>
Sheng:
Can you check nasm version in ubuntu-18.04 and latest ubuntu OS? Those Oss are used in open CI.
Thanks
Liming
> -----邮件原件-----
> 发件人: Sheng, W <w.sheng@intel.com>
> 发送时间: 2021年2月2日 11:39
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; devel@edk2.groups.io
> 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek'
> <lersek@redhat.com>; Feng, Roger <roger.feng@intel.com>
> 主题: RE: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
>
> Hi Mike, Liming,
> The latest NASM version is version 2.15.05.
> The CET instructions is supported since NASM version 2.15.01, it is released at
> 2020-06-27.
> Do you think we need to request everyone to update the NASM tool now?
> Or could I still use macros with DB for CET instructions in my patch ?
> BR
> Sheng Wei
>
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: 2021年2月2日 10:44
> > To: Kinney, Michael D <michael.d.kinney@intel.com>; Sheng, W
> > <w.sheng@intel.com>; devel@edk2.groups.io
> > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek'
> > <lersek@redhat.com>
> > Subject: 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> >
> > Mike and Sheng:
> > Linux or Mac OS includes the pre-built nasm. Their nasm version may be
> old.
> > Can you evaluate the impact to update nasm version?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > > 发送时间: 2021年1月30日 1:23
> > > 收件人: Sheng, W <w.sheng@intel.com>; devel@edk2.groups.io; Kinney,
> > > Michael D <michael.d.kinney@intel.com>
> > > 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> > > 主题: RE: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> > >
> > > Sheng,
> > >
> > > The following version of the NASM documentation shows support for
> > > these instructions.
> > >
> > > https://nasm.us/doc/nasmdocb.html
> > >
> > > Do we need to increase the min NASM version requirements for EDK II to
> > > avoid adding macros with DB?
> > >
> > > Thanks,
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Sheng, W <w.sheng@intel.com>
> > > > Sent: Thursday, January 28, 2021 6:35 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > > <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> > > > Subject: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> > > >
> > > > This is to add instruction SAVEPREVSSP, CLRSSBSY and RSTORSSP_RAX in
> > > Nasm,
> > > > because these instructions are not supported yet.
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3192
> > > >
> > > > Signed-off-by: Sheng Wei <w.sheng@intel.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > > ---
> > > > MdePkg/Include/Ia32/Nasm.inc | 14 +++++++++++++-
> > > > MdePkg/Include/X64/Nasm.inc | 14 +++++++++++++-
> > > > 2 files changed, 26 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/MdePkg/Include/Ia32/Nasm.inc
> > > b/MdePkg/Include/Ia32/Nasm.inc
> > > > index 31ce861f1e..9c1b7796ea 100644
> > > > --- a/MdePkg/Include/Ia32/Nasm.inc
> > > > +++ b/MdePkg/Include/Ia32/Nasm.inc
> > > > @@ -1,6 +1,6 @@
> > > >
> > > > ;-------------------------------------------------------------------
> > > > -----------
> > > > ;
> > > > -; Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > > +; Copyright (c) 2019 - 2021, Intel Corporation. All rights
> > > > +reserved.<BR>
> > > > ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; Abstract:
> > > > @@ -20,3 +20,15 @@
> > > > %macro INCSSP_EAX 0
> > > > DB 0xF3, 0x0F, 0xAE, 0xE8
> > > > %endmacro
> > > > +
> > > > +%macro SAVEPREVSSP 0
> > > > + DB 0xF3, 0x0F, 0x01, 0xEA
> > > > +%endmacro
> > > > +
> > > > +%macro CLRSSBSY_EAX 0
> > > > + DB 0x67, 0xF3, 0x0F, 0xAE, 0x30 %endmacro
> > > > +
> > > > +%macro RSTORSSP_EAX 0
> > > > + DB 0x67, 0xF3, 0x0F, 0x01, 0x28 %endmacro
> > > > diff --git a/MdePkg/Include/X64/Nasm.inc
> > > b/MdePkg/Include/X64/Nasm.inc
> > > > index 42412735ea..c5189982bb 100644
> > > > --- a/MdePkg/Include/X64/Nasm.inc
> > > > +++ b/MdePkg/Include/X64/Nasm.inc
> > > > @@ -1,6 +1,6 @@
> > > >
> > > > ;-------------------------------------------------------------------
> > > > -----------
> > > > ;
> > > > -; Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > > +; Copyright (c) 2019 - 2021, Intel Corporation. All rights
> > > > +reserved.<BR>
> > > > ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; Abstract:
> > > > @@ -20,3 +20,15 @@
> > > > %macro INCSSP_RAX 0
> > > > DB 0xF3, 0x48, 0x0F, 0xAE, 0xE8 %endmacro
> > > > +
> > > > +%macro SAVEPREVSSP 0
> > > > + DB 0xF3, 0x0F, 0x01, 0xEA
> > > > +%endmacro
> > > > +
> > > > +%macro CLRSSBSY_RAX 0
> > > > + DB 0xF3, 0x0F, 0xAE, 0x30
> > > > +%endmacro
> > > > +
> > > > +%macro RSTORSSP_RAX 0
> > > > + DB 0xF3, 0x0F, 0x01, 0x28
> > > > +%endmacro
> > > > --
> > > > 2.16.2.windows.1
> >
> >
next prev parent reply other threads:[~2021-02-02 3:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 2:34 [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc Sheng Wei
2021-01-29 6:35 ` Yao, Jiewen
2021-01-29 8:32 ` Sheng Wei
2021-01-29 9:20 ` Yao, Jiewen
2021-01-29 17:22 ` Michael D Kinney
2021-01-29 19:03 ` Bret Barkelew
2021-02-02 2:43 ` 回复: " gaoliming
2021-02-02 3:38 ` Sheng Wei
2021-02-02 3:50 ` gaoliming [this message]
2021-02-02 15:23 ` [edk2-devel] 回复: " Michael D Kinney
2021-02-02 15:21 ` Michael D Kinney
2021-02-02 16:01 ` Laszlo Ersek
2021-02-03 0:06 ` Sheng Wei
2021-02-03 2:01 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501d6f916$9e7cbce0$db7636a0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox