From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.3591.1623381808492297431 for ; Thu, 10 Jun 2021 20:23:28 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 11 Jun 2021 11:23:24 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Sean Brogan'" , "'Bret Barkelew'" , "'Michael D Kinney'" References: <20210610014733.1267-1-kuqin12@gmail.com> <20210610014733.1267-2-kuqin12@gmail.com> In-Reply-To: <20210610014733.1267-2-kuqin12@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gUHl0b29sOiBTcGVsbENoZWNrOiBGaXggaW5jb3JyZWN0IGZpbGUgbWFzayBhY3Jvc3MgcGFja2FnZSBtYXRyaWNlcw==?= Date: Fri, 11 Jun 2021 11:23:27 +0800 Message-ID: <002601d75e71$24d42fc0$6e7c8f40$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIO7ze0Kmey0yeI1P6KyK4Uz5Ta+gKXPe7wqopJ2+A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Kun Qin > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA6=D4=C210=C8=D5 9:48 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Sean Brogan ; Bret Barkelew > ; Michael D Kinney > ; Liming Gao > =D6=F7=CC=E2: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorr= ect file mask > across package matrices >=20 > From: Sean Brogan >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3443 >=20 > Existing implementation could modify class global data that causes > potential incorrect file mask to be used for execution of plugin. >=20 > This change switches class variable to be tuple so that it cannot be > accidently modified. Local usage of STANDARD_PLUGIN_DEFINED_PATHS is > also > changed to copy to new list before modification. >=20 > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao >=20 > Signed-off-by: Sean Brogan > --- > .pytool/Plugin/SpellCheck/SpellCheck.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py > b/.pytool/Plugin/SpellCheck/SpellCheck.py > index 43365441b91c..9ad57632a6e8 100644 > --- a/.pytool/Plugin/SpellCheck/SpellCheck.py > +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py > @@ -37,12 +37,12 @@ class SpellCheck(ICiBuildPlugin): > # > # A package can remove any of these using IgnoreStandardPaths > # > - STANDARD_PLUGIN_DEFINED_PATHS =3D ["*.c", "*.h", > + STANDARD_PLUGIN_DEFINED_PATHS =3D ("*.c", "*.h", > "*.nasm", "*.asm", "*.masm", > "*.s", > "*.asl", > "*.dsc", "*.dec", "*.fdf", > "*.inf", > "*.md", "*.txt" > - ] > + ) >=20 > def GetTestName(self, packagename: str, environment: VarDict) -> > tuple: > """ Provide the testcase name and classname for use in reportin= g > @@ -107,7 +107,8 @@ class SpellCheck(ICiBuildPlugin): > version_aggregator.GetVersionAggregator().ReportVersion( > "CSpell", cspell_version, > version_aggregator.VersionTypes.INFO) >=20 > - package_relative_paths_to_spell_check =3D > SpellCheck.STANDARD_PLUGIN_DEFINED_PATHS > + # copy the default as a list > + package_relative_paths_to_spell_check =3D > list(SpellCheck.STANDARD_PLUGIN_DEFINED_PATHS) >=20 > # > # Allow the ci.yaml to remove any of the above standard paths > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20