From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.6604.1609206359360481566 for ; Mon, 28 Dec 2020 17:46:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 29 Dec 2020 09:45:57 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Ray Ni'" , "'Hao A Wu'" References: <20201228082610.2565-1-heng.luo@intel.com> In-Reply-To: <20201228082610.2565-1-heng.luo@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMl0gTWRlUGtnOiBEZWZpbmUgc3RydWN0dXJlcyBmb3IgUmVzaXphYmxlIEJBUiBDYXBhYmlsaXR5?= Date: Tue, 29 Dec 2020 09:45:58 +0800 Message-ID: <002701d6dd84$5b140ab0$113c2010$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJ169Fiagxv8m4i58vN8I54gQKFq6jPMO5g Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-language: zh-cn Heng: This is the incompatible change. Have you evaluated its impact in Edk2 = and Edk2Platforms? Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+69477+4905953+8761045@groups.io > =B4=FA=B1=ED Heng Luo > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA12=D4=C228=C8=D5 16:26 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Ray Ni ; Hao A Wu > =D6=F7=CC=E2: [edk2-devel] [PATCH 1/2] MdePkg: Define structures for = Resizable BAR > Capability >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3138 >=20 > Define structures for Resizable BAR Capability in > MdePkg/Include/IndustryStandard/PciExpress21.h, > Change ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > to use new structures. >=20 > Cc: Ray Ni > Cc: Hao A Wu > Signed-off-by: Heng Luo > --- > MdePkg/Include/IndustryStandard/PciExpress21.h | 30 > +++++++++++++++++++++++++----- > ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 6 +++--- > 2 files changed, 28 insertions(+), 8 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h > b/MdePkg/Include/IndustryStandard/PciExpress21.h > index 2c07cb560e..b7629444eb 100644 > --- a/MdePkg/Include/IndustryStandard/PciExpress21.h > +++ b/MdePkg/Include/IndustryStandard/PciExpress21.h > @@ -1,7 +1,7 @@ > /** @file >=20 > Support for the latest PCI standard. >=20 >=20 >=20 > - Copyright (c) 2006 - 2018, Intel Corporation. All rights = reserved.
>=20 > + Copyright (c) 2006 - 2020, Intel Corporation. All rights = reserved.
>=20 > (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > @@ -632,10 +632,30 @@ typedef struct { > #define PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_ID > 0x0015 >=20 > #define PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_VER1 0x1 >=20 >=20 >=20 > +typedef union { >=20 > + struct { >=20 > + UINT32 Reserved:4; >=20 > + UINT32 BarSizeCapability:28; >=20 > + } Bits; >=20 > + UINT32 Uint32; >=20 > +} PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CAPABILITY; >=20 > + >=20 > + >=20 > +typedef union { >=20 > + struct { >=20 > + UINT32 BarIndex:3; >=20 > + UINT32 Reserved:2; >=20 > + UINT32 ResizableBarNumber:3; >=20 > + UINT32 BarSize:6; >=20 > + UINT32 Reserved2:2; >=20 > + UINT32 BarSizeCapability:16; >=20 > + } Bits; >=20 > + UINT32 Uint32; >=20 > +} PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CONTROL; >=20 > + >=20 > typedef struct { >=20 > - UINT32 > ResizableBarCapability; >=20 > - UINT16 > ResizableBarControl; >=20 > - UINT16 > Reserved; >=20 > + PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CAPABILITY > ResizableBarCapability; >=20 > + PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CONTROL > ResizableBarControl; >=20 > } PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_ENTRY; >=20 >=20 >=20 > typedef struct { >=20 > @@ -643,7 +663,7 @@ typedef struct { > PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_ENTRY > Capability[1]; >=20 > } PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR; >=20 >=20 >=20 > -#define GET_NUMBER_RESIZABLE_BARS(x) > (((x->Capability[0].ResizableBarControl) & 0xE0) >> 5) >=20 > +#define GET_NUMBER_RESIZABLE_BARS(x) > (x->Capability[0].ResizableBarControl.Bits.ResizableBarNumber) >=20 >=20 >=20 > #define PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_ID > 0x000E >=20 > #define PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_VER1 0x1 >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > index 3e138188ce..5077d56fed 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > @@ -1,7 +1,7 @@ > /** @file >=20 > Main file for Pci shell Debug1 function. >=20 >=20 >=20 > - Copyright (c) 2005 - 2019, Intel Corporation. All rights = reserved.
>=20 > + Copyright (c) 2005 - 2020, Intel Corporation. All rights = reserved.
>=20 > (C) Copyright 2013-2015 Hewlett-Packard Development Company, > L.P.
>=20 > (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -5534,8 +5534,8 @@ > PrintInterpretedExtendedCompatibilityResizeableBar ( > STRING_TOKEN (STR_PCI_EXT_CAP_RESIZE_BAR), >=20 > gShellDebug1HiiHandle, >=20 > ItemCount+1, >=20 > - Header->Capability[ItemCount].ResizableBarCapability, >=20 > - Header->Capability[ItemCount].ResizableBarControl >=20 > + Header->Capability[ItemCount].ResizableBarCapability.Uint32, >=20 > + Header->Capability[ItemCount].ResizableBarControl.Uint32 >=20 > ); >=20 > } >=20 >=20 >=20 > -- > 2.24.0.windows.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#69477): = https://edk2.groups.io/g/devel/message/69477 > Mute This Topic: https://groups.io/mt/79265864/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20