From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <Xiaolu.jiang@intel.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.
Date: Mon, 29 Nov 2021 13:04:38 +0800 [thread overview]
Message-ID: <002701d7e4de$9c77d290$d56777b0$@byosoft.com.cn> (raw)
In-Reply-To: <20211129021303.2199-1-xiaolu.jiang@intel.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Xiaolu.Jiang
> 发送时间: 2021年11月29日 10:13
> 收件人: devel@edk2.groups.io
> 抄送: Xiaolu.Jiang <xiaolu.jiang@intel.com>; Bob Feng
> <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei
> Chen <yuwei.chen@intel.com>
> 主题: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for
> support more PCD value.
>
> Currently the PCD Value only support 13 Guid,When use more 13 pcd will
> cause the build tool fail,
> Need calculate the required memory,then allocate it.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3718
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
>
> Signed-off-by: Xiaolu Jiang <xiaolu.jiang@intel.com>
> ---
> BaseTools/Source/C/DevicePath/DevicePath.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/DevicePath/DevicePath.c
> b/BaseTools/Source/C/DevicePath/DevicePath.c
> index c4d224ed61..ed19eb52f6 100644
> --- a/BaseTools/Source/C/DevicePath/DevicePath.c
> +++ b/BaseTools/Source/C/DevicePath/DevicePath.c
> @@ -170,7 +170,7 @@ int main(int argc, CHAR8 *argv[])
> fprintf(stderr, "Invalid option value, Device Path can't be NULL");
>
> return STATUS_ERROR;
>
> }
>
> - Str16 = (CHAR16 *)malloc(1024);
>
> + Str16 = (CHAR16 *)malloc((strlen (Str) + 1) * sizeof (CHAR16));
>
> if (Str16 == NULL) {
>
> fprintf(stderr, "Resource, memory cannot be allocated");
>
> return STATUS_ERROR;
>
> --
> 2.30.2.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#84123): https://edk2.groups.io/g/devel/message/84123
> Mute This Topic: https://groups.io/mt/87369900/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
next prev parent reply other threads:[~2021-11-29 5:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 2:13 [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value Xiaolu.Jiang
2021-11-29 5:04 ` gaoliming [this message]
2021-12-09 0:10 ` Bob Feng
-- strict thread matches above, loose matches on Subject: below --
2021-11-16 1:42 Xiaolu.jiang
2021-11-24 15:01 ` 回复: " gaoliming
[not found] <20211106035056.183-1-xiaolu.jiang@intel.com>
2021-11-08 1:14 ` gaoliming
2021-11-08 1:24 ` Jiang, Xiaolu
2021-11-08 2:26 ` Jiang, Xiaolu
2021-11-08 3:17 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701d7e4de$9c77d290$d56777b0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox