From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <walon.li@hpe.com>
Cc: <sunnywang@hpe.com>, <lersek@redhat.com>, <ray.ni@intel.com>,
<hao.a.wu@intel.com>
Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder
Date: Fri, 19 Feb 2021 08:58:40 +0800 [thread overview]
Message-ID: <002801d7065a$5d81f420$1885dc60$@byosoft.com.cn> (raw)
In-Reply-To: <20210218032611.1594-1-walon.li@hpe.com>
Walon:
Can you specify the detail reason why BootManagerMenu should be placed at
end of BootOrder?
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+71766+4905953+8761045@groups.io
> <bounce+27952+71766+4905953+8761045@groups.io> 代表 Li, Walon
> 发送时间: 2021年2月18日 11:26
> 收件人: devel@edk2.groups.io
> 抄送: walon.li@hpe.com; sunnywang@hpe.com; lersek@redhat.com;
> ray.ni@intel.com; hao.a.wu@intel.com
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put
> BootMenu at the end of BootOrder
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135
>
> When Boot Menu does not exist in the BootOrder,
> BmRegisterBootManagerMenu
> will create one into list. However, it should be put at the "end" of
> BootOrder instead of "start" of BootOrder. Replace 0 by -1 to adjust
> order of load options.
>
> Signed-off-by: Walon Li <walon.li@hpe.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index aff620ad52..26d1fb0ea0 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -2505,7 +2505,7 @@ BmRegisterBootManagerMenu (
> EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount);
>
> );
>
>
>
> - return EfiBootManagerAddLoadOptionVariable (BootOption, 0);
>
> + return EfiBootManagerAddLoadOptionVariable (BootOption, (UINTN) -1));
>
> }
>
>
>
> /**
>
> --
> 2.23.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#71766): https://edk2.groups.io/g/devel/message/71766
> Mute This Topic: https://groups.io/mt/80721971/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
next prev parent reply other threads:[~2021-02-19 0:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 3:26 [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder Li, Walon
2021-02-19 0:58 ` gaoliming [this message]
2021-02-19 1:33 ` [edk2-devel] " Li, Walon
2021-02-19 15:52 ` Laszlo Ersek
2021-02-20 5:43 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002801d7065a$5d81f420$1885dc60$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox