From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <michael.kubacki@outlook.com>
Cc: "'Chasel Chiu'" <chasel.chiu@intel.com>,
"'Nate DeSimone'" <nathaniel.l.desimone@intel.com>,
"'Eric Dong'" <eric.dong@intel.com>
Subject: 回复: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency
Date: Tue, 27 Oct 2020 14:22:03 +0800 [thread overview]
Message-ID: <002901d6ac29$7d4133b0$77c39b10$@byosoft.com.cn> (raw)
In-Reply-To: <DM5PR07MB343567DB39213E60D9BAAE9FE9190@DM5PR07MB3435.namprd07.prod.outlook.com>
This change cleans up the source code. It is good.
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: bounce+27952+66610+4905953+8761045@groups.io
> <bounce+27952+66610+4905953+8761045@groups.io> 代表 Michael
> Kubacki
> 发送时间: 2020年10月27日 4:04
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>
> 主题: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove
> PlatformInitPreMem ReportFvLib dependency
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> PlatformInitPreMem does not actually use the ReportFvLib API. This
> change removes the library dependency in PlatformInitPreMem.inf so
> platforms using this module with a custom BoardInitLib are not
> forced to link a ReportFvLib.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>
>
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreM
> em.c | 1 -
>
>
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreM
> em.inf | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
> index 48cbe0dfbec2..6519fdd04259 100644
> ---
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
> +++
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
> @@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/TimerLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/PeiServicesLib.h>
> -#include <Library/ReportFvLib.h>
> #include <Ppi/ReadOnlyVariable2.h>
> #include <Ppi/MemoryDiscovered.h>
> #include <Ppi/FirmwareVolumeInfo.h>
> diff --git
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> index 8e828ff2ac4b..e37bcba56085 100644
> ---
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> +++
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> @@ -24,7 +24,6 @@ [LibraryClasses]
> MemoryAllocationLib
> PeimEntryPoint
> PeiServicesLib
> - ReportFvLib
> TestPointCheckLib
> TimerLib
> SetCacheMtrrLib
> --
> 2.28.0.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2020-10-27 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 20:03 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency Michael Kubacki
2020-10-27 6:22 ` gaoliming [this message]
2020-10-27 22:50 ` Nate DeSimone
2020-10-29 21:32 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002901d6ac29$7d4133b0$77c39b10$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox