[edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency
@ 2020-10-26 20:03 Michael Kubacki
  2020-10-27  6:22 ` 回复: [edk2-devel] " gaoliming
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael Kubacki @ 2020-10-26 20:03 UTC (permalink / raw)
  To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong

From: Michael Kubacki <michael.kubacki@microsoft.com>

PlatformInitPreMem does not actually use the ReportFvLib API. This
change removes the library dependency in PlatformInitPreMem.inf so
platforms using this module with a custom BoardInitLib are not
forced to link a ReportFvLib.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c   | 1 -
 Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
index 48cbe0dfbec2..6519fdd04259 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
@@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/TimerLib.h>
 #include <Library/BaseMemoryLib.h>
 #include <Library/PeiServicesLib.h>
-#include <Library/ReportFvLib.h>
 #include <Ppi/ReadOnlyVariable2.h>
 #include <Ppi/MemoryDiscovered.h>
 #include <Ppi/FirmwareVolumeInfo.h>
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
index 8e828ff2ac4b..e37bcba56085 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
@@ -24,7 +24,6 @@ [LibraryClasses]
   MemoryAllocationLib
   PeimEntryPoint
   PeiServicesLib
-  ReportFvLib
   TestPointCheckLib
   TimerLib
   SetCacheMtrrLib
-- 
2.28.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency
  2020-10-26 20:03 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency Michael Kubacki
@ 2020-10-27  6:22 ` gaoliming
  2020-10-27 22:50 ` Nate DeSimone
  2020-10-29 21:32 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2020-10-27  6:22 UTC (permalink / raw)
  To: devel, michael.kubacki
  Cc: 'Chasel Chiu', 'Nate DeSimone',
	'Eric Dong'

This change cleans up the source code. It is good. 

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: bounce+27952+66610+4905953+8761045@groups.io
> <bounce+27952+66610+4905953+8761045@groups.io> 代表 Michael
> Kubacki
> 发送时间: 2020年10月27日 4:04
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>
> 主题: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove
> PlatformInitPreMem ReportFvLib dependency
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> PlatformInitPreMem does not actually use the ReportFvLib API. This
> change removes the library dependency in PlatformInitPreMem.inf so
> platforms using this module with a custom BoardInitLib are not
> forced to link a ReportFvLib.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> 
>
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreM
> em.c   | 1 -
> 
>
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreM
> em.inf | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
> index 48cbe0dfbec2..6519fdd04259 100644
> ---
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
> +++
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c
> @@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include <Library/TimerLib.h>
>  #include <Library/BaseMemoryLib.h>
>  #include <Library/PeiServicesLib.h>
> -#include <Library/ReportFvLib.h>
>  #include <Ppi/ReadOnlyVariable2.h>
>  #include <Ppi/MemoryDiscovered.h>
>  #include <Ppi/FirmwareVolumeInfo.h>
> diff --git
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> index 8e828ff2ac4b..e37bcba56085 100644
> ---
>
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> +++
>
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> @@ -24,7 +24,6 @@ [LibraryClasses]
>    MemoryAllocationLib
>    PeimEntryPoint
>    PeiServicesLib
> -  ReportFvLib
>    TestPointCheckLib
>    TimerLib
>    SetCacheMtrrLib
> --
> 2.28.0.windows.1
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency
  2020-10-26 20:03 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency Michael Kubacki
  2020-10-27  6:22 ` 回复: [edk2-devel] " gaoliming
@ 2020-10-27 22:50 ` Nate DeSimone
  2020-10-29 21:32 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-10-27 22:50 UTC (permalink / raw)
  To: michael.kubacki@outlook.com, devel@edk2.groups.io
  Cc: Chiu, Chasel, Liming Gao, Dong, Eric

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> Sent: Monday, October 26, 2020 1:04 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove
> PlatformInitPreMem ReportFvLib dependency
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> PlatformInitPreMem does not actually use the ReportFvLib API. This change
> removes the library dependency in PlatformInitPreMem.inf so platforms
> using this module with a custom BoardInitLib are not forced to link a
> ReportFvLib.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c   | 1 -
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> index 48cbe0dfbec2..6519fdd04259 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
> +++ mInitPreMem.c
> @@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include
> <Library/TimerLib.h>  #include <Library/BaseMemoryLib.h>  #include
> <Library/PeiServicesLib.h> -#include <Library/ReportFvLib.h>  #include
> <Ppi/ReadOnlyVariable2.h>  #include <Ppi/MemoryDiscovered.h>  #include
> <Ppi/FirmwareVolumeInfo.h> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> index 8e828ff2ac4b..e37bcba56085 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
> +++ mInitPreMem.inf
> @@ -24,7 +24,6 @@ [LibraryClasses]
>    MemoryAllocationLib
>    PeimEntryPoint
>    PeiServicesLib
> -  ReportFvLib
>    TestPointCheckLib
>    TimerLib
>    SetCacheMtrrLib
> --
> 2.28.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency
  2020-10-26 20:03 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency Michael Kubacki
  2020-10-27  6:22 ` 回复: [edk2-devel] " gaoliming
  2020-10-27 22:50 ` Nate DeSimone
@ 2020-10-29 21:32 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-10-29 21:32 UTC (permalink / raw)
  To: michael.kubacki@outlook.com, devel@edk2.groups.io
  Cc: Chiu, Chasel, Liming Gao, Dong, Eric

Pushed: https://github.com/tianocore/edk2-platforms/commit/8664e51

> -----Original Message-----
> From: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> Sent: Monday, October 26, 2020 1:04 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove
> PlatformInitPreMem ReportFvLib dependency
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> PlatformInitPreMem does not actually use the ReportFvLib API. This change
> removes the library dependency in PlatformInitPreMem.inf so platforms
> using this module with a custom BoardInitLib are not forced to link a
> ReportFvLib.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c   | 1 -
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> index 48cbe0dfbec2..6519fdd04259 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
> +++ mInitPreMem.c
> @@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include
> <Library/TimerLib.h>  #include <Library/BaseMemoryLib.h>  #include
> <Library/PeiServicesLib.h> -#include <Library/ReportFvLib.h>  #include
> <Ppi/ReadOnlyVariable2.h>  #include <Ppi/MemoryDiscovered.h>  #include
> <Ppi/FirmwareVolumeInfo.h> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> index 8e828ff2ac4b..e37bcba56085 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
> +++ mInitPreMem.inf
> @@ -24,7 +24,6 @@ [LibraryClasses]
>    MemoryAllocationLib
>    PeimEntryPoint
>    PeiServicesLib
> -  ReportFvLib
>    TestPointCheckLib
>    TimerLib
>    SetCacheMtrrLib
> --
> 2.28.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-29 21:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-26 20:03 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency Michael Kubacki
2020-10-27  6:22 ` 回复: [edk2-devel] " gaoliming
2020-10-27 22:50 ` Nate DeSimone
2020-10-29 21:32 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox