From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <bret@corthon.com>
Cc: "'Jiewen Yao'" <jiewen.yao@intel.com>,
"'Chao Zhang'" <chao.b.zhang@intel.com>,
"'Jian J Wang'" <jian.j.wang@intel.com>,
"'Hao A Wu'" <hao.a.wu@intel.com>,
"'Liming Gao'" <liming.gao@intel.com>,
"'Jordan Justen'" <jordan.l.justen@intel.com>,
"'Laszlo Ersek'" <lersek@redhat.com>,
"'Ard Biesheuvel'" <ard.biesheuvel@arm.com>,
"'Andrew Fish'" <afish@apple.com>, "'Ray Ni'" <ray.ni@intel.com>
Subject: 回复: [edk2-devel] [PATCH v7 00/14] Add the VariablePolicy feature
Date: Tue, 8 Sep 2020 09:09:41 +0800 [thread overview]
Message-ID: <002a01d6857c$bb309310$3191b930$@byosoft.com.cn> (raw)
In-Reply-To: <20200828055127.1610-1-brbarkel@microsoft.com>
Bret:
Thanks for your update. This version is good to me. Reviewed-by: Liming
Gao <gaoliming@byosoft.com.cn> for the changes in MdeModulePkg.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64712+4905953+8761045@groups.io
> <bounce+27952+64712+4905953+8761045@groups.io> 代表 Bret
> Barkelew
> 发送时间: 2020年8月28日 13:51
> 收件人: devel@edk2.groups.io
> 抄送: Jiewen Yao <jiewen.yao@intel.com>; Chao Zhang
> <chao.b.zhang@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
> <hao.a.wu@intel.com>; Liming Gao <liming.gao@intel.com>; Jordan Justen
> <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard
> Biesheuvel <ard.biesheuvel@arm.com>; Andrew Fish <afish@apple.com>;
> Ray Ni <ray.ni@intel.com>
> 主题: [edk2-devel] [PATCH v7 00/14] Add the VariablePolicy feature
>
> The 14 patches in this series add the VariablePolicy feature to the core,
> deprecate Edk2VarLock (while adding a compatibility layer to reduce code
> churn), and integrate the VariablePolicy libraries and protocols into
> Variable Services.
>
> Since the integration requires multiple changes, including adding
libraries,
> a protocol, an SMI communication handler, and VariableServices
integration,
> the patches are broken up by individual library additions and then a final
> integration. Security-sensitive changes like bypassing Authenticated
> Variable enforcement are also broken out into individual patches so that
> attention can be called directly to them.
>
> Platform porting instructions are described in this wiki entry:
>
https://github.com/tianocore/tianocore.github.io/wiki/VariablePolicy-Protoco
> l---Enhanced-Method-for-Managing-Variables#platform-porting
>
> Discussion of the feature can be found in multiple places throughout
> the last year on the RFC channel, staging branches, and in devel.
>
> Most recently, this subject was discussed in this thread:
> https://edk2.groups.io/g/devel/message/53712
> (the code branches shared in that discussion are now out of date, but the
> whitepapers and discussion are relevant).
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Bret Barkelew <brbarkel@microsoft.com>
> Signed-off-by: Bret Barkelew <brbarkel@microsoft.com>
>
> v7 changes:
> * Address comments from Dandan about security of the MM handler
> * Add readme
> * Fix bug around hex characters in BOOT####, etc
> * Add additional testing for hex characters
> * Add additional testing for authenticated variables
>
> v6 changes:
> * Fix an issue with uninitialized Status in InitVariablePolicyLib() and
> DeinitVariablePolicyLib()
> * Fix GCC building in shell-based functional test
> * Rebase on latest origin/master
>
> v5 changes:
> * Fix the CONST mismatch in VariablePolicy.h and VariablePolicySmmDxe.c
> * Fix EFIAPI mismatches in the functional unittest
> * Rebase on latest origin/master
>
> v4 changes:
> * Remove Optional PcdAllowVariablePolicyEnforcementDisable PCD from
> platforms
> * Rebase on master
> * Migrate to new MmCommunicate2 protocol
> * Fix an oversight in the default return value for InitMmCommonCommBuffer
> * Fix in VariablePolicyLib to allow ExtraInitRuntimeDxe to consume
variables
>
> V3 changes:
> * Address all non-unittest issues with ECC
> * Make additional style changes
> * Include section name in hunk headers in "ini-style" files
> * Remove requirement for the EdkiiPiSmmCommunicationsRegionTable driver
> (now allocates its own buffer)
> * Change names from VARIABLE_POLICY_PROTOCOL and
> gVariablePolicyProtocolGuid
> to EDKII_VARIABLE_POLICY_PROTOCOL and
> gEdkiiVariablePolicyProtocolGuid
> * Fix GCC warning about initializing externs
> * Add UNI strings for new PCD
> * Add patches for ArmVirtPkg, OvmfXen, and UefiPayloadPkg
> * Reorder patches according to Liming's feedback about adding to platforms
> before changing variable driver
>
> V2 changes:
> * Fixed implementation for RuntimeDxe
> * Add PCD to block DisableVariablePolicy
> * Fix the DumpVariablePolicy pagination in SMM
>
>
> Bret Barkelew (14):
> MdeModulePkg: Define the VariablePolicy protocol interface
> MdeModulePkg: Define the VariablePolicyLib
> MdeModulePkg: Define the VariablePolicyHelperLib
> MdeModulePkg: Define the VarCheckPolicyLib and SMM interface
> OvmfPkg: Add VariablePolicy engine to OvmfPkg platform
> EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform
> ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform
> UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform
> MdeModulePkg: Connect VariablePolicy business logic to
> VariableServices
> MdeModulePkg: Allow VariablePolicy state to delete protected variables
> SecurityPkg: Allow VariablePolicy state to delete authenticated
> variables
> MdeModulePkg: Change TCG MOR variables to use VariablePolicy
> MdeModulePkg: Drop VarLock from RuntimeDxe variable driver
> MdeModulePkg: Add a shell-based functional test for VariablePolicy
>
> MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c
> | 345 +++
> MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c
> | 396 ++++
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyExtraInitNull.c
> | 46 +
>
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyExtraInitRuntimeDxe
> .c | 85 +
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c
> | 830 +++++++
>
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePoli
> cyUnitTest.c | 2452 ++++++++++++++++++++
>
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyFunc
> TestApp.c | 2226 ++++++++++++++++++
> MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe.c
> | 52 +-
> MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c
> | 60 +-
> MdeModulePkg/Universal/Variable/RuntimeDxe/VarCheck.c
> | 49 +-
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
> | 53 +
>
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequstToLock.c
> | 71 +
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c
> | 642 +++++
>
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
> | 14 +
> SecurityPkg/Library/AuthVariableLib/AuthService.c
> | 22 +-
> ArmVirtPkg/ArmVirt.dsc.inc
> | 4 +
> EmulatorPkg/EmulatorPkg.dsc
> | 3 +
> MdeModulePkg/Include/Guid/VarCheckPolicyMmi.h
> | 54 +
> MdeModulePkg/Include/Library/VariablePolicyHelperLib.h
> | 164 ++
> MdeModulePkg/Include/Library/VariablePolicyLib.h
> | 207 ++
> MdeModulePkg/Include/Protocol/VariablePolicy.h
> | 157 ++
> MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.inf
> | 42 +
> MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.uni
> | 12 +
> MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> | 35 +
> MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.uni
> | 12 +
> MdeModulePkg/Library/VariablePolicyLib/ReadMe.md
> | 410 ++++
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> | 49 +
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.uni
> | 12 +
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> | 51 +
>
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePoli
> cyUnitTest.inf | 45 +
> MdeModulePkg/MdeModulePkg.ci.yaml
> | 8 +-
> MdeModulePkg/MdeModulePkg.dec
> | 26 +-
> MdeModulePkg/MdeModulePkg.dsc
> | 9 +
> MdeModulePkg/MdeModulePkg.uni
> | 7 +
> MdeModulePkg/Test/MdeModulePkgHostTest.dsc
> | 11 +
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/Readme.md
> | 55 +
>
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyFunc
> TestApp.inf | 47 +
>
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyTest
> AuthVar.h | 128 +
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> | 5 +
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf
> | 4 +
>
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.in
> f | 11 +
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
> | 4 +
> OvmfPkg/OvmfPkgIa32.dsc
> | 5 +
> OvmfPkg/OvmfPkgIa32X64.dsc
> | 5 +
> OvmfPkg/OvmfPkgX64.dsc
> | 5 +
> OvmfPkg/OvmfXen.dsc
> | 4 +
> SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> | 2 +
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> | 4 +
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> | 4 +
> 49 files changed, 8865 insertions(+), 79 deletions(-)
> create mode 100644
> MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c
> create mode 100644
> MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyExtraInitNull.c
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyExtraInitRuntimeDxe
> .c
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePoli
> cyUnitTest.c
> create mode 100644
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyFunc
> TestApp.c
> create mode 100644
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequstToLock.c
> create mode 100644
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c
> create mode 100644 MdeModulePkg/Include/Guid/VarCheckPolicyMmi.h
> create mode 100644
> MdeModulePkg/Include/Library/VariablePolicyHelperLib.h
> create mode 100644 MdeModulePkg/Include/Library/VariablePolicyLib.h
> create mode 100644 MdeModulePkg/Include/Protocol/VariablePolicy.h
> create mode 100644
> MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.inf
> create mode 100644
> MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.uni
> create mode 100644
> MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> create mode 100644
> MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.uni
> create mode 100644 MdeModulePkg/Library/VariablePolicyLib/ReadMe.md
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.uni
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> create mode 100644
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePoli
> cyUnitTest.inf
> create mode 100644
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/Readme.md
> create mode 100644
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyFunc
> TestApp.inf
> create mode 100644
> MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyTest
> AuthVar.h
>
> --
> 2.28.0.windows.1
>
>
>
next prev parent reply other threads:[~2020-09-08 1:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 5:51 [PATCH v7 00/14] Add the VariablePolicy feature Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 01/14] MdeModulePkg: Define the VariablePolicy protocol interface Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 02/14] MdeModulePkg: Define the VariablePolicyLib Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 03/14] MdeModulePkg: Define the VariablePolicyHelperLib Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 04/14] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform Bret Barkelew
2020-09-23 2:47 ` [edk2-devel] " Ni, Ray
2020-09-23 4:29 ` Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 10/14] MdeModulePkg: Allow VariablePolicy state to delete protected variables Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables Bret Barkelew
[not found] ` <007a01d68bc9$744d2af0$5ce780d0$@byosoft.com.cn>
2020-09-16 2:51 ` [edk2-devel] " Yao, Jiewen
2020-09-16 21:48 ` Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 12/14] MdeModulePkg: Change TCG MOR variables to use VariablePolicy Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 13/14] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver Bret Barkelew
2020-08-28 5:51 ` [PATCH v7 14/14] MdeModulePkg: Add a shell-based functional test for VariablePolicy Bret Barkelew
2020-09-08 1:09 ` gaoliming [this message]
2020-09-15 15:44 ` [edk2-devel] [PATCH v7 00/14] Add the VariablePolicy feature Dandan Bi
2020-09-15 20:00 ` Bret Barkelew
2020-09-22 15:35 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002a01d6857c$bb309310$3191b930$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox