From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.10235.1603780379809185614 for ; Mon, 26 Oct 2020 23:33:00 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 27 Oct 2020 14:32:51 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: , "'Michael D Kinney'" , "'Zhiguang Liu'" , "'Ray Ni'" , "'Zhichao Gao'" References: <20201021184115.25712-1-rebecca@nuviainc.com> <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com> <003301d6ab36$bb724460$3256cd20$@byosoft.com.cn> <20201026174755.GG1664@vanye> In-Reply-To: <20201026174755.GG1664@vanye> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCAwLzZdIHNtYmlvc3ZpZXcgYW5kIFNtQmlvcy5oIGZpeGVzLCBhZGQgU01CSU9TIDMuNC4wIEFSTTY0IFNvQyBJRCBkZWZpbml0aW9u?= Date: Tue, 27 Oct 2020 14:32:57 +0800 Message-ID: <002b01d6ac2b$026ce330$0746a990$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLu67P94R99nj5uRei9iJPsNG9Q2wK5wBmLAhV8EI4DU7XO5gF1Q6Zxpy27y6A= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Leif: If no objection, I agree to merge patch 4/6 just after next stable tag 2= 02011.=20 Rebecca: Can you create PR for other 5 patches? I can help merge them.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66605+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Leif L= indholm > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8827=E6=97= =A5 1:48 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com= .cn > =E6=8A=84=E9=80=81: rebecca@nuviainc.com; 'Michael D Kinney' > ; 'Zhiguang Liu' ; '= Ray > Ni' ; 'Zhichao Gao' > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4= = =8D: [PATCH 0/6] smbiosview and SmBios.h > fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition >=20 > Hi Liming, >=20 > I agree 4/6 is invasive, but I also think industry standard headers > should match the specifications they implement. >=20 > If 5-6/6 do not depend on 4/6, then I agree the others can be merged > first. > Depending on perceived impact, perhaps 4/6 could be held back until > just after next stable tag? >=20 > Best Regards, >=20 > Leif >=20 > On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: > > Rebecca: > > Patch 4/6 may be safe. But, we may need more time to collect the > feedback. > > > > > > Other patches are clear. I suggest to merge them first. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66523+4905953+8761045@grou= ps.io > > > =E4=BB=A3=E8=A1=A8 Re= becca > Cran > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8822=E6= =97=A5 10:21 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft= .com.cn > > > =E6=8A=84=E9=80=81: 'Michael D Kinney' ;= 'Zhiguang Liu' > > > ; 'Ray Ni' ; 'Zhichao Gao' > > > > > > =E4=B8=BB=E9=A2=98: Re: [EXTERNAL] [edk2-devel] =E5=9B=9E=E5=A4=8D: = [PATCH 0/6] smbiosview and > > > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > > > > > On 10/21/20 7:46 PM, gaoliming wrote: > > > > They are the good change. But for patch 4/6, it changes the > structure > > > > field name. It may bring the impact to the platform code. I don't > > suggest to > > > > do the renaming field only for typo purpose. Other changes are goo= d to > > me. > > > > > > From looking at the code in edk2-platforms, it seems the common > pattern > > > is to use positional arguments instead of designated initializers. O= f > > > course there could be platforms outside of TianoCore which use the f= ield > > > names, but it looks like a relatively safe change. > > > > > > > > > -- > > > Rebecca Cran > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20