From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.17575.1616995240698385771 for ; Sun, 28 Mar 2021 22:20:41 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 29 Mar 2021 13:20:30 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Kinney, Michael D'" , "'Sean Brogan'" , "'Bret Barkelew'" , "'Leif Lindholm'" , "'Ard Biesheuvel'" , "'Laszlo Ersek'" , "'Yao, Jiewen'" , "'Wang, Jian J'" , "'Sami Mujawar'" , "'Alexei Fedorov'" , "'Andrew Fish'" , "'Ni, Ray'" , "'Chiu, Chasel'" , "'Desimone, Nathaniel L'" , "'Zeng, Star'" , "'Gao, Zhichao'" , "'Wu, Hao A'" , "'Ma, Maurice'" , "'Dong, Guo'" , "'You, Benjamin'" , "'Dong, Eric'" , "'Maciej Rabeda'" , "'Wu, Jiaxin'" , "'Fu, Siyuan'" , "'Justen, Jordan L'" , "'Supreeth Venkatesh'" , "'Abner Chang'" , "'Nickle Wang'" , "'Liu, Zhiguang'" References: <16707FF9B84D29FC.5213@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW3BhdGNoIFY0IDAwLzI5XSBBZGQgYSBuZXcgbGlicmFyeSBjbGFzcyBSZWdpc3RlckZpbHRlckxpYiBpbiBlZGsyIHRvIGZpbHRlci90cmFjZSBwb3J0IElPL01NSU8vTVNSIGFjY2Vzcw==?= Date: Mon, 29 Mar 2021 13:20:32 +0800 Message-ID: <002c01d7245b$3dc89b60$b959d220$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFG8JKoHyC9j6oGBympzNfPal7OUAKUsIC4q6YvLRA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Dandan: Thanks for your quick update. I agree this change in MdeLibs.dsc.inc doe= s make sense.=20 For this patch set, Reviewed-by: Liming Gao Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Dandan Bi > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA3=D4=C229=C8=D5 10:56 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Bi, Dandan > =B3=AD=CB=CD: Kinney, Michael D ; Sean Broga= n > ; Bret Barkelew > ; Leif Lindholm ; Ard > Biesheuvel ; Laszlo Ersek = ; > Yao, Jiewen ; Wang, Jian J = ; > Sami Mujawar ; Alexei Fedorov > ; Andrew Fish ; Ni, Ray > ; Chiu, Chasel ; Desimone, > Nathaniel L ; Zeng, Star > ; Gao, Zhichao ; Wu, Hao A > ; Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Dong, Eric > ; Maciej Rabeda ; > Wu, Jiaxin ; Fu, Siyuan ; Justen, > Jordan L ; Supreeth Venkatesh > ; Abner Chang ; > Nickle Wang ; Liming Gao > ; Liu, Zhiguang > =D6=F7=CC=E2: Re: [edk2-devel] [patch V4 00/29] Add a new library class > RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access >=20 > Hi Maintainers/Reviewers, >=20 > For this change serial, could you help review the patch in your package= s in > edk2/edk2-platform repo? Thanks in advance. >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Dandan > > Bi > > Sent: Sunday, March 28, 2021 8:02 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Sean Brogan > > ; Bret Barkelew > > ; Leif Lindholm ; Ard > > Biesheuvel ; Laszlo Ersek > > ; Yao, Jiewen ; Wang, Jian J > > ; Sami Mujawar ; > Alexei > > Fedorov ; Andrew Fish ; Ni, > > Ray ; Chiu, Chasel ; Desimone= , > > Nathaniel L ; Zeng, Star > > ; Gao, Zhichao ; Wu, Hao A > > ; Ma, Maurice ; Dong, Guo > > ; You, Benjamin ; Dong, > > Eric ; Maciej Rabeda > > ; Wu, Jiaxin ; Fu, > > Siyuan ; Justen, Jordan L > ; > > Supreeth Venkatesh ; Abner Chang > > ; Nickle Wang ; Liming > > Gao ; Liu, Zhiguang > > Subject: [edk2-devel] [patch V4 00/29] Add a new library class > > RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3246 > > RFC: https://edk2.groups.io/g/devel/message/72530 > > Branch for this change: > > https://github.com/dandanbi/edk2/tree/RegisterFilterLibV3 > > > > Patch 1 is to add RegisterFilterLib Library Class in edk2 to filter/trace port > > IO/MMIO/MSR access and add a RegisterFilterLibNull instance. > > Patch 2 is to add the MdeLibs.dsc.inc file to MdePkg for some default > libraries > > provided by MdePkg and add RegisterFilterLib into it as the first version of > > MdeLibs.dsc.inc. > > Last 2 patches are to update APIs in IoLib and BaseLib to filter/trace port > > IO/MMIO/MSR access. > > Remaining patches are to update related dsc files to consume > > MdeLibs.dsc.inc for RegisterFilterLib. > > Will submit patch 1 and 2 firstly. > > And then update related dsc files in edk2 and edk2platform repo to consume > > MdeLibs.dsc.inc for RegisterFilterLib. > > At last will submit the patches to update IoLib and BaseLib to filter/trace > port > > IO/MMIO/MSR access. > > > > --- > > V4: > > Consume the MdeLibs.dsc.inc for RegisterFilterLibNull in dsc file rath= er than > > in xxx.dsc.inc. > > Following 2 patchws were updated for consuming MdeLibs.dsc.inc in > > platform dsc file. > > ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > Other patches are the same with V3. > > --- > > V3: > > 1. Don't assume Library instances in MdeLibs.dsc.inc are must in commo= n > > [LibraryClasses] section. > > Can specify different [LibraryClasses] section for the libary instances in > > MdeLibs.dsc.inc. > > 2. Update plaftom dsc to consume the MdeLibs.dsc outside the > > [LibraryClasses] section. > > 3. Pick up the R-B for patch 1, patch 28, patch 29. > > > > Cc: Michael D Kinney > > Cc: Sean Brogan > > Cc: Bret Barkelew > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Laszlo Ersek > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Sami Mujawar > > Cc: Alexei Fedorov > > Cc: Andrew Fish > > Cc: Ray Ni > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Star Zeng > > Cc: Zhichao Gao > > Cc: Hao A Wu > > Cc: Maurice Ma > > Cc: Guo Dong > > Cc: Benjamin You > > Cc: Eric Dong > > Cc: Maciej Rabeda > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Cc: Jordan Justen > > Cc: Supreeth Venkatesh > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Liming Gao > > Cc: Zhiguang Liu > > > > Dandan Bi (29): > > MdePkg: Add RegisterFilterLib class and NULL instance > > MdePkg: Add MdeLibs.dsc.inc file to MdePkg > > ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > ArmPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > CryptoPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > DynamicTablesPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > EmbeddedPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > EmulatorPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > FatPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > FmpDevicePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > IntelFsp2Pkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > IntelFsp2WrapperPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > MdeModulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > MdePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > NetworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > OvmfPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > PcAtChipsetPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > RedfishPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > SecurityPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > ShellPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > SignedCapsulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > SourceLevelDebugPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > StandaloneMmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib > > MdePkg/IoLib: Filter/trace port IO/MMIO access > > MdePkg/Baseib: Filter/trace MSR access for IA32/X64 > > > > ArmPkg/ArmPkg.dsc | 2 + > > ArmPlatformPkg/ArmPlatformPkg.dsc | 2 + > > ArmVirtPkg/ArmVirt.dsc.inc | 4 +- > > CryptoPkg/CryptoPkg.dsc | 5 +- > > DynamicTablesPkg/DynamicTablesPkg.dsc | 2 + > > EmbeddedPkg/EmbeddedPkg.dsc | 5 +- > > EmulatorPkg/EmulatorPkg.dsc | 4 +- > > FatPkg/FatPkg.dsc | 4 +- > > FmpDevicePkg/FmpDevicePkg.dsc | 4 +- > > IntelFsp2Pkg/IntelFsp2Pkg.dsc | 4 +- > > IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 2 + > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 4 +- > > MdeModulePkg/MdeModulePkg.dsc | 4 +- > > MdePkg/Include/Library/RegisterFilterLib.h | 243 > ++++++++++++++++ > > .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 3 +- > > .../BaseIoLibIntrinsicArmVirt.inf | 3 +- > > .../BaseIoLibIntrinsicInternal.h | 3 +- > > .../BaseIoLibIntrinsicSev.inf | 3 +- > > MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 95 ++++-- > > .../Library/BaseIoLibIntrinsic/IoLibArmVirt.c | 82 +++++- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 58 +++- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibMsc.c | 81 ++++-- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c | 74 ++++- > > MdePkg/Library/BaseLib/BaseLib.inf | 5 +- > > MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 38 ++- > > MdePkg/Library/BaseLib/Ia32/ReadMsr64.c | 38 ++- > > MdePkg/Library/BaseLib/Ia32/WriteMsr64.c | 22 +- > > MdePkg/Library/BaseLib/X64/GccInlinePriv.c | 43 ++- > > MdePkg/Library/BaseLib/X64/ReadMsr64.c | 15 +- > > MdePkg/Library/BaseLib/X64/WriteMsr64.c | 13 +- > > .../RegisterFilterLibNull.c | 271 > ++++++++++++++++++ > > .../RegisterFilterLibNull.inf | 23 ++ > > .../RegisterFilterLibNull.uni | 13 + > > MdePkg/MdeLibs.dsc.inc | 15 + > > MdePkg/MdePkg.dec | 7 +- > > MdePkg/MdePkg.dsc | 6 +- > > NetworkPkg/NetworkPkg.dsc | 4 +- > > OvmfPkg/AmdSev/AmdSevX64.dsc | 5 +- > > OvmfPkg/Bhyve/BhyveX64.dsc | 5 +- > > OvmfPkg/OvmfPkgIa32.dsc | 5 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 5 +- > > OvmfPkg/OvmfPkgX64.dsc | 5 +- > > OvmfPkg/OvmfXen.dsc | 5 +- > > PcAtChipsetPkg/PcAtChipsetPkg.dsc | 4 +- > > RedfishPkg/RedfishPkg.dsc | 4 +- > > SecurityPkg/SecurityPkg.dsc | 4 +- > > ShellPkg/ShellPkg.dsc | 4 +- > > SignedCapsulePkg/SignedCapsulePkg.dsc | 4 +- > > SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 4 +- > > StandaloneMmPkg/StandaloneMmPkg.dsc | 5 +- > > UefiCpuPkg/UefiCpuPkg.dsc | 4 +- > > UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +- > > .../UnitTestFrameworkPkgTarget.dsc.inc | 4 +- > > 53 files changed, 1131 insertions(+), 145 deletions(-) create mode > 100644 > > MdePkg/Include/Library/RegisterFilterLib.h > > create mode 100644 > > MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.c > > create mode 100644 > > MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf > > create mode 100644 > > MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.uni > > create mode 100644 MdePkg/MdeLibs.dsc.inc > > > > -- > > 2.18.0.windows.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20