From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.3899.1623382905165222988 for ; Thu, 10 Jun 2021 20:41:46 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 11 Jun 2021 11:41:34 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'KARPAGAVINAYAGAM, MANICKAVASAKAM'" Cc: "'Desimone, Nathaniel L'" , , "'DOPPALAPUDI, HARIKRISHNA'" , "'Jha, Manish'" , "'Bobroff, Zachary'" References: <20210610234121.7409-1-manickavasakamk@ami.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazJdW1BBVENIXSBNZGVQa2cgOiBBZGQgSVBNSSBNYWNybyBhbmQgU3RydWN0dXJlIERlZmludGlvbnMgdG8gcmVzb2x2ZSB0aGUgSVBNSSBidWlsZCBlcnJvcg==?= Date: Fri, 11 Jun 2021 11:41:37 +0800 Message-ID: <002d01d75e73$aec476c0$0c4d6440$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFjCNZ3y7Cwzq7uL8rIZqot8w/jOQJy/FqRq+M9ZvA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn KARP: I don't find the source code in edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg to consum= e new struct IPMI_SET_BOOT_OPTIONS_RESPONSE. Can you point which source file depend on new definition? Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Oram, Isaac > W > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA6=D4=C211=C8=D5 8:13 > =CA=D5=BC=FE=C8=CB: KARPAGAVINAYAGAM, MANICKAVASAKAM > ; devel@edk2.groups.io > =B3=AD=CB=CD: Desimone, Nathaniel L ; > Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA ; > Jha, Manish ; Bobroff, Zachary > =D6=F7=CC=E2: Re: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and > Structure Defintions to resolve the IPMI build error >=20 > Please comment the following commenting per normal style > /*------------------------------------------------------------------------= -- -------------- > Definitions for Get BMC Execution Context > --------------------------------------------------------------------------= -- ------------*/ >=20 > Which would correctly be: > // > // Definitions for Get BMC Execution Context > // >=20 > Please don't use EFI_ or Efi prefix for items that are not part of UEFI owned > specifications. Please correct: > EFI_IPMI_MSG_GET_BMC_EXEC_RSP > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE > and any uses. >=20 > Thanks, > Isaac >=20 > -----Original Message----- > From: manickavasakam karpagavinayagam > Sent: Thursday, June 10, 2021 4:41 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Felixp@ami.com; DOPPALAPUDI, > HARIKRISHNA ; Jha, Manish ; > Bobroff, Zachary > Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions = to > resolve the IPMI build error >=20 > Build error reported for missing structures > IPMI_SET_BOOT_OPTIONS_RESPONSE, > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > D_UPDATE_MODE > when using > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg > --- > MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19 > +++++++++++++++++++ > 2 files changed, 23 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > index 79db55523d..d7cdd3a865 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > @@ -186,6 +186,10 @@ typedef struct { > UINT8 ParameterData[0]; >=20 > } IPMI_SET_BOOT_OPTIONS_REQUEST; >=20 >=20 >=20 > +typedef struct { >=20 > + UINT8 CompletionCode:8; >=20 > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; >=20 > + >=20 > // >=20 > // Definitions for Get System Boot options command >=20 > // >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > index 2d892dbd5a..1c692cc792 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > @@ -17,4 +17,23 @@ > // All Firmware commands and their structure definitions to follow here >=20 > // >=20 >=20 >=20 > +/*-----------------------------------------------------------------------= -- --------------- >=20 > + Definitions for Get BMC Execution Context >=20 > +-------------------------------------------------------------------------= -- -------------*/ >=20 > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > + >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10 >=20 > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > #endif >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20 >=20 >=20