From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.1553.1644542046779676164
 for <devel@edk2.groups.io>;
 Thu, 10 Feb 2022 17:14:07 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <ardb@kernel.org>; Fri, 11 Feb 2022 09:13:40 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Ard Biesheuvel'" <ardb@kernel.org>,
	"'edk2-devel-groups-io'" <devel@edk2.groups.io>,
	"'Rebecca Cran'" <quic_rcran@quicinc.com>
Cc: "'James Bottomley'" <jejb@linux.ibm.com>,
	"'Min Xu'" <min.m.xu@intel.com>,
	"'Jiewen Yao'" <jiewen.yao@intel.com>,
	"'Tom Lendacky'" <thomas.lendacky@amd.com>,
	"'Jordan Justen'" <jordan.l.justen@intel.com>,
	"'Ard Biesheuvel'" <ardb+tianocore@kernel.org>,
	"'Erdem Aktas'" <erdemaktas@google.com>,
	"'Michael Roth'" <Michael.Roth@amd.com>,
	"'Gerd Hoffmann'" <kraxel@redhat.com>,
	"'Brijesh Singh'" <brijesh.singh@amd.com>
References: <20220204201302.21451-1-quic_rcran@quicinc.com> <CAMj1kXF-6-ewSm16ULMfWsSoHuTBPDDprDEbjMM3gXEPkQxkUw@mail.gmail.com> <CAMj1kXGS4xrAVaBVpr6jxyw0osqg8qsWrksL02moaXBoKwfM7Q@mail.gmail.com>
In-Reply-To: <CAMj1kXGS4xrAVaBVpr6jxyw0osqg8qsWrksL02moaXBoKwfM7Q@mail.gmail.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDEvMV0gT3ZtZlBrZy9WbWdFeGl0TGliOiBGaXggdW5pbml0aWFsaXplZCB2YXJpYWJsZSB3YXJuaW5nIHdpdGggWENPREU1?=
Date: Fri, 11 Feb 2022 09:13:42 +0800
Message-ID: <002d01d81ee4$9bdd2d90$d39788b0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQJ1jePqpp++enVfWFlTiYO6viYRvAF4dQSuAbGiF5urOVyPoA==
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Ard:
 I am OK to merge this issue for this stable tag. It is a clear bug fix.=20

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Ard Biesheuvel <ardb@kernel.org>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B42=E6=9C=8810=E6=97=A5 =
17:18
> =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.groups.io>;=
 Rebecca Cran
> <quic_rcran@quicinc.com>; Liming Gao (Byosoft address)
> <gaoliming@byosoft.com.cn>
> =E6=8A=84=E9=80=81: James Bottomley <jejb@linux.ibm.com>; Min Xu
> <min.m.xu@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Jordan Justen <jordan.l.justen@intel.com>;
> Ard Biesheuvel <ardb+tianocore@kernel.org>; Erdem Aktas
> <erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Brijesh Singh <brijesh.singh@amd.com>
> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VmgExitLib: F=
ix uninitialized
> variable warning with XCODE5
>=20
> On Thu, 10 Feb 2022 at 10:17, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > (+ Liming)
> >
>=20
> ... for real this time.
>=20
> > On Fri, 4 Feb 2022 at 21:28, Rebecca Cran <quic_rcran@quicinc.com>
> wrote:
> > >
> > > XCODE5 reported the following warning:
> > >
> > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note:
> > > uninitialized use occurs here
> > >            Compacted
> > >            ^^^^^^^^^
> > >
> > > Initialize the 'Compacted' variable to fix the warning.
> > >
> > > Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> > > ---
> > >  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > > index a40a31f7c275..ccb1300690fa 100644
> > > --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > > +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > > @@ -1872,6 +1872,7 @@ GetCpuidFw (
> > >      UINT32                 XSaveSize;
> > >
> > >      XssMsr.Uint64 =3D 0;
> > > +    Compacted     =3D 0;
> >
> > This should be FALSE not 0. I will fix this up before merging.
> >
> > Liming: is it ok if I merge this today?
> >
> >
> > >      if (EcxIn =3D=3D 1) {
> > >        /*
> > >         * The PPR and APM aren't clear on what size should be
> encoded in
> > > --
> > > 2.34.1
> > >
> > >
> > >
> > >=20
> > >
> > >