From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.7567.1622600902904677582 for ; Tue, 01 Jun 2021 19:28:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 02 Jun 2021 10:28:16 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , , , References: <20210601220450.28003-1-Pierre.Gondois@arm.com> <20210601220450.28003-2-Pierre.Gondois@arm.com> In-Reply-To: <20210601220450.28003-2-Pierre.Gondois@arm.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjEgMS8yXSBNZGVQa2cvTWRlTW9kdWxlUGtnOiBNb3ZlIEFNTF9OQU1FX1NFR19TSVpFIGRlZmluaXRpb24=?= Date: Wed, 2 Jun 2021 10:28:16 +0800 Message-ID: <002e01d75756$f2167140$d64353c0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH8y+9pQ2df9tGq2jWzVd8+FmhPoAF00ThEqqlveUA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Pierre.Gondois@arm.com = > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B46=E6=9C=882=E6=97=A5 6:05 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; = dandan.bi@intel.com; > gaoliming@byosoft.com.cn; michael.d.kinney@intel.com; > Sami.Mujawar@arm.com; Alexei.Fedorov@arm.com > =E4=B8=BB=E9=A2=98: [PATCH v1 1/2] MdePkg/MdeModulePkg: Move = AML_NAME_SEG_SIZE > definition >=20 > From: Pierre Gondois >=20 > A NameSeg is made 4 chars. > Cf. ACPI 6.4 s20.2.2 "Name Objects Encoding": > NameSeg :=3D > Notice that NameSegs shorter than 4 characters are filled > with trailing underscores (=E2=80=98_=E2=80=99s). >=20 > AML_NAME_SEG_SIZE is currently defined in: > - DynamicTablesPkg/Library/Common/AmlLib/AmlDefines.h > - MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h > Since the value can be inferred from the ACPI specification > and to avoid multiple definitions, move it to > MdePkg/Include/IndustryStandard/ >=20 > Signed-off-by: Pierre Gondois > --- > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h | 1 - > MdePkg/Include/IndustryStandard/AcpiAml.h | 7 ++++++- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h > index 50d4c96edb63..1b26729e71c3 100644 > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h > @@ -56,7 +56,6 @@ typedef struct _EFI_AML_NODE_LIST > EFI_AML_NODE_LIST; > // Size is the total size of this ACPI node buffer. > // Children is the children linked list of this node. > // > -#define AML_NAME_SEG_SIZE 4 >=20 > struct _EFI_AML_NODE_LIST { > UINT32 Signature; > diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h > b/MdePkg/Include/IndustryStandard/AcpiAml.h > index 74622e912ea4..4255ca3d7087 100644 > --- a/MdePkg/Include/IndustryStandard/AcpiAml.h > +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h > @@ -2,7 +2,7 @@ > This file contains AML code definition in the latest ACPI spec. >=20 > Copyright (c) 2011, Intel Corporation. All rights reserved.
> - Copyright (c) 2019, ARM Limited. All rights reserved.
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -176,4 +176,9 @@ > #define AML_FIELD_CONNECTION_OP 0x02 > #define AML_FIELD_EXT_ACCESS_OP 0x03 >=20 > +// > +// AML Name segment definitions > +// > +#define AML_NAME_SEG_SIZE 4 > + > #endif > -- > 2.17.1