From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.4856.1602297199687994635 for ; Fri, 09 Oct 2020 19:33:20 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sat, 10 Oct 2020 10:33:13 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Liu, Zhiguang'" , Cc: "'Wang, Sanyo'" , "'Kinney, Michael D'" , "'Gao, Zhichao'" , "'Sean Brogan'" References: <163932D00054AC83.17908@groups.io> <004501d696c2$e1bcffd0$a536ff70$@byosoft.com.cn> <001201d69e1d$833de480$89b9ad80$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVQa2c6IFNNQklPUyAzLjQuMCBVcGRhdGUgImFkZGluZyBERFI1IGRlZmluaXRpb25zIi4=?= Date: Sat, 10 Oct 2020 10:33:16 +0800 Message-ID: <003001d69ead$b5cf2270$216d6750$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQL0Ljl5+SC4o6FDd58IPwqgi6Bj4wHgM/CHAgekF1kCLS3kvwGApaWMAlJXzOGnBb6xwA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn The pull request needs rebase. I will submit new pull request today.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Liu, Zhiguang > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8810=E6=97= =A5 8:49 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel= @edk2.groups.io > =E6=8A=84=E9=80=81: Wang, Sanyo ; Kinney, Michael = D > ; Gao, Zhichao ; > 'Sean Brogan' > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update= "adding DDR5 > definitions". >=20 > Hi Liming >=20 > In pull request https://github.com/tianocore/edk2/pull/996 > Merge failed because > tanocore.PatchCheck Failing after 34s =E2=80=94 Build #20201009.4 failed >=20 > Detail: > The commit message format is not valid: > * Missing Signed-off-by! (Note: this must be added by the code contribu= tor!) > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For > mat >=20 > However, I abstract the patch from Outlook and run PatchCheck to check i= t in > my local machine, the result is ok. >=20 > Detail: > E:\edk2\BaseTools\Scripts>py PatchCheck.py > 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch > Checking patch file: > 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch > [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions". > The commit message format passed all checks. > The code passed all checks. >=20 > Do you know why? >=20 > Thanks > Zhiguang > > -----Original Message----- > > From: gaoliming > > Sent: Friday, October 9, 2020 5:21 PM > > To: devel@edk2.groups.io; Liu, Zhiguang > > Cc: Wang, Sanyo ; Kinney, Michael D > > ; Gao, Zhichao ; > 'Sean > > Brogan' > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0= Update > "adding > > DDR5 definitions". > > > > https://github.com/tianocore/edk2/pull/996 is created. > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66054+4905953+8761045@grou= ps.io > > > =E4=BB=A3=E8=A1=A8 Zh= iguang > Liu > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=889=E6= =97=A5 15:24 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft= .com.cn > > > =E6=8A=84=E9=80=81: Wang, Sanyo ; Kinney, Mich= ael D > > > ; Gao, Zhichao ; > > > Sean Brogan > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Up= date "adding > DDR5 > > > definitions". > > > > > > Hi Liming, > > > This patch also gets R-B from Sean Brogan. > > > Please help merge this patch. > > > > > > Thanks > > > Zhiguang > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > gaoliming > > > > Sent: Wednesday, September 30, 2020 8:45 AM > > > > To: devel@edk2.groups.io; Liu, Zhiguang > > > > Cc: Wang, Sanyo ; Kinney, Michael D > > > > > > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] MdePkg: SMBIOS 3= .4.0 Update > > > "adding > > > > DDR5 definitions". > > > > > > > > Reviewed-by: Liming Gao > > > > > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+65712+4905953+8761045@= groups.io > > > > > =E4=BB=A3=E8=A1= =A8 > Zhiguang > > > Liu > > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B49=E6=9C=8829= =E6=97=A5 16:12 > > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Liu, Zhiguang > > > > > > =E6=8A=84=E9=80=81: Wang, Sanyo ; Kinney, = Michael D > > > > > ; Liming Gao > > > > > > > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.= 0 Update > "adding > > > DDR5 > > > > > definitions". > > > > > > > > > > > > > > > Reviewed-by: Zhiguang Liu > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io On Behalf Of > > > > > Zhiguang > > > > > > Liu > > > > > > Sent: Tuesday, September 29, 2020 4:09 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Wang, Sanyo ; Kinney, Michael D > > > > > > ; Liming Gao > > > > > > > > > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update > > > > > > "adding > > > > > > DDR5 definitions". > > > > > > > > > > > > From: "Wang, Sanyo" > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2352 > > > > > > > > > > > > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5) > > > > > > > > > > > > Cc: Michael D Kinney > > > > > > Cc: Liming Gao > > > > > > Cc: Zhiguang Liu > > > > > > Signed-off-by: Sanyo Wang > > > > > > --- > > > > > > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++- > > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > > > > > > b/MdePkg/Include/IndustryStandard/SmBios.h > > > > > > index ea23685851..f2db11f947 100644 > > > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h > > > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > > > > > > @@ -1718,7 +1718,9 @@ typedef enum { > > > > > > MemoryTypeLpddr4 =3D 0x1E, > > > > > > > > > > > > MemoryTypeLogicalNonVolatileDevice =3D 0x1F, > > > > > > > > > > > > MemoryTypeHBM =3D 0x20, > > > > > > > > > > > > - MemoryTypeHBM2 =3D 0x21 > > > > > > > > > > > > + MemoryTypeHBM2 =3D 0x21, > > > > > > > > > > > > + MemoryTypeDdr5 =3D 0x22, > > > > > > > > > > > > + MemoryTypeLpddr5 =3D 0x23 > > > > > > > > > > > > } MEMORY_DEVICE_TYPE; > > > > > > > > > > > > > > > > > > > > > > > > /// > > > > > > > > > > > > -- > > > > > > 2.25.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > Groups.io Links: You receive all messages sent to this group. > > > > > > View/Reply Online (#65711): > > > > > https://edk2.groups.io/g/devel/message/65711 > > > > > > Mute This Topic: https://groups.io/mt/77191807/1779286 > > > > > > Group Owner: devel+owner@edk2.groups.io > > > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > > > [zhiguang.liu@intel.com] > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > >