From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9BD53740034 for ; Thu, 24 Aug 2023 01:44:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=o3OJg4QXXkiOjkKQKd2PZZ/3w2K0GxSDPfdE3nK2KOI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1692841497; v=1; b=cJN3t53J2gJQ5IurfdhXL9CWnlJDRywtjgfNfICnRQX39e/KZb5jDzmmm3oKCw8Fu+I+WeQN csggk4KrrrO5EODLXZnS2Tt25eS3igaWvX4FtZdFwre7eYncyDqCBR5XoBjFOLC6cE5r3NiCLbs L8klvtkDtxWiLhL8dqb/yHnE= X-Received: by 127.0.0.2 with SMTP id RdfBYY7687511xr9QqZMWARl; Wed, 23 Aug 2023 18:44:57 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.1721.1692841495539140949 for ; Wed, 23 Aug 2023 18:44:56 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 70EAFA32E1AA for ; Thu, 24 Aug 2023 09:44:52 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 4833CA32E1A0 for ; Thu, 24 Aug 2023 09:44:52 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 9E179A32E1A9 for ; Thu, 24 Aug 2023 09:44:49 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for <2931013282@sjtu.edu.cn>; Thu, 24 Aug 2023 09:44:39 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , , "'Kinney, Michael D'" , "'Leif Lindholm'" , "'Andrew Fish'" Cc: "'Li, Yong'" , <2931013282@sjtu.edu.cn>, "'Warkentin, Andrei'" , References: <2c7b82749a9aff01393b230e216c5e5aee675dd1.1691750977.git.2931013282@sjtu.edu.cn> <177BD1A40E32609C.8497@groups.io> In-Reply-To: Subject: edk2-stable202308: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config Date: Thu, 24 Aug 2023 09:44:42 +0800 Message-ID: <003201d9d62c$8d7991c0$a86cb540$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AdnWKoskd0iOQMifSYyAWrEuFD7VTA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kvqOc3z6rK5JhQGCnnSoKWQLx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cJN3t53J; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Sunil: I agree this is a critical bug fix. The fix is correct. CI failure is not related to this change. If no other comment, I will help merge this change tomorrow.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Sunil V L > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA8=D4=C222=C8=D5 14:26 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Liming Gao > =B3=AD=CB=CD: Li, Yong ; 2931013282@sjtu.edu.cn; Warke= ntin, > Andrei > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in V= arStore > Blockmap config >=20 > Hi Liming, >=20 > This is a bug fix and can cause data loss if the variable size > 4k. > Can it be included for the edk2-stable202308? Let me know if it requires > a BZ id. >=20 > I tried running the CI tests for this patch. But 2 of tests failed and I > don't think it has anything to do with this patch. If you are ok to take > this patch for the stable release, could you please let me know what > needs to be done? >=20 > PR : https://github.com/tianocore/edk2/pull/4754 >=20 > Thanks! > Sunil >=20 > On Wed, Aug 16, 2023 at 02:33:00PM +0530, Sunil V L via groups.io wrote: > > On Wed, Aug 16, 2023 at 07:08:58AM +0000, Li, Yong wrote: > > > Hi Sunil, > > > > > > Qingyu is from Penglai team, when we were working together in enablin= g > StandaloneMm variable service, > > > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which th= e > blockmap config is not aligned with the value in > > > > OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c= , > which is SIZE_256KB > > > > > > That mis-alignment won't cause any issue if the variable size is smal= l and > less than 0x1000, but if store more data in the flash device then it will cause > data loss issue during reboot. > > > Once reboot if any FV header data is corrupted it will result the whole > variable system be re-initialized. > > > > > > Please help review the patch and give the comments, thanks > > > > > Hi Yong Li, > > > > Thank you very much for providing the context. Sorry, I actually had > > missed this. > > > > Hi Quingyu Shang, > > > > The patch LGTM. Thanks a lot for finding the issue and fixing it. In > > future, could you please run BaseTools/Scripts/GetMaintainer.py on the > > patches and CC all the people it lists using "Cc:" tag? > > > > Reviewed-by: Sunil V L > > > > Thanks! > > Sunil > > > > > > > > > > >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107992): https://edk2.groups.io/g/devel/message/107992 Mute This Topic: https://groups.io/mt/100928325/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-