From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web08.7026.1603675465134070331
 for <devel@edk2.groups.io>;
 Sun, 25 Oct 2020 18:24:26 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <devel@edk2.groups.io>; Mon, 26 Oct 2020 09:24:16 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<rebecca@nuviainc.com>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
	"'Ray Ni'" <ray.ni@intel.com>,
	"'Zhichao Gao'" <zhichao.gao@intel.com>
References: <20201021184115.25712-1-rebecca@nuviainc.com> <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com>
In-Reply-To: <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbRVhURVJOQUxdIFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCAwLzZdIHNtYmlvc3ZpZXcgYW5kIFNtQmlvcy5oIGZpeGVzLCBhZGQgU01CSU9TIDMuNC4wIEFSTTY0IFNvQyBJRCBkZWZpbml0aW9u?=
Date: Mon, 26 Oct 2020 09:24:21 +0800
Message-ID: <003301d6ab36$bb724460$3256cd20$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQLu67P94R99nj5uRei9iJPsNG9Q2wK5wBmLAhV8EI6nUhtYUA==
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Rebecca:
  Patch 4/6 may be safe. But, we may need more time to collect the feedbac=
k.


  Other patches are clear. I suggest to merge them first.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+66523+4905953+8761045@groups.io
> <bounce+27952+66523+4905953+8761045@groups.io> =B4=FA=B1=ED Rebecca Cran
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA10=D4=C222=C8=D5 10:21
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> =B3=AD=CB=CD: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang=
 Liu'
> <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao'
> <zhichao.gao@intel.com>
> =D6=F7=CC=E2: Re: [EXTERNAL] [edk2-devel] =BB=D8=B8=B4: [PATCH 0/6] smbi=
osview and
> SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
>=20
> On 10/21/20 7:46 PM, gaoliming wrote:
> >    They are the good change. But for patch 4/6, it changes the structu=
re
> > field name. It may bring the impact to the platform code. I don't
suggest to
> > do the renaming field only for typo purpose. Other changes are good to
me.
>=20
>  From looking at the code in edk2-platforms, it seems the common pattern
> is to use positional arguments instead of designated initializers. Of
> course there could be platforms outside of TianoCore which use the field
> names, but it looks like a relatively safe change.
>=20
>=20
> --
> Rebecca Cran
>=20
>=20
>=20
>=20
>=20