public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Siyuan Fu'" <siyuan.fu@intel.com>, <devel@edk2.groups.io>
Cc: "'Dandan Bi'" <dandan.bi@intel.com>
Subject: 回复: [Patch] MdeModulePkg/Core: Support standalone MM in FV2 protocol GetNextFile().
Date: Wed, 28 Oct 2020 14:09:54 +0800	[thread overview]
Message-ID: <003301d6acf0$f4666c90$dd3345b0$@byosoft.com.cn> (raw)
In-Reply-To: <38c94c28e001783a852c990481d46a0937874f39.1603853801.git.siyuan.fu@intel.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Siyuan Fu <siyuan.fu@intel.com>
> 发送时间: 2020年10月28日 10:57
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi <dandan.bi@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> 主题: [Patch] MdeModulePkg/Core: Support standalone MM in FV2 protocol
> GetNextFile().
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3028
> 
> The FirmwareVolume2Protocol->GetNextFile() produced by DXE Core can be
> used
> to search for a file based on the value of *FileType input. However, this
> service will always return EFI_NOT_FOUND if the input FileType is set to
> EFI_FV_FILETYPE_MM_STANDALONE or
> EFI_FV_FILETYPE_MM_CORE_STANDALONE, Which
> means user can't use this service to search any standalone MM image in
that
> FV.
> This patch update the FirmwareVolume2Protocol->GetNextFile() service to
> support searching standalone MM module.
> 
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
> b/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
> index 2861cbf676..8dcbbeb5ee 100644
> --- a/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
> +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Implements functions to read firmware file
> 
> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -143,9 +143,9 @@ FvGetNextFile (
>      return EFI_ACCESS_DENIED;
>    }
> 
> -  if (*FileType > EFI_FV_FILETYPE_SMM_CORE) {
> +  if (*FileType > EFI_FV_FILETYPE_MM_CORE_STANDALONE) {
>      //
> -    // File type needs to be in 0 - 0x0D
> +    // File type needs to be in 0 - 0x0F
>      //
>      return EFI_NOT_FOUND;
>    }
> --
> 2.19.1.windows.1




      reply	other threads:[~2020-10-28  6:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  2:57 [Patch] MdeModulePkg/Core: Support standalone MM in FV2 protocol GetNextFile() Siyuan, Fu
2020-10-28  6:09 ` gaoliming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003301d6acf0$f4666c90$dd3345b0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox