From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.3594.1635816419859735706 for ; Mon, 01 Nov 2021 18:27:00 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 02 Nov 2021 09:26:57 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Feng, Bob C'" References: <20211027100003.167-1-yuwei.chen@intel.com> <00ae01d7cc68$efdbbf20$cf933d60$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzOiBGaXggU3RydWN0dXJlUGNkIG9mZnNldCBlcnJvci4=?= Date: Tue, 2 Nov 2021 09:26:58 +0800 Message-ID: <003301d7cf88$baa50dc0$2fef2940$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHhly9dL3t4eMk9fG5thk3GO2dfbwE+4i/4AdkJCkerwyOicA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Yuwei: Thanks for your information. I have no other comment for this change. Rev= iewed-by: Liming Gao Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Yuwei Chen > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B410=E6=9C=8829=E6=97=A5= 13:35 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@= edk2.groups.io > =E6=8A=84=E9=80=81: Feng, Bob C > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1] BaseTools: Fix Structure= Pcd offset error. >=20 > Hi Liming, >=20 > As the comments have been added to each StructurePcd > (https://edk2.groups.io/g/devel/message/68378?p=3D%2C%2C%2C20%2C0%2 > C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CStructurePcd%2C20%2C2 > %2C20%2C78773894), the tmp[1] will have not only the "{0x0,0x0}" value bu= t > also the "# comments". If not split with "#", it will generate error form= at for > value "{0x0, 0x0}" StructurePcd. >=20 > Thanks, > Christine (Yuwei) >=20 > > -----Original Message----- > > From: gaoliming > > Sent: Friday, October 29, 2021 10:02 AM > > To: Chen, Christine ; devel@edk2.groups.io > > Cc: Feng, Bob C > > Subject: =E5=9B=9E=E5=A4=8D: [PATCH 1/1] BaseTools: Fix StructurePcd of= fset error. > > > > Yuwei: > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Yuwei Chen > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B410=E6=9C=8827=E6= =97=A5 18:00 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: Bob Feng ; Liming Gao > > > > > > =E4=B8=BB=E9=A2=98: [PATCH 1/1] BaseTools: Fix StructurePcd offset er= ror. > > > > > > Currently when parse VFR files to get the struct info, BOOLEAN type > > > struct is ignored, which caused offset errors. > > > This patch fixed these bugs. > > > > > > Cc: Bob Feng > > > Cc: Liming Gao > > > Signed-off-by: Yuwei Chen > > > --- > > > BaseTools/Scripts/ConvertFceToStructurePcd.py | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py > > > b/BaseTools/Scripts/ConvertFceToStructurePcd.py > > > index 2baabf2dd521..9e7fe58768b1 100644 > > > --- a/BaseTools/Scripts/ConvertFceToStructurePcd.py > > > +++ b/BaseTools/Scripts/ConvertFceToStructurePcd.py > > > @@ -142,7 +142,7 @@ class parser_lst(object): > > > line.append(struct) > > > unparse.append(line) > > > else: > > > - if uint not in ['UINT8', 'UINT16', 'UINT32', > > > 'UINT64']: > > > + if uint not in ['UINT8', 'UINT16', 'UINT32', > > 'UINT64', > > > 'BOOLEAN']: > > > line =3D [offset, t_name, 0, uint] > > > line.append(struct) > > > unparse.append(line) @@ -569,7 +569,7 > @@ class > > > mainprocess(object): > > > for i in List: > > > for j in i: > > > tmp =3D j.split("|") > > > - if (('L"' in j) and ("[" in j)) or (tmp[1].strip() =3D=3D '{= 0x0, > > 0x0}'): > > > + if (('L"' in j) and ("[" in j)) or > > > + (tmp[1].split("#")[0].strip() > > =3D=3D '{0x0, > > > 0x0}'): > > > > Why split '#'? > > > > Thanks > > Liming > > > tmp[0] =3D tmp[0][:tmp[0].index('[')] > > > List[List.index(i)][i.index(j)] =3D "|".join(tmp) > > > else: > > > -- > > > 2.27.0.windows.1 > > > > >=20 >=20 >=20 >=20 >=20