回复: [edk2-devel] [PATCH V8 00/47] Enable Intel TDX in OvmfPkg (Config-A)

["gaoliming" <gaoliming@byosoft.com.cn>]

Min:
  I suggest to add it into OvmfPkg/Library/PlatformInitLib/IntelTdx.c as the internal implementation. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Min Xu
> 发送时间: 2022年3月15日 15:12
> 收件人: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> 抄送: 'Brijesh Singh' <brijesh.singh@amd.com>; Dong, Eric
> <eric.dong@intel.com>; Aktas, Erdem <erdemaktas@google.com>; Wu, Hao
> A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; 'James
> Bottomley' <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Kumar, Rahul1 <rahul1.kumar@intel.com>; 'Tom Lendacky'
> <thomas.lendacky@amd.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> 'Gerd Hoffmann' <kraxel@redhat.com>
> 主题: Re: [edk2-devel] [PATCH V8 00/47] Enable Intel TDX in OvmfPkg
> (Config-A)
> 
> On March 15, 2022 11:55 AM, Gao Liming wrote:
> > Min:
> >   As Jiewen mentions, EFI_RESOURCE_MEMORY_UNACCEPTED will be in
> next
> > public spec. So, it can't be added now.
> >
> >   I suggest to add edk2 definition for this type in MdeModulePkg first, such
> as
> > EDKII_RESOURCE_MEMORY_UNACCEPTED. It can be removed after new
> spec is
> > published.
> >
> Thanks for the comments. In the patch
> EFI_RESOURCE_MEMORY_UNACCEPTED was defined in
> MdePkg/Include/Pi/PiHob.h.
> I check the MdeModulePkg/Include but don't find some proper header files
> for this definition.
> 
> Or can we define EFI_RESOURCE_MEMORY_UNACCEPTED in
> OvmfPkg/Library/PlatformInitLib/IntelTdx.c?
> In current stage all the unaccepted memory passed from host VMM are all
> accepted in OvmfPkg/Library/PlatformInitLib/IntelTdx.c. After that these
> unaccepted memory hob are transferred to private memory hob. So currently
> EFI_RESOURCE_MEMORY_UNACCEPTED is only seen in above IntelTdx.c.
> 
> [TDVF] Sec 7.3.1 defines the unaccepted memory resource HOB for DXE
> phase. But this is for the lazy-accept feature which will be implemented in the
> future.
> 
> What's your suggestion?
> 
> [TDVF]
> https://www.intel.com/content/dam/develop/external/us/en/documents/td
> x-virtual-firmware-design-guide-rev-1.01.pdf
> 
> Thanks
> Min
> 
> 
> 
>