From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.27550.1610933890960437231 for ; Sun, 17 Jan 2021 17:38:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 18 Jan 2021 09:38:06 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Agyeman Prince'" , "'Chasel Chiu'" , "'Deepika Kethi Reddy'" , "'Jeremy Soller'" , "'Kathappan Esakkithevar'" , "'Kelly Steele'" , "'Michael D Kinney'" , "'Nate DeSimone'" , =?UTF-8?Q?'Philippe_Mathieu-Daud=C3=A9'?= , "'Rangasai V Chaganty'" , "'Yi Qian'" , "'Zailiang Sun'" References: <20210113082843.9095-1-lersek@redhat.com> <20210113082843.9095-4-lersek@redhat.com> In-Reply-To: <20210113082843.9095-4-lersek@redhat.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItcGxhdGZvcm1zIFBBVENIIDMvM10gSW50ZWwgUGxhdGZvcm1zOiBhZGQgT3JkZXJlZENvbGxlY3Rpb25MaWIgY2xhc3MgcmVzb2x1dGlvbg==?= Date: Mon, 18 Jan 2021 09:38:06 +0800 Message-ID: <003701d6ed3a$91c2b0f0$b54812d0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJc+LoP7WBOU68wPGUc3+j5cN1JOQLwQFSJqQj/4RA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Laszlo: Can you add OrderedCollectionLib library instance into edk2-platforms\Pl= atform\Intel\MinPlatformPkg\Include\Dsc\CoreCommonLib.dsc? All Intel MinPlatform includes this file. Once this file is updated, the= ir OpenBoardPkg.dsc doesn't need to be changed. That means below DSCs can k= eep no change.=20 Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc |= 1 + Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc |= 1 + Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc |= 1 + Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc |= 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc |= 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc |= 1 + Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+70213+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Laszlo= Ersek > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B41=E6=9C=8813=E6=97=A5= 16:29 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Agyeman Prince ; Chasel Ch= iu > ; Deepika Kethi Reddy > ; Jeremy Soller ; > Kathappan Esakkithevar ; Kelly Steele > ; Michael D Kinney ; > Nate DeSimone ; Philippe Mathieu-Daud=C3= = =A9 > ; Rangasai V Chaganty > ; Yi Qian ; Zailiang S= un > > =E4=B8=BB=E9=A2=98: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platfo= rms: add > OrderedCollectionLib class resolution >=20 > The edk2 patch >=20 > ShellPkg/ShellCommandLib: add ShellSortFileList >=20 > for BZ#3151 will make the >=20 > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf >=20 > instance dependent on the OrderedCollectionLib class. Because the shell > binaries in the Intel platform DSCs consume the above UefiShellCommandLi= b > instance, resolve the OrderedCollectionLib class in them. >=20 > Cc: Agyeman Prince > Cc: Chasel Chiu > Cc: Deepika Kethi Reddy > Cc: Jeremy Soller > Cc: Kathappan Esakkithevar > Cc: Kelly Steele > Cc: Michael D Kinney > Cc: Nate DeSimone > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Rangasai V Chaganty > Cc: Yi Qian > Cc: Zailiang Sun > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3151 > Signed-off-by: Laszlo Ersek > --- >=20 > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > | 1 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 1 + > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > | 1 + > Platform/Intel/QuarkPlatformPkg/Quark.dsc > | 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > | 1 + > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > | 1 + > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg > .dsc | 1 + > 10 files changed, 10 insertions(+) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > index 6de834565a7a..775eda4b03bc 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > @@ -378,6 +378,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman > dLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.in= f > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index 862e6a6655a3..c400173f7e0a 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -350,6 +350,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman > dLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.in= f > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 0b30da8f9665..d76c220b9145 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -429,6 +429,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman > dLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.in= f > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > index 9f64dcb62724..e29c7465b1e4 100644 > --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > @@ -912,6 +912,7 @@ [Components.IA32] >=20 > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com > mandsLib.inf >=20 > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 > CommandsLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > index db144aab75ae..6fdfba9a58dc 100644 > --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > @@ -639,6 +639,7 @@ [Components.IA32] >=20 > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com > mandsLib.inf >=20 > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 > CommandsLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index 77c408a326db..186e0a0df980 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -270,6 +270,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman > dLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.in= f > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 4fa3e2013120..409f31c982d7 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -1152,6 +1152,7 @@ [Components.IA32] >=20 > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com > mandsLib.inf >=20 > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 > CommandsLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 8adae2e24993..38bd825c8bdc 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -1167,6 +1167,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com > mandsLib.inf >=20 > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 > CommandsLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf > > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > index fb493973e22d..463234a3d948 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > @@ -371,6 +371,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman > dLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.in= f > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > index 9a1f107fafe1..586fa848650f 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > @@ -377,6 +377,7 @@ [Components.X64] >=20 > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman > dLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsing= L > ib.inf > + > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi > b/BaseOrderedCollectionRedBlackTreeLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf >=20 > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.in= f > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > -- > 2.19.1.3.g30247aa5d201 >=20 >=20 >=20 >=20 >=20